Skip to content

Commit 2a1ae17

Browse files
macklinuSimenB
authored andcommitted
refactor(no-jest-import): use ESQuery syntax for selectors (#158)
1 parent f2d2dbe commit 2a1ae17

File tree

1 file changed

+8
-26
lines changed

1 file changed

+8
-26
lines changed

rules/no-jest-import.js

Lines changed: 8 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
const getDocsUrl = require('./util').getDocsUrl;
4-
const getNodeName = require('./util').getNodeName;
4+
55
const message = `Jest is automatically in scope. Do not import "jest", as Jest doesn't export anything.`;
66

77
module.exports = {
@@ -12,32 +12,14 @@ module.exports = {
1212
},
1313
create(context) {
1414
return {
15-
ImportDeclaration(node) {
16-
if (node.source.value === 'jest') {
17-
context.report({
18-
node,
19-
message,
20-
});
21-
}
15+
'ImportDeclaration[source.value="jest"]'(node) {
16+
context.report({ node, message });
2217
},
23-
CallExpression(node) {
24-
const calleeName = getNodeName(node.callee);
25-
if (
26-
calleeName === 'require' &&
27-
node.arguments[0] &&
28-
node.arguments[0].value === 'jest'
29-
) {
30-
context.report({
31-
loc: {
32-
end: {
33-
column: node.arguments[0].loc.end.column,
34-
line: node.arguments[0].loc.end.line,
35-
},
36-
start: node.arguments[0].loc.start,
37-
},
38-
message,
39-
});
40-
}
18+
'CallExpression[callee.name="require"][arguments.0.value="jest"]'(node) {
19+
context.report({
20+
loc: node.arguments[0].loc,
21+
message,
22+
});
4123
},
4224
};
4325
},

0 commit comments

Comments
 (0)