fix(coverage): get close to 100% test coverage (#67)

Author: SimenB

.travis.yml

@@ -14,7 +14,7 @@ script:
 - yarn commitlint --from="$TRAVIS_BRANCH" --to="$TRAVIS_COMMIT"
 - yarn commitlint --from=$TRAVIS_COMMIT
 - yarn prettylint
-- yarn test
+- yarn test --coverage
 after_script: greenkeeper-lockfile-upload
 jobs:
   include:

package.json

@@ -51,6 +51,14 @@
     "*.{md,json}": ["prettier --write", "git add"]
   },
   "jest": {
+    "coverageThreshold": {
+      "global": {
+        "branches": 96,
+        "functions": 97,
+        "lines": 99,
+        "statements": 99
+      }
+    },
     "projects": [
       {
         "displayName": "test",

rules/__tests__/no-disabled-tests.test.js

@@ -15,6 +15,8 @@ ruleTester.run('no-disabled-tests', rule, {
     'test.only("foo", function () {})',
     'var appliedSkip = describe.skip; appliedSkip.apply(describe)',
     'var calledSkip = it.skip; calledSkip.call(it)',
+    '({ f: function () {} }).f()',
+    '(a || b).f()',
   ],
 
   invalid: [
@@ -80,6 +82,10 @@ ruleTester.run('no-disabled-tests', rule, {
         { message: 'Call to pending() within test', column: 48, line: 1 },
       ],
     },
+    {
+      code: 'pending();',
+      errors: [{ message: 'Call to pending()', column: 1, line: 1 }],
+    },
     {
       code: 'describe("contains a call to pending", function () { pending() })',
       errors: [

rules/no-disabled-tests.js

@@ -69,6 +69,11 @@ module.exports = {
                 message: 'Call to pending() within test suite',
                 node,
               });
+            } else {
+              context.report({
+                message: 'Call to pending()',
+                node,
+              });
             }
             break;
 

rules/util.js

@@ -129,14 +129,15 @@ const isFunction = node =>
  * package version to build the link to a tagged version of the
  * documentation file.
  *
- * @param {string} ruleName - Name of the eslint rule
+ * @param {string} filename - Name of the eslint rule
  * @returns {string} URL to the documentation for the given rule
  * @throws {Error} If the documentation file for the given rule is not present.
  */
 const getDocsUrl = filename => {
   const ruleName = path.basename(filename, '.js');
 
   const docsFile = path.join(__dirname, `../docs/rules/${ruleName}.md`);
+  // istanbul ignore if
   if (!fs.existsSync(docsFile)) {
     throw new Error(`Could not find documentation file for rule "${ruleName}"`);
   }