chore: rewrite implementation to return early when linting over unwanted LoCs

Signed-off-by: hainenber <[email protected]>

Author: hainenber

src/rules/__tests__/valid-mocked-module-path.test.ts

@@ -1,3 +1,4 @@
+import dedent from 'dedent';
 import rule from '../valid-mocked-module-path';
 import { FlatCompatRuleTester as RuleTester, espreeParser } from './test-utils';
 
@@ -11,13 +12,26 @@ const ruleTester = new RuleTester({
 ruleTester.run('valid-mocked-module-path', rule, {
   valid: [
     { filename: __filename, code: 'jest.mock("./fixtures/module")' },
+    { filename: __filename, code: 'jest.mock("./fixtures/module", () => {})' },
+    { filename: __filename, code: 'jest.mock()' },
+    {
+      filename: __filename,
+      code: 'jest.doMock("./fixtures/module", () => {})',
+    },
+    {
+      filename: __filename,
+      code: dedent`
+        describe("foo", () => {});
+      `,
+    },
     { filename: __filename, code: 'jest.doMock("./fixtures/module")' },
     { filename: __filename, code: 'jest.mock("./fixtures/module/foo.ts")' },
     { filename: __filename, code: 'jest.doMock("./fixtures/module/foo.ts")' },
     { filename: __filename, code: 'jest.mock("./fixtures/module/foo.js")' },
     { filename: __filename, code: 'jest.doMock("./fixtures/module/foo.js")' },
-    'jest.mock("dedent")',
-    'jest.doMock("dedent")',
+    'jest.mock("eslint")',
+    'jest.doMock("eslint")',
+    'jest.mock("child_process")',
   ],
   invalid: [
     {

src/rules/valid-mocked-module-path.ts

@@ -34,50 +34,64 @@ export default createRule({
         const { property } = callee;
 
         if (
-          node.arguments.length >= 1 &&
-          isTypeOfJestFnCall(node, context, ['jest']) &&
-          isSupportedAccessor(property) &&
-          ['mock', 'doMock'].includes(getAccessorValue(property))
+          !node.arguments.length ||
+          !isTypeOfJestFnCall(node, context, ['jest']) ||
+          !(
+            isSupportedAccessor(property) &&
+            ['mock', 'doMock'].includes(getAccessorValue(property))
+          )
         ) {
-          const [nameNode] = node.arguments;
-          const moduleName = findModuleName(nameNode);
+          return;
+        }
 
-          try {
-            if (moduleName) {
-              if (moduleName.value.startsWith('.')) {
-                const resolvedModulePath = path.resolve(
-                  path.dirname(context.filename),
-                  moduleName.value,
-                );
+        const [nameNode] = node.arguments;
+        const moduleName = findModuleName(nameNode);
+
+        /* istanbul ignore if */
+        if (!moduleName) {
+          throw new Error(
+            'Cannot parse mocked module name from `jest.mock` -  - please file a github issue at https://github.com/jest-community/eslint-plugin-jest`',
+          );
+        }
 
-                const hasPossiblyModulePaths = ['', '.js', '.ts']
-                  .map(ext => `${resolvedModulePath}${ext}`)
-                  .some(modPath => {
-                    try {
-                      statSync(modPath);
+        try {
+          if (moduleName.value.startsWith('.')) {
+            const resolvedModulePath = path.resolve(
+              path.dirname(context.filename),
+              moduleName.value,
+            );
 
-                      return true;
-                    } catch {
-                      return false;
-                    }
-                  });
+            const hasPossiblyModulePaths = ['', '.js', '.ts']
+              .map(ext => `${resolvedModulePath}${ext}`)
+              .some(modPath => {
+                try {
+                  statSync(modPath);
 
-                if (!hasPossiblyModulePaths) {
-                  throw { code: 'MODULE_NOT_FOUND' };
+                  return true;
+                } catch {
+                  return false;
                 }
-              } else {
-                require.resolve(moduleName.value);
-              }
-            }
-          } catch (err: any) {
-            if (err?.code === 'MODULE_NOT_FOUND' || err?.code === 'ENOENT') {
-              context.report({
-                messageId: 'invalidMockModulePath',
-                data: { moduleName: moduleName?.raw ?? './module-name' },
-                node,
               });
+
+            if (!hasPossiblyModulePaths) {
+              throw { code: 'MODULE_NOT_FOUND' };
             }
+          } else {
+            require.resolve(moduleName.value);
           }
+        } catch (err: any) {
+          // Skip over any unexpected issues when attempt to verify mocked module path.
+          // The list of possible errors is non-exhaustive.
+          /* istanbul ignore if */
+          if (!['MODULE_NOT_FOUND', 'ENOENT'].includes(err.code)) {
+            return;
+          }
+
+          context.report({
+            messageId: 'invalidMockModulePath',
+            data: { moduleName: moduleName.raw },
+            node,
+          });
         }
       },
     };