Skip to content

Commit b4319e8

Browse files
authored
test(valid-describe): use dedent for multi-line cases (#673)
1 parent 8810d67 commit b4319e8

File tree

1 file changed

+59
-58
lines changed

1 file changed

+59
-58
lines changed

src/rules/__tests__/valid-describe.test.ts

Lines changed: 59 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { TSESLint } from '@typescript-eslint/experimental-utils';
2+
import dedent from 'dedent';
23
import resolveFrom from 'resolve-from';
34
import rule from '../valid-describe';
45

@@ -24,30 +25,30 @@ ruleTester.run('valid-describe', rule, {
2425
'fdescribe("foo", () => {})',
2526
'describe.only("foo", () => {})',
2627
'describe.skip("foo", () => {})',
27-
`
28-
describe('foo', () => {
29-
it('bar', () => {
30-
return Promise.resolve(42).then(value => {
31-
expect(value).toBe(42)
28+
dedent`
29+
describe('foo', () => {
30+
it('bar', () => {
31+
return Promise.resolve(42).then(value => {
32+
expect(value).toBe(42)
33+
})
3234
})
3335
})
34-
})
3536
`,
36-
`
37-
describe('foo', () => {
38-
it('bar', async () => {
39-
expect(await Promise.resolve(42)).toBe(42)
37+
dedent`
38+
describe('foo', () => {
39+
it('bar', async () => {
40+
expect(await Promise.resolve(42)).toBe(42)
41+
})
4042
})
41-
})
4243
`,
43-
`
44-
describe('foo', () =>
45-
test('bar', () => {})
46-
)
44+
dedent`
45+
describe('foo', () =>
46+
test('bar', () => {})
47+
)
4748
`,
48-
`
49-
if (hasOwnProperty(obj, key)) {
50-
}
49+
dedent`
50+
if (hasOwnProperty(obj, key)) {
51+
}
5152
`,
5253
],
5354
invalid: [
@@ -114,72 +115,72 @@ ruleTester.run('valid-describe', rule, {
114115
errors: [{ messageId: 'noAsyncDescribeCallback', line: 1, column: 22 }],
115116
},
116117
{
117-
code: `
118-
describe('sample case', () => {
119-
it('works', () => {
120-
expect(true).toEqual(true);
121-
});
122-
describe('async', async () => {
123-
await new Promise(setImmediate);
124-
it('breaks', () => {
125-
throw new Error('Fail');
118+
code: dedent`
119+
describe('sample case', () => {
120+
it('works', () => {
121+
expect(true).toEqual(true);
122+
});
123+
describe('async', async () => {
124+
await new Promise(setImmediate);
125+
it('breaks', () => {
126+
throw new Error('Fail');
127+
});
126128
});
127129
});
128-
});
129130
`,
130-
errors: [{ messageId: 'noAsyncDescribeCallback', line: 6, column: 27 }],
131+
errors: [{ messageId: 'noAsyncDescribeCallback', line: 5, column: 21 }],
131132
},
132133
{
133-
code: `
134-
describe('foo', function () {
135-
return Promise.resolve().then(() => {
136-
it('breaks', () => {
137-
throw new Error('Fail')
134+
code: dedent`
135+
describe('foo', function () {
136+
return Promise.resolve().then(() => {
137+
it('breaks', () => {
138+
throw new Error('Fail')
139+
})
138140
})
139141
})
140-
})
141142
`,
142-
errors: [{ messageId: 'unexpectedReturnInDescribe', line: 3, column: 9 }],
143+
errors: [{ messageId: 'unexpectedReturnInDescribe', line: 2, column: 3 }],
143144
},
144145
{
145-
code: `
146-
describe('foo', () => {
147-
return Promise.resolve().then(() => {
148-
it('breaks', () => {
149-
throw new Error('Fail')
150-
})
151-
})
152-
describe('nested', () => {
146+
code: dedent`
147+
describe('foo', () => {
153148
return Promise.resolve().then(() => {
154149
it('breaks', () => {
155150
throw new Error('Fail')
156151
})
157152
})
153+
describe('nested', () => {
154+
return Promise.resolve().then(() => {
155+
it('breaks', () => {
156+
throw new Error('Fail')
157+
})
158+
})
159+
})
158160
})
159-
})
160161
`,
161162
errors: [
162-
{ messageId: 'unexpectedReturnInDescribe', line: 3, column: 9 },
163-
{ messageId: 'unexpectedReturnInDescribe', line: 9, column: 11 },
163+
{ messageId: 'unexpectedReturnInDescribe', line: 2, column: 3 },
164+
{ messageId: 'unexpectedReturnInDescribe', line: 8, column: 5 },
164165
],
165166
},
166167
{
167-
code: `
168-
describe('foo', async () => {
169-
await something()
170-
it('does something')
171-
describe('nested', () => {
172-
return Promise.resolve().then(() => {
173-
it('breaks', () => {
174-
throw new Error('Fail')
168+
code: dedent`
169+
describe('foo', async () => {
170+
await something()
171+
it('does something')
172+
describe('nested', () => {
173+
return Promise.resolve().then(() => {
174+
it('breaks', () => {
175+
throw new Error('Fail')
176+
})
175177
})
176178
})
177179
})
178-
})
179180
`,
180181
errors: [
181-
{ messageId: 'noAsyncDescribeCallback', line: 2, column: 23 },
182-
{ messageId: 'unexpectedReturnInDescribe', line: 6, column: 11 },
182+
{ messageId: 'noAsyncDescribeCallback', line: 1, column: 17 },
183+
{ messageId: 'unexpectedReturnInDescribe', line: 5, column: 5 },
183184
],
184185
},
185186
{

0 commit comments

Comments
 (0)