Skip to content

Commit ed341a6

Browse files
G-RathG-Rath
committed
chore(no-if): messageId noConditionalExpect -> conditionalInTest 
1 parent 6d1eda8 commit ed341a6

File tree

2 files changed

+45
-46
lines changed

2 files changed

+45
-46
lines changed

‎src/rules/__tests__/no-if.test.ts

Lines changed: 43 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ ruleTester.run('conditional expressions', rule, {
3131
errors: [
3232
{
3333
data: { condition: 'conditional' },
34-
messageId: 'noConditionalExpect',
34+
messageId: 'conditionalInTest',
3535
},
3636
],
3737
},
@@ -44,7 +44,7 @@ ruleTester.run('conditional expressions', rule, {
4444
errors: [
4545
{
4646
data: { condition: 'conditional' },
47-
messageId: 'noConditionalExpect',
47+
messageId: 'conditionalInTest',
4848
},
4949
],
5050
},
@@ -57,11 +57,11 @@ ruleTester.run('conditional expressions', rule, {
5757
errors: [
5858
{
5959
data: { condition: 'conditional' },
60-
messageId: 'noConditionalExpect',
60+
messageId: 'conditionalInTest',
6161
},
6262
{
6363
data: { condition: 'conditional' },
64-
messageId: 'noConditionalExpect',
64+
messageId: 'conditionalInTest',
6565
},
6666
],
6767
},
@@ -187,7 +187,7 @@ ruleTester.run('switch statements', rule, {
187187
errors: [
188188
{
189189
data: { condition: 'switch' },
190-
messageId: 'noConditionalExpect',
190+
messageId: 'conditionalInTest',
191191
},
192192
],
193193
},
@@ -198,7 +198,7 @@ ruleTester.run('switch statements', rule, {
198198
errors: [
199199
{
200200
data: { condition: 'switch' },
201-
messageId: 'noConditionalExpect',
201+
messageId: 'conditionalInTest',
202202
},
203203
],
204204
},
@@ -209,7 +209,7 @@ ruleTester.run('switch statements', rule, {
209209
errors: [
210210
{
211211
data: { condition: 'switch' },
212-
messageId: 'noConditionalExpect',
212+
messageId: 'conditionalInTest',
213213
},
214214
],
215215
},
@@ -220,7 +220,7 @@ ruleTester.run('switch statements', rule, {
220220
errors: [
221221
{
222222
data: { condition: 'switch' },
223-
messageId: 'noConditionalExpect',
223+
messageId: 'conditionalInTest',
224224
},
225225
],
226226
},
@@ -231,7 +231,7 @@ ruleTester.run('switch statements', rule, {
231231
errors: [
232232
{
233233
data: { condition: 'switch' },
234-
messageId: 'noConditionalExpect',
234+
messageId: 'conditionalInTest',
235235
},
236236
],
237237
},
@@ -242,7 +242,7 @@ ruleTester.run('switch statements', rule, {
242242
errors: [
243243
{
244244
data: { condition: 'switch' },
245-
messageId: 'noConditionalExpect',
245+
messageId: 'conditionalInTest',
246246
},
247247
],
248248
},
@@ -253,7 +253,7 @@ ruleTester.run('switch statements', rule, {
253253
errors: [
254254
{
255255
data: { condition: 'switch' },
256-
messageId: 'noConditionalExpect',
256+
messageId: 'conditionalInTest',
257257
},
258258
],
259259
},
@@ -264,7 +264,7 @@ ruleTester.run('switch statements', rule, {
264264
errors: [
265265
{
266266
data: { condition: 'switch' },
267-
messageId: 'noConditionalExpect',
267+
messageId: 'conditionalInTest',
268268
},
269269
],
270270
},
@@ -275,7 +275,7 @@ ruleTester.run('switch statements', rule, {
275275
errors: [
276276
{
277277
data: { condition: 'switch' },
278-
messageId: 'noConditionalExpect',
278+
messageId: 'conditionalInTest',
279279
},
280280
],
281281
},
@@ -286,7 +286,7 @@ ruleTester.run('switch statements', rule, {
286286
errors: [
287287
{
288288
data: { condition: 'switch' },
289-
messageId: 'noConditionalExpect',
289+
messageId: 'conditionalInTest',
290290
},
291291
],
292292
},
@@ -297,7 +297,7 @@ ruleTester.run('switch statements', rule, {
297297
errors: [
298298
{
299299
data: { condition: 'switch' },
300-
messageId: 'noConditionalExpect',
300+
messageId: 'conditionalInTest',
301301
},
302302
],
303303
},
@@ -308,7 +308,7 @@ ruleTester.run('switch statements', rule, {
308308
errors: [
309309
{
310310
data: { condition: 'switch' },
311-
messageId: 'noConditionalExpect',
311+
messageId: 'conditionalInTest',
312312
},
313313
],
314314
},
@@ -319,7 +319,7 @@ ruleTester.run('switch statements', rule, {
319319
errors: [
320320
{
321321
data: { condition: 'switch' },
322-
messageId: 'noConditionalExpect',
322+
messageId: 'conditionalInTest',
323323
},
324324
],
325325
},
@@ -332,7 +332,7 @@ ruleTester.run('switch statements', rule, {
332332
errors: [
333333
{
334334
data: { condition: 'switch' },
335-
messageId: 'noConditionalExpect',
335+
messageId: 'conditionalInTest',
336336
},
337337
],
338338
},
@@ -341,7 +341,7 @@ ruleTester.run('switch statements', rule, {
341341
errors: [
342342
{
343343
data: { condition: 'switch' },
344-
messageId: 'noConditionalExpect',
344+
messageId: 'conditionalInTest',
345345
},
346346
],
347347
},
@@ -358,15 +358,15 @@ ruleTester.run('switch statements', rule, {
358358
errors: [
359359
{
360360
data: { condition: 'switch' },
361-
messageId: 'noConditionalExpect',
361+
messageId: 'conditionalInTest',
362362
},
363363
{
364364
data: { condition: 'switch' },
365-
messageId: 'noConditionalExpect',
365+
messageId: 'conditionalInTest',
366366
},
367367
{
368368
data: { condition: 'switch' },
369-
messageId: 'noConditionalExpect',
369+
messageId: 'conditionalInTest',
370370
},
371371
],
372372
},
@@ -379,7 +379,7 @@ ruleTester.run('switch statements', rule, {
379379
errors: [
380380
{
381381
data: { condition: 'switch' },
382-
messageId: 'noConditionalExpect',
382+
messageId: 'conditionalInTest',
383383
},
384384
],
385385
},
@@ -408,7 +408,7 @@ ruleTester.run('switch statements', rule, {
408408
errors: [
409409
{
410410
data: { condition: 'switch' },
411-
messageId: 'noConditionalExpect',
411+
messageId: 'conditionalInTest',
412412
},
413413
],
414414
},
@@ -559,7 +559,7 @@ ruleTester.run('if statements', rule, {
559559
errors: [
560560
{
561561
data: { condition: 'if' },
562-
messageId: 'noConditionalExpect',
562+
messageId: 'conditionalInTest',
563563
},
564564
],
565565
},
@@ -570,7 +570,7 @@ ruleTester.run('if statements', rule, {
570570
errors: [
571571
{
572572
data: { condition: 'if' },
573-
messageId: 'noConditionalExpect',
573+
messageId: 'conditionalInTest',
574574
},
575575
],
576576
},
@@ -581,7 +581,7 @@ ruleTester.run('if statements', rule, {
581581
errors: [
582582
{
583583
data: { condition: 'if' },
584-
messageId: 'noConditionalExpect',
584+
messageId: 'conditionalInTest',
585585
},
586586
],
587587
},
@@ -592,7 +592,7 @@ ruleTester.run('if statements', rule, {
592592
errors: [
593593
{
594594
data: { condition: 'if' },
595-
messageId: 'noConditionalExpect',
595+
messageId: 'conditionalInTest',
596596
},
597597
],
598598
},
@@ -603,7 +603,7 @@ ruleTester.run('if statements', rule, {
603603
errors: [
604604
{
605605
data: { condition: 'if' },
606-
messageId: 'noConditionalExpect',
606+
messageId: 'conditionalInTest',
607607
},
608608
],
609609
},
@@ -614,7 +614,7 @@ ruleTester.run('if statements', rule, {
614614
errors: [
615615
{
616616
data: { condition: 'if' },
617-
messageId: 'noConditionalExpect',
617+
messageId: 'conditionalInTest',
618618
},
619619
],
620620
},
@@ -625,7 +625,7 @@ ruleTester.run('if statements', rule, {
625625
errors: [
626626
{
627627
data: { condition: 'if' },
628-
messageId: 'noConditionalExpect',
628+
messageId: 'conditionalInTest',
629629
},
630630
],
631631
},
@@ -636,7 +636,7 @@ ruleTester.run('if statements', rule, {
636636
errors: [
637637
{
638638
data: { condition: 'if' },
639-
messageId: 'noConditionalExpect',
639+
messageId: 'conditionalInTest',
640640
},
641641
],
642642
},
@@ -647,7 +647,7 @@ ruleTester.run('if statements', rule, {
647647
errors: [
648648
{
649649
data: { condition: 'if' },
650-
messageId: 'noConditionalExpect',
650+
messageId: 'conditionalInTest',
651651
},
652652
],
653653
},
@@ -658,7 +658,7 @@ ruleTester.run('if statements', rule, {
658658
errors: [
659659
{
660660
data: { condition: 'if' },
661-
messageId: 'noConditionalExpect',
661+
messageId: 'conditionalInTest',
662662
},
663663
],
664664
},
@@ -669,7 +669,7 @@ ruleTester.run('if statements', rule, {
669669
errors: [
670670
{
671671
data: { condition: 'if' },
672-
messageId: 'noConditionalExpect',
672+
messageId: 'conditionalInTest',
673673
},
674674
],
675675
},
@@ -680,7 +680,7 @@ ruleTester.run('if statements', rule, {
680680
errors: [
681681
{
682682
data: { condition: 'if' },
683-
messageId: 'noConditionalExpect',
683+
messageId: 'conditionalInTest',
684684
},
685685
],
686686
},
@@ -693,7 +693,7 @@ ruleTester.run('if statements', rule, {
693693
errors: [
694694
{
695695
data: { condition: 'if' },
696-
messageId: 'noConditionalExpect',
696+
messageId: 'conditionalInTest',
697697
},
698698
],
699699
},
@@ -702,7 +702,7 @@ ruleTester.run('if statements', rule, {
702702
errors: [
703703
{
704704
data: { condition: 'if' },
705-
messageId: 'noConditionalExpect',
705+
messageId: 'conditionalInTest',
706706
},
707707
],
708708
},
@@ -719,15 +719,15 @@ ruleTester.run('if statements', rule, {
719719
errors: [
720720
{
721721
data: { condition: 'if' },
722-
messageId: 'noConditionalExpect',
722+
messageId: 'conditionalInTest',
723723
},
724724
{
725725
data: { condition: 'if' },
726-
messageId: 'noConditionalExpect',
726+
messageId: 'conditionalInTest',
727727
},
728728
{
729729
data: { condition: 'if' },
730-
messageId: 'noConditionalExpect',
730+
messageId: 'conditionalInTest',
731731
},
732732
],
733733
},
@@ -740,7 +740,7 @@ ruleTester.run('if statements', rule, {
740740
errors: [
741741
{
742742
data: { condition: 'if' },
743-
messageId: 'noConditionalExpect',
743+
messageId: 'conditionalInTest',
744744
},
745745
],
746746
},
@@ -767,7 +767,7 @@ ruleTester.run('if statements', rule, {
767767
errors: [
768768
{
769769
data: { condition: 'if' },
770-
messageId: 'noConditionalExpect',
770+
messageId: 'conditionalInTest',
771771
},
772772
],
773773
},

‎src/rules/no-if.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ export default createRule({
4343
recommended: false,
4444
},
4545
messages: {
46-
noConditionalExpect:
47-
'Test should not contain {{ condition }} statements.',
46+
conditionalInTest: 'Test should not contain {{ condition }} statements.',
4847
},
4948
schema: [],
5049
type: 'suggestion',
@@ -67,7 +66,7 @@ export default createRule({
6766

6867
context.report({
6968
data: { condition: conditionName[node.type] },
70-
messageId: 'noConditionalExpect',
69+
messageId: 'conditionalInTest',
7170
node,
7271
});
7372
}

0 commit comments

Comments
 (0)