From c1d48b22a14277d29560a716e3c01cfe0d0de442 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20De=20Boey?= Date: Mon, 20 Sep 2021 14:26:03 +0200 Subject: [PATCH 1/5] chore: update CI --- .github/workflows/nodejs.yml | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 5129ba5c7..c6ea5279d 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -18,9 +18,9 @@ jobs: steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v2.4.0 + - uses: actions/setup-node@v2 with: - node-version: 14.x + node-version: 16 cache: yarn - name: Validate cache @@ -36,9 +36,9 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v2.4.0 + - uses: actions/setup-node@v2 with: - node-version: 14.x + node-version: 16 cache: yarn - name: install run: yarn @@ -50,9 +50,9 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v2.4.0 + - uses: actions/setup-node@v2 with: - node-version: 14.x + node-version: 16 cache: yarn - name: install run: yarn @@ -74,7 +74,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v2.4.0 + uses: actions/setup-node@v2 with: node-version: ${{ matrix.node-version }} cache: yarn @@ -100,9 +100,9 @@ jobs: steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v2.4.0 + - uses: actions/setup-node@v2 with: - node-version: 14.x + node-version: 16 cache: yarn - name: install run: yarn @@ -117,9 +117,9 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v2.4.0 + - uses: actions/setup-node@v2 with: - node-version: 14.x + node-version: 16 cache: yarn - name: install run: yarn @@ -140,9 +140,9 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v2.4.0 + - uses: actions/setup-node@v2 with: - node-version: 14.x + node-version: 16 cache: yarn - name: install run: yarn From e3e93235c5a3c6532520b9fec6965c9562083152 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Tue, 21 Sep 2021 14:57:18 +0200 Subject: [PATCH 2/5] chore: keep using node LTS --- .github/workflows/nodejs.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index c6ea5279d..93ec02ac6 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -20,7 +20,7 @@ jobs: - uses: actions/setup-node@v2 with: - node-version: 16 + node-version: 14.x cache: yarn - name: Validate cache @@ -38,7 +38,7 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-node@v2 with: - node-version: 16 + node-version: 14.x cache: yarn - name: install run: yarn @@ -52,7 +52,7 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-node@v2 with: - node-version: 16 + node-version: 14.x cache: yarn - name: install run: yarn @@ -102,7 +102,7 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-node@v2 with: - node-version: 16 + node-version: 14.x cache: yarn - name: install run: yarn @@ -119,7 +119,7 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-node@v2 with: - node-version: 16 + node-version: 14.x cache: yarn - name: install run: yarn @@ -142,7 +142,7 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-node@v2 with: - node-version: 16 + node-version: 14.x cache: yarn - name: install run: yarn From da21544cfbe5dac9d75bcfe59f0241581bdcb460 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Tue, 21 Sep 2021 14:59:00 +0200 Subject: [PATCH 3/5] chore: use major of danger and codecov actions as well --- .github/workflows/lint.yml | 2 +- .github/workflows/nodejs.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 18c564540..891cc4834 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -18,6 +18,6 @@ jobs: steps: - uses: actions/checkout@v2 - name: Danger - uses: danger/danger-js@10.6.6 + uses: danger/danger-js@10 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 93ec02ac6..e2a15b722 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -87,7 +87,7 @@ jobs: run: yarn test --coverage ${{ matrix.eslint-version >= 6 }} env: CI: true - - uses: codecov/codecov-action@v2.1.0 + - uses: codecov/codecov-action@v2 if: ${{ matrix.eslint-version >= 6 }} test-os: name: Test on ${{ matrix.os }} using Node.js LTS From 2f89c2dc313ba16e33c98dea78455a25391cf847 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Tue, 21 Sep 2021 15:01:08 +0200 Subject: [PATCH 4/5] chore: add missing v (maybe?) --- .github/workflows/lint.yml | 2 +- .github/workflows/nodejs.yml | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 891cc4834..12549d59b 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -18,6 +18,6 @@ jobs: steps: - uses: actions/checkout@v2 - name: Danger - uses: danger/danger-js@10 + uses: danger/danger-js@v10 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index e2a15b722..5f4c9320d 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -110,6 +110,8 @@ jobs: run: yarn test --coverage env: CI: true + - uses: codecov/codecov-action@v2 + if: ${{ matrix.eslint-version >= 6 }} docs: if: ${{ github.event_name == 'pull_request' }} From d5f45964050e0d37c9f920560f2ed5b5663c156e Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Tue, 21 Sep 2021 15:04:13 +0200 Subject: [PATCH 5/5] chore: danger needs specific version --- .github/workflows/lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 12549d59b..18c564540 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -18,6 +18,6 @@ jobs: steps: - uses: actions/checkout@v2 - name: Danger - uses: danger/danger-js@v10 + uses: danger/danger-js@10.6.6 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}