Skip to content

Do not report 'testExecError' if 'noResults' #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not report 'testExecError' if 'noResults' #259

wants to merge 1 commit into from

Conversation

ivailop
Copy link

@ivailop ivailop commented Aug 15, 2023

When there are noResults (and "reportTestSuiteErrors" is enabled) the resulting XML contains double test-case errors:

  <testsuite name="tests\failed.to.run.test.js" errors="1" failures="0" skipped="0" timestamp="1970-01-01T00:00:00" time="0" tests="0">
    <testcase classname="Test suite failed to run" name="tests\failed.to.run.test.js" time="0" file="tests\failed.to.run.test.js">
      <error>  ● Test suite failed to run

    ProtocolError: Page.captureScreenshot timed out. Increase the &apos;protocolTimeout&apos; setting in launch/connect calls for a higher timeout if needed.

      at Callback.&lt;instance_members_initializer&gt; (../node_modules/puppeteer-core/src/common/Connection.ts:66:12)
      at new Callback (../node_modules/puppeteer-core/src/common/Connection.ts:71:3)
      at CallbackRegistry.create (../node_modules/puppeteer-core/src/common/Connection.ts:127:22)
      at Connection._rawSend (../node_modules/puppeteer-core/src/common/Connection.ts:278:22)
      at CDPSessionImpl.send (../node_modules/puppeteer-core/src/common/Connection.ts:562:29)
      at CDPPage.#screenshotTask (../node_modules/puppeteer-core/src/common/Page.ts:1321:39)
      </error>
    </testcase>
    <testcase classname="Test suite failed to run" name="tests\failed.to.run.test.js" time="0" file="tests\failed.to.run.test.js">
      <failure>&quot;Page.captureScreenshot timed out. Increase the &apos;protocolTimeout&apos; setting in launch/connect calls for a higher timeout if needed.&quot;</failure>
    </testcase>
  </testsuite>

The second test-case is redundant and should better be suppressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ivailop