Fix linting

Author: nicolo-ribaudo

jest.globalSetup.mjs

@@ -2,7 +2,7 @@ import {createRequire} from 'node:module';
 const require = createRequire(import.meta.url);
 
 const requireFrom = (from, name) => {
-  if (parseInt(process.versions.node, 10) < 20) {
+  if (Number.parseInt(process.versions.node, 10) < 20) {
     return null;
   }
   return require(
@@ -12,7 +12,7 @@ const requireFrom = (from, name) => {
   );
 };
 
-export default async function () {
+export default async function globalSetup() {
   globalThis.preloadedDependencies = {
     'babel-jest': {
       '@babel-8/core': requireFrom('babel-jest', '@babel-8/core'),

packages/babel-jest/src/__tests__/getCacheKey.test.ts

@@ -13,6 +13,8 @@ import babelJest from '../index';
 // because this test file is being transpiled, leading to require(esm), which
 // we don't support yet.
 declare global {
+  // We need to use `var` to declare a global variable
+  // eslint-disable-next-line no-var
   var preloadedDependencies: {
     'babel-jest': {
       '@babel-8/core': null | typeof import('@babel-8/core');
@@ -46,13 +48,13 @@ afterEach(() => {
 
 describe.each(
   [
-    {version: '7', babel: require('@babel/core')},
+    {babel: require('@babel/core'), version: '7'},
     {
-      version: '8',
       babel: globalThis.preloadedDependencies['babel-jest']['@babel-8/core'],
+      version: '8',
     },
-  ].filter(v => v.babel),
-)(`babel $version`, ({babel}) => {
+  ].filter(v => v.babel !== null),
+)('babel $version', ({babel}) => {
   describe('getCacheKey', () => {
     const sourceText = 'mock source';
     const sourcePath = 'mock-source-path.js';

packages/babel-jest/src/__tests__/index.ts

@@ -17,6 +17,8 @@ import babelJest, {createTransformer} from '../index';
 // because this test file is being transpiled, leading to require(esm), which
 // we don't support yet.
 declare global {
+  // We need to use `var` to declare a global variable
+  // eslint-disable-next-line no-var
   var preloadedDependencies: {
     'babel-jest': {
       '@babel-8/core': null | typeof import('@babel-8/core');
@@ -26,7 +28,7 @@ declare global {
 
 type BabelCore = typeof import('@babel-8/core');
 
-var mockedBabel!: {
+let mockedBabel!: {
   transformSync: jest.Mock<BabelCore['transformSync']>;
   transformAsync: jest.Mock<BabelCore['transformAsync']>;
   loadPartialConfigSync: jest.Mock<BabelCore['loadPartialConfigSync']>;
@@ -35,10 +37,10 @@ var mockedBabel!: {
 
 jest.mock('../babel', () => {
   return (mockedBabel = {
-    transformSync: jest.fn<BabelCore['transformSync']>(),
-    transformAsync: jest.fn<BabelCore['transformAsync']>(),
-    loadPartialConfigSync: jest.fn<BabelCore['loadPartialConfigSync']>(),
     loadPartialConfigAsync: jest.fn<BabelCore['loadPartialConfigAsync']>(),
+    loadPartialConfigSync: jest.fn<BabelCore['loadPartialConfigSync']>(),
+    transformAsync: jest.fn<BabelCore['transformAsync']>(),
+    transformSync: jest.fn<BabelCore['transformSync']>(),
   });
 });
 
@@ -60,13 +62,13 @@ customMultiply({a: 32, dummy: "test"}, 2);
 
 describe.each(
   [
-    {version: '7', babel: require('@babel/core')},
+    {babel: require('@babel/core'), version: '7'},
     {
-      version: '8',
       babel: globalThis.preloadedDependencies['babel-jest']['@babel-8/core'],
+      version: '8',
     },
-  ].filter(v => v.babel),
-)(`babel $version`, ({babel}: {babel: BabelCore}) => {
+  ].filter(v => v.babel !== null),
+)('babel $version', ({babel}: {babel: BabelCore}) => {
   beforeEach(() => {
     jest.clearAllMocks();
 

packages/babel-jest/src/babel.ts

@@ -14,7 +14,7 @@ export {
 
 import {
   loadPartialConfig,
-  // @ts-ignore -- Wrong @types/babel__core definition
+  // @ts-expect-error -- Wrong @types/babel__core definition
   loadPartialConfigSync,
 } from '@babel/core';
 

packages/babel-jest/src/index.ts

@@ -7,9 +7,9 @@
 
 import {createHash} from 'crypto';
 import * as path from 'path';
-import {
-  type TransformOptions as BabelTransformOptions,
-  type PartialConfig,
+import type {
+  TransformOptions as BabelTransformOptions,
+  PartialConfig,
 } from '@babel/core';
 import chalk from 'chalk';
 import * as fs from 'graceful-fs';
@@ -20,10 +20,10 @@ import type {
   TransformerCreator,
 } from '@jest/transform';
 import {
-  loadPartialConfigSync,
-  loadPartialConfigAsync,
   transformSync as babelTransform,
   transformAsync as babelTransformAsync,
+  loadPartialConfigAsync,
+  loadPartialConfigSync,
 } from './babel';
 
 interface TransformerConfig extends BabelTransformOptions {

packages/babel-plugin-jest-hoist/src/__tests__/hoistPlugin.test.ts

@@ -34,13 +34,12 @@ const formatResult = (code: string) => formatCode(code, prettierOptions);
 describe.each(
   [
     {
-      version: '7',
       babel: require('@babel/core'),
       presetReact: require('@babel/preset-react').default,
       presetTypescript: require('@babel/preset-typescript').default,
+      version: '7',
     },
     {
-      version: '8',
       babel: preloadedDependencies['babel-plugin-jest-hoist']['@babel-8/core'],
       presetReact:
         preloadedDependencies['babel-plugin-jest-hoist'][
@@ -50,8 +49,9 @@ describe.each(
         preloadedDependencies['babel-plugin-jest-hoist'][
           '@babel-8/preset-typescript'
         ],
+      version: '8',
     },
-  ].filter(v => v.babel),
+  ].filter(v => v.babel !== null),
 )('babel $version', ({babel, presetReact, presetTypescript}) => {
   pluginTester({
     babel,

packages/babel-plugin-jest-hoist/src/index.ts

@@ -8,18 +8,18 @@
 
 import type {PluginObj} from '@babel/core';
 import type {NodePath} from '@babel/traverse';
-import {
-  type CallExpression,
-  type Expression,
-  type Identifier,
-  type ImportDeclaration,
-  type MemberExpression,
-  type Node,
-  type Statement,
-  type StringLiteral,
-  type Super,
-  type VariableDeclaration,
-  type VariableDeclarator,
+import type {
+  CallExpression,
+  Expression,
+  Identifier,
+  ImportDeclaration,
+  MemberExpression,
+  Node,
+  Statement,
+  StringLiteral,
+  Super,
+  VariableDeclaration,
+  VariableDeclarator,
 } from '@babel/types';
 
 const JEST_GLOBAL_NAME = 'jest';

packages/babel-preset-jest/index.js

@@ -8,9 +8,10 @@
 const jestHoist = require.resolve('babel-plugin-jest-hoist');
 const currentNodeSyntax = require.resolve('babel-preset-current-node-syntax');
 
-module.exports = api => {
+const presetJest = api => {
   if (api.version && api.version.startsWith('8.')) {
     return {plugins: [jestHoist]};
   }
   return {plugins: [jestHoist], presets: [currentNodeSyntax]};
 };
+module.exports = presetJest;