refactor: single-pass tree walk in collectTestsWithoutRunning

Replace two-pass approach (collect entries then map with
getTestNamesPath walking back up the parent chain) with a single
recursive walk that tracks ancestors as it descends. This also
removes the need to export getTestNamesPath from utils.ts.

https://claude.ai/code/session_018SbTXFCAujDRRjBFtMTFXU

Author: alexander-turner

packages/jest-circus/src/legacy-code-todo-rewrite/jestAdapterInit.ts

@@ -33,7 +33,7 @@ import {
 } from '../state';
 import testCaseReportHandler from '../testCaseReportHandler';
 import {unhandledRejectionHandler} from '../unhandledRejectionHandler';
-import {getTestID, getTestNamesPath} from '../utils';
+import {getTestID} from '../utils';
 
 interface RuntimeGlobals extends Global.TestFrameworkGlobals {
   expect: JestExpect;
@@ -149,52 +149,43 @@ export const collectTestsWithoutRunning = async ({
 }): Promise<TestResult> => {
   const {rootDescribeBlock, testNamePattern} = getRunnerState();
 
-  const collectEntries = (
+  const assertionResults: Array<AssertionResult> = [];
+
+  const walk = (
     block: Circus.DescribeBlock,
-  ): Array<Circus.TestEntry> => {
-    const entries: Array<Circus.TestEntry> = [];
+    ancestors: Array<string>,
+  ): void => {
     for (const child of block.children) {
-      if (child.type === 'test') {
+      if (child.type === 'describeBlock') {
+        walk(child, [...ancestors, child.name]);
+      } else if (child.type === 'test') {
         if (!testNamePattern || testNamePattern.test(getTestID(child))) {
-          entries.push(child);
+          const title = child.name;
+          assertionResults.push({
+            ancestorTitles: [...ancestors],
+            duration: null,
+            failing: false,
+            failureDetails: [],
+            failureMessages: [],
+            fullName: [...ancestors, title].join(' '),
+            invocations: 0,
+            location: null,
+            numPassingAsserts: 0,
+            retryReasons: [],
+            startAt: null,
+            status: 'pending' as Status,
+            title,
+          });
         }
-      } else if (child.type === 'describeBlock') {
-        entries.push(...collectEntries(child));
       }
     }
-    return entries;
   };
-  const testEntries = collectEntries(rootDescribeBlock);
-
-  const assertionResults: Array<AssertionResult> = testEntries.map(test => {
-    const ancestorTitles = getTestNamesPath(test).filter(
-      name => name !== ROOT_DESCRIBE_BLOCK_NAME,
-    );
-    const title = ancestorTitles.pop() ?? '';
-
-    return {
-      ancestorTitles,
-      duration: null,
-      failing: false,
-      failureDetails: [],
-      failureMessages: [],
-      fullName: [...ancestorTitles, title].join(' '),
-      invocations: 0,
-      location: null,
-      numPassingAsserts: 0,
-      retryReasons: [],
-      startAt: null,
-      status: 'pending' as Status,
-      title,
-    };
-  });
+  walk(rootDescribeBlock, []);
 
   await dispatch({name: 'teardown'});
 
-  const emptyTestResult = createEmptyTestResult();
-
   return {
-    ...emptyTestResult,
+    ...createEmptyTestResult(),
     displayName: config.displayName,
     numPendingTests: assertionResults.length,
     testFilePath: testPath,

packages/jest-circus/src/utils.ts

@@ -323,9 +323,7 @@ export const makeRunResult = (
   unhandledErrors: unhandledErrors.map(_getError).map(getErrorStack),
 });
 
-export const getTestNamesPath = (
-  test: Circus.TestEntry,
-): Circus.TestNamesPath => {
+const getTestNamesPath = (test: Circus.TestEntry): Circus.TestNamesPath => {
   const titles = [];
   let parent: Circus.TestEntry | Circus.DescribeBlock | undefined = test;
   do {