chore: use String.replaceAll if possible (#14823)

Author: SimenB

.eslintrc.cjs

@@ -697,9 +697,6 @@ module.exports = {
     'unicorn/filename-case': 'off',
     'unicorn/prefer-reflect-apply': 'off',
 
-    // TODO: turn on at some point
-    'unicorn/prefer-string-replace-all': 'off',
-
     // enabling this is blocked by https://github.com/microsoft/rushstack/issues/2780
     'unicorn/prefer-export-from': 'off',
     // enabling this is blocked by https://github.com/jestjs/jest/pull/14297

e2e/Utils.ts

@@ -93,7 +93,7 @@ export const linkJestPackage = (packageName: string, cwd: string) => {
 export const makeTemplate =
   (str: string): ((values?: Array<string>) => string) =>
   (values = []) =>
-    str.replace(/\$(\d+)/g, (_match, number) => {
+    str.replaceAll(/\$(\d+)/g, (_match, number) => {
       if (!Array.isArray(values)) {
         throw new TypeError('Array of values must be passed to the template.');
       }
@@ -191,12 +191,12 @@ export const copyDir = (src: string, dest: string) => {
 };
 
 export const replaceSeed = (str: string) =>
-  str.replace(/Seed: {8}(-?\d+)/g, 'Seed:       <<REPLACED>>');
+  str.replaceAll(/Seed: {8}(-?\d+)/g, 'Seed:       <<REPLACED>>');
 
 export const replaceTime = (str: string) =>
   str
-    .replace(/\d*\.?\d+ m?s\b/g, '<<REPLACED>>')
-    .replace(/, estimated <<REPLACED>>/g, '');
+    .replaceAll(/\d*\.?\d+ m?s\b/g, '<<REPLACED>>')
+    .replaceAll(', estimated <<REPLACED>>', '');
 
 // Since Jest does not guarantee the order of tests we'll sort the output.
 export const sortLines = (output: string) =>
@@ -235,7 +235,7 @@ export const createEmptyPackage = (
 
 export const extractSummary = (stdout: string) => {
   const match = stdout
-    .replace(/(?:\\[nr])+/g, '\n')
+    .replaceAll(/(?:\\[nr])+/g, '\n')
     .match(
       /(Seed:.*\n)?Test Suites:.*\nTests.*\nSnapshots.*\nTime.*(\nRan all test suites)*.*\n*$/gm,
     );
@@ -252,7 +252,7 @@ export const extractSummary = (stdout: string) => {
   const rest = stdout
     .replace(match[0], '')
     // remove all timestamps
-    .replace(/\s*\(\d*\.?\d+ m?s\b\)$/gm, '');
+    .replaceAll(/\s*\(\d*\.?\d+ m?s\b\)$/gm, '');
 
   return {
     rest: rest.trim(),

e2e/__tests__/beforeAllFiltered.ts

@@ -12,7 +12,7 @@ describe('Correct BeforeAll run', () => {
     let {stdout} = runJest('before-all-filtered');
 
     // for some reason Circus does not have the `Object` part
-    stdout = stdout.replace(/at Object.log \(/g, 'at log (');
+    stdout = stdout.replaceAll(/at Object.log \(/g, 'at log (');
 
     expect(stdout).toMatchSnapshot();
   });

e2e/__tests__/beforeEachQueue.ts

@@ -13,6 +13,6 @@ skipSuiteOnJestCircus(); // Circus does not support funky async definitions
 describe('Correct beforeEach order', () => {
   it('ensures the correct order for beforeEach', () => {
     const result = runJest('before-each-queue');
-    expect(result.stdout.replace(/\\/g, '/')).toMatchSnapshot();
+    expect(result.stdout.replaceAll('\\', '/')).toMatchSnapshot();
   });
 });

e2e/__tests__/customEsmTestSequencers.test.ts

@@ -17,7 +17,7 @@ test('run prioritySequence', () => {
 
   expect(result.exitCode).toBe(0);
   const sequence = extractSummary(result.stderr)
-    .rest.replace(/PASS /g, '')
+    .rest.replaceAll('PASS ', '')
     .split('\n');
   expect(sequence).toEqual([
     './a.test.js',

e2e/__tests__/customTestSequencers.test.ts

@@ -24,7 +24,7 @@ test('run prioritySequence first sync', () => {
   );
   expect(result.exitCode).toBe(0);
   const sequence = extractSummary(result.stderr)
-    .rest.replace(/PASS /g, '')
+    .rest.replaceAll('PASS ', '')
     .split('\n');
   expect(sequence).toEqual([
     './a.test.js',
@@ -49,7 +49,7 @@ test('run prioritySequence first async', () => {
   );
   expect(result.exitCode).toBe(0);
   const sequence = extractSummary(result.stderr)
-    .rest.replace(/PASS /g, '')
+    .rest.replaceAll('PASS ', '')
     .split('\n');
   expect(sequence).toEqual([
     './a.test.js',
@@ -75,7 +75,7 @@ test('run failed tests async', () => {
   );
   expect(result.exitCode).toBe(0);
   const sequence = extractSummary(result.stderr)
-    .rest.replace(/PASS /g, '')
+    .rest.replaceAll('PASS ', '')
     .split('\n');
   expect(sequence).toEqual(['./c.test.js', './d.test.js']);
 });
@@ -95,7 +95,7 @@ test('run tests based on even seed', () => {
   );
   expect(result.exitCode).toBe(0);
   const sequence = extractSummary(result.stderr)
-    .rest.replace(/PASS /g, '')
+    .rest.replaceAll('PASS ', '')
     .split('\n');
   expect(sequence).toEqual([
     './a.test.js',
@@ -121,7 +121,7 @@ test('run tests based on odd seed', () => {
   );
   expect(result.exitCode).toBe(0);
   const sequence = extractSummary(result.stderr)
-    .rest.replace(/PASS /g, '')
+    .rest.replaceAll('PASS ', '')
     .split('\n');
   expect(sequence).toEqual([
     './e.test.js',

e2e/__tests__/declarationErrors.test.ts

@@ -10,7 +10,7 @@ import runJest from '../runJest';
 
 const extractMessage = (str: string) =>
   extractSummary(str)
-    .rest.replace(
+    .rest.replaceAll(
       // circus-jasmine normalization
       /.+addSpecsToSuite (.+:\d+:\d+).+\n/g,
       '',

e2e/__tests__/dependencyClash.test.ts

@@ -14,7 +14,7 @@ import runJest from '../runJest';
 const tempDir = path.resolve(tmpdir(), 'clashing-dependencies-test');
 const hasteImplModulePath = path
   .resolve('./packages/jest-haste-map/src/__tests__/haste_impl.js')
-  .replace(/\\/g, '\\\\');
+  .replaceAll('\\', '\\\\');
 
 beforeEach(() => {
   cleanup(tempDir);

e2e/__tests__/failureDetailsProperty.test.ts

@@ -9,7 +9,7 @@ import {isJestJasmineRun} from '@jest/test-utils';
 import runJest from '../runJest';
 
 const removeStackTraces = (stdout: string) =>
-  stdout.replace(
+  stdout.replaceAll(
     /at (new Promise \(<anonymous>\)|.+:\d+:\d+\)?)/g,
     'at <stacktrace>',
   );

e2e/__tests__/failures.test.ts

@@ -11,13 +11,13 @@ import runJest from '../runJest';
 
 const dir = path.resolve(__dirname, '../failures');
 
-const normalizeDots = (text: string) => text.replace(/\.+$/gm, '.');
+const normalizeDots = (text: string) => text.replaceAll(/\.+$/gm, '.');
 
 function cleanStderr(stderr: string) {
   const {rest} = extractSummary(stderr);
   return rest
-    .replace(/.*(jest-jasmine2|jest-circus).*\n/g, '')
-    .replace(new RegExp('Failed: Object {', 'g'), 'thrown: Object {');
+    .replaceAll(/.*(jest-jasmine2|jest-circus).*\n/g, '')
+    .replaceAll(new RegExp('Failed: Object {', 'g'), 'thrown: Object {');
 }
 
 beforeAll(() => {
@@ -101,7 +101,7 @@ test('works with error with cause thrown outside tests', () => {
   const summary = normalizeDots(cleanStderr(stderr));
 
   const sanitizedSummary = summary
-    .replace(/ Suite\.f /g, ' f ') // added by jasmine runner
+    .replaceAll(' Suite.f ', ' f ') // added by jasmine runner
     .split('\n')
     .map(line => line.trim()) // jasmine runner does not come with the same indentation
     .join('\n');