fix: remove needless check for equalCompare after Object.is (#15085)

Author: Connormiha

packages/expect-utils/src/__tests__/utils.test.ts

@@ -703,3 +703,26 @@ describe('arrayBufferEquality', () => {
     expect(equals(a, b)).toBeFalsy();
   });
 });
+
+describe('jasmineUtils primitives comparison', () => {
+  const falseCases: Array<[any, any]> = [
+    [null, undefined],
+    [null, 0],
+    [false, 0],
+    [false, ''],
+  ];
+
+  for (const [a, b] of falseCases) {
+    test(`${JSON.stringify(a)} and ${JSON.stringify(b)} returns false`, () => {
+      expect(equals(a, b)).toBe(false);
+    });
+  }
+
+  const trueCases: Array<any> = [null, 0, false, '', undefined];
+
+  for (const value of trueCases) {
+    test(`${JSON.stringify(value)} returns true`, () => {
+      expect(equals(value, value)).toBe(true);
+    });
+  }
+});

packages/expect-utils/src/jasmineUtils.ts

@@ -92,7 +92,7 @@ function eq(
   }
   // A strict comparison is necessary because `null == undefined`.
   if (a === null || b === null) {
-    return a === b;
+    return false;
   }
   const className = Object.prototype.toString.call(a);
   if (className != Object.prototype.toString.call(b)) {
@@ -107,7 +107,7 @@ function eq(
         return false;
       } else if (typeof a !== 'object' && typeof b !== 'object') {
         // both are proper primitives
-        return Object.is(a, b);
+        return false;
       } else {
         // both are `new Primitive()`s
         return Object.is(a.valueOf(), b.valueOf());