Skip to content

Commit ef1d482

Browse files
eyalrotheyalroth
committed
#8708 Adjust globalTeardownPerWorker e2e test for multiple workers
1 parent 252a476 commit ef1d482

File tree

6 files changed

+82
-24
lines changed

6 files changed

+82
-24
lines changed

‎e2e/__tests__/globalTeardownPerWorker.test.ts

Lines changed: 71 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -45,47 +45,90 @@ test('globalTeardownPerWorker is triggered once after all test suites per worker
4545
createDirectory(DIR);
4646
const teardownPath = path.resolve(e2eDir, 'teardown.js');
4747
const result = runWithJson('global-teardown-per-worker', [
48-
`--globalTeardown=${teardownPath}`,
48+
'--maxWorkers=2',
49+
'--workerIdleMemoryLimit=100MB',
50+
`--globalTeardownPerWorker=${teardownPath}`,
4951
'--testPathPatterns=__tests__',
5052
]);
5153

5254
expect(result.exitCode).toBe(0);
5355
const files = fs.readdirSync(DIR);
54-
expect(files).toHaveLength(1);
55-
const teardown = fs.readFileSync(path.join(DIR, files[0]), 'utf8');
56-
expect(teardown).toBe('teardown');
56+
expect(files).toHaveLength(2);
57+
const content = files.map(file => {
58+
const data = fs.readFileSync(path.join(DIR, file), 'utf8');
59+
return data.split('\n');
60+
});
61+
for (const [firstLine] of content) {
62+
expect(firstLine).toBe('teardown-per-worker');
63+
}
64+
const secondLines = content.map(([, secondLine]) => secondLine);
65+
secondLines.sort();
66+
expect(secondLines).toEqual(['1', '2']);
67+
});
68+
69+
test('globalTeardownPerWorker with worker threads', () => {
70+
createDirectory(DIR);
71+
const teardownPath = path.resolve(e2eDir, 'teardown.js');
72+
const result = runWithJson('global-teardown-per-worker', [
73+
'--maxWorkers=2',
74+
'--workerIdleMemoryLimit=100MB',
75+
`--globalTeardownPerWorker=${teardownPath}`,
76+
'--testPathPatterns=__tests__',
77+
'--workerThreads',
78+
]);
79+
80+
expect(result.exitCode).toBe(0);
81+
const files = fs.readdirSync(DIR);
82+
expect(files).toHaveLength(2);
83+
const content = files.map(file => {
84+
const data = fs.readFileSync(path.join(DIR, file), 'utf8');
85+
return data.split('\n');
86+
});
87+
for (const [firstLine] of content) {
88+
expect(firstLine).toBe('teardown-per-worker');
89+
}
90+
const secondLines = content.map(([, secondLine]) => secondLine);
91+
secondLines.sort();
92+
expect(secondLines).toEqual(['1', '2']);
5793
});
5894

5995
test('jest throws an error when globalTeardownPerWorker does not export a function', () => {
6096
const teardownPath = path.resolve(e2eDir, 'invalidTeardown.js');
6197
const {exitCode, stderr} = runJest(e2eDir, [
62-
`--globalTeardown=${teardownPath}`,
98+
'--maxWorkers=2',
99+
'--workerIdleMemoryLimit=100MB',
100+
`--globalTeardownPerWorker=${teardownPath}`,
63101
'--testPathPatterns=__tests__',
64102
]);
65103

66104
expect(exitCode).toBe(1);
67-
expect(stderr).toContain('Jest: Got error running globalTeardown');
105+
expect(stderr).toContain('Jest: Got error running globalTeardownPerWorker');
68106
expect(stderr).toContain(
69-
`globalTeardown file must export a function at ${teardownPath}`,
107+
`globalTeardownPerWorker file must export a function at ${teardownPath}`,
70108
);
71109
});
72110

73111
test('globalTeardownPerWorker function gets global config object and project config as parameters', () => {
74112
const teardownPath = path.resolve(e2eDir, 'teardownWithConfig.js');
75113

76114
const result = runJest(e2eDir, [
77-
`--globalTeardown=${teardownPath}`,
115+
'--maxWorkers=2',
116+
'--workerIdleMemoryLimit=100MB',
117+
`--globalTeardownPerWorker=${teardownPath}`,
78118
'--testPathPatterns=pass',
79119
'--cache=true',
80120
]);
81121

82-
expect(result.stdout).toBe("[ 'pass' ]\ntrue");
122+
const expected = ["[ 'pass' ]", 'true', "[ 'pass' ]", 'true'].join('\n');
123+
expect(result.stdout).toBe(expected);
83124
});
84125

85126
test('should call globalTeardownPerWorker function of multiple projects', () => {
86127
const configPath = path.resolve(e2eDir, 'projects.jest.config.js');
87128

88129
const result = runWithJson('global-teardown-per-worker', [
130+
'--maxWorkers=2',
131+
'--workerIdleMemoryLimit=100MB',
89132
`--config=${configPath}`,
90133
]);
91134

@@ -100,6 +143,8 @@ test('should not call a globalTeardownPerWorker of a project if there are no tes
100143
const configPath = path.resolve(e2eDir, 'projects.jest.config.js');
101144

102145
const result = runWithJson('global-teardown-per-worker', [
146+
'--maxWorkers=2',
147+
'--workerIdleMemoryLimit=100MB',
103148
`--config=${configPath}`,
104149
'--testPathPatterns=teardown1',
105150
]);
@@ -115,12 +160,15 @@ test('globalTeardownPerWorker works with default export', () => {
115160
const teardownPath = path.resolve(e2eDir, 'teardownWithDefaultExport.js');
116161

117162
const result = runJest(e2eDir, [
118-
`--globalTeardown=${teardownPath}`,
163+
'--maxWorkers=2',
164+
'--workerIdleMemoryLimit=100MB',
165+
`--globalTeardownPerWorker=${teardownPath}`,
119166
'--testPathPatterns=pass',
120167
'--cache=true',
121168
]);
122169

123-
expect(result.stdout).toBe("[ 'pass' ]\ntrue");
170+
const expected = ["[ 'pass' ]", 'true', "[ 'pass' ]", 'true'].join('\n');
171+
expect(result.stdout).toBe(expected);
124172
});
125173

126174
test('globalTeardownPerWorker throws with named export', () => {
@@ -130,21 +178,27 @@ test('globalTeardownPerWorker throws with named export', () => {
130178
);
131179

132180
const {exitCode, stderr} = runJest(e2eDir, [
133-
`--globalTeardown=${teardownPath}`,
181+
'--maxWorkers=2',
182+
'--workerIdleMemoryLimit=100MB',
183+
`--globalTeardownPerWorker=${teardownPath}`,
134184
'--testPathPatterns=__tests__',
135185
]);
136186

137187
expect(exitCode).toBe(1);
138-
expect(stderr).toContain('Jest: Got error running globalTeardown');
188+
expect(stderr).toContain('Jest: Got error running globalTeardownPerWorker');
139189
expect(stderr).toContain(
140-
`globalTeardown file must export a function at ${teardownPath}`,
190+
`globalTeardownPerWorker file must export a function at ${teardownPath}`,
141191
);
142192
});
143193

144194
test('globalTeardownPerWorker works with ESM modules', () => {
145-
const {exitCode} = runJest('global-teardown-per-worker-esm', ['--no-cache'], {
146-
nodeOptions: '--experimental-vm-modules --no-warnings',
147-
});
195+
const {exitCode} = runJest(
196+
'global-teardown-per-worker-esm',
197+
['--maxWorkers=2', '--workerIdleMemoryLimit=100MB', '--no-cache'],
198+
{
199+
nodeOptions: '--experimental-vm-modules --no-warnings',
200+
},
201+
);
148202

149203
expect(exitCode).toBe(0);
150204
});

‎e2e/global-teardown-per-worker-esm/teardown.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,11 @@ import {createDirectory} from 'jest-util';
1313
const DIR = path.join(os.tmpdir(), 'jest-global-teardown-per-worker-esm');
1414

1515
export default function () {
16-
return new Promise(resolve => {
16+
return new Promise((resolve, reject) => {
1717
createDirectory(DIR);
1818
const fileId = crypto.randomBytes(20).toString('hex');
19-
fs.writeFileSync(path.join(DIR, fileId), 'teardown');
19+
const data = ['teardown-per-worker', process.env.JEST_WORKER_ID].join('\n');
20+
fs.writeFileSync(path.join(DIR, fileId), data);
2021
resolve();
2122
});
2223
}

‎e2e/global-teardown-per-worker/project-1/teardown.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ module.exports = function () {
1616
return new Promise((resolve, reject) => {
1717
createDirectory(DIR);
1818
const fileId = crypto.randomBytes(20).toString('hex');
19-
fs.writeFileSync(path.join(DIR, fileId), 'teardown');
19+
const data = ['teardown-per-worker', process.env.JEST_WORKER_ID].join('\n');
20+
fs.writeFileSync(path.join(DIR, fileId), data);
2021
resolve();
2122
});
2223
};

‎e2e/global-teardown-per-worker/project-2/teardown.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ module.exports = function () {
1616
return new Promise((resolve, reject) => {
1717
createDirectory(DIR);
1818
const fileId = crypto.randomBytes(20).toString('hex');
19-
fs.writeFileSync(path.join(DIR, fileId), 'teardown');
19+
const data = ['teardown-per-worker', process.env.JEST_WORKER_ID].join('\n');
20+
fs.writeFileSync(path.join(DIR, fileId), data);
2021
resolve();
2122
});
2223
};

‎e2e/global-teardown-per-worker/projects.jest.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ module.exports = {
1212
projects: [
1313
{
1414
displayName: 'project-1',
15-
globalTeardown: '<rootDir>/teardown.js',
15+
globalTeardownPerWorker: '<rootDir>/teardown.js',
1616
rootDir: path.resolve(__dirname, './project-1'),
1717
testMatch: ['<rootDir>/**/*.test.js'],
1818
transformIgnorePatterns: ['/node_modules/', '/packages/'],
1919
},
2020
{
2121
displayName: 'project-2',
22-
globalTeardown: '<rootDir>/teardown.js',
22+
globalTeardownPerWorker: '<rootDir>/teardown.js',
2323
rootDir: path.resolve(__dirname, './project-2'),
2424
testMatch: ['<rootDir>/**/*.test.js'],
2525
transformIgnorePatterns: ['/node_modules/', '/packages/'],

‎e2e/global-teardown-per-worker/teardown.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ module.exports = function () {
1616
return new Promise((resolve, reject) => {
1717
createDirectory(DIR);
1818
const fileId = crypto.randomBytes(20).toString('hex');
19-
fs.writeFileSync(path.join(DIR, fileId), 'teardown');
19+
const data = ['teardown-per-worker', process.env.JEST_WORKER_ID].join('\n');
20+
fs.writeFileSync(path.join(DIR, fileId), data);
2021
resolve();
2122
});
2223
};

0 commit comments

Comments
 (0)