Skip to content

Commit fd3d6cf

Browse files
authored
fix: optimize replaceAll with regexp (#15719)
1 parent a3d1e2e commit fd3d6cf

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

packages/jest-each/src/table/array.ts

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const PRETTY_PLACEHOLDER = '%p';
1717
const INDEX_PLACEHOLDER = '%#';
1818
const NUMBER_PLACEHOLDER = '%$';
1919
const PLACEHOLDER_PREFIX = '%';
20-
const ESCAPED_PLACEHOLDER_PREFIX = /%%/g;
20+
const ESCAPED_PLACEHOLDER_PREFIX = '%%';
2121
const JEST_EACH_PLACEHOLDER_ESCAPE = '@@__JEST_EACH_PLACEHOLDER_ESCAPE__@@';
2222

2323
export default function array(
@@ -77,17 +77,11 @@ const formatTitle = (
7777
rowIndex,
7878
),
7979
)
80-
.replaceAll(
81-
new RegExp(JEST_EACH_PLACEHOLDER_ESCAPE, 'g'),
82-
PLACEHOLDER_PREFIX,
83-
);
80+
.replaceAll(JEST_EACH_PLACEHOLDER_ESCAPE, PLACEHOLDER_PREFIX);
8481

8582
const normalisePlaceholderValue = (value: unknown) =>
8683
typeof value === 'string'
87-
? value.replaceAll(
88-
new RegExp(PLACEHOLDER_PREFIX, 'g'),
89-
JEST_EACH_PLACEHOLDER_ESCAPE,
90-
)
84+
? value.replaceAll(PLACEHOLDER_PREFIX, JEST_EACH_PLACEHOLDER_ESCAPE)
9185
: value;
9286

9387
const getMatchingPlaceholders = (title: string) =>

0 commit comments

Comments
 (0)