Skip to content

Commit 05c8261

Browse files
committed
NO-ISSUE: chore(ci): fix expected image names in params.env check
With recent 2025a image version introduced, we fixed some image build names annotations and these need to be reflected in this check now. For older images, the fixes weren't applied as they weren't rebuild, so no fix is done for these N-1 image version checks.
1 parent 35e9498 commit 05c8261

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

ci/check-params-env.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ function check_image_variable_matches_name_and_commitref_and_size() {
112112
expected_img_size=503
113113
;;
114114
odh-minimal-gpu-notebook-image-n)
115-
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.11"
115+
expected_name="odh-notebook-jupyter-cuda-minimal-ubi9-python-3.11"
116116
expected_commitref="main"
117117
expected_build_name="cuda-jupyter-minimal-ubi9-python-3.11-amd64"
118118
expected_img_size=5157
@@ -124,9 +124,9 @@ function check_image_variable_matches_name_and_commitref_and_size() {
124124
expected_img_size=5157
125125
;;
126126
odh-pytorch-gpu-notebook-image-n)
127-
expected_name="odh-notebook-jupyter-pytorch-ubi9-python-3.11"
127+
expected_name="odh-notebook-jupyter-cuda-pytorch-ubi9-python-3.11"
128128
expected_commitref="main"
129-
expected_build_name="jupyter-pytorch-ubi9-python-3.11-amd64"
129+
expected_build_name="cuda-jupyter-pytorch-ubi9-python-3.11-amd64"
130130
expected_img_size=8571
131131
;;
132132
odh-pytorch-gpu-notebook-image-n-1)
@@ -199,7 +199,7 @@ function check_image_variable_matches_name_and_commitref_and_size() {
199199
# This is because the very same RStudio Dockerfile is used but different base images in both cases
200200
# We should consider what to do with this - in ideal case, we should have different labels for these cases.
201201
odh-rstudio-gpu-notebook-image-n)
202-
expected_name="odh-notebook-rstudio-server-c9s-python-3.11"
202+
expected_name="odh-notebook-rstudio-server-cuda-c9s-python-3.11"
203203
expected_commitref="main"
204204
expected_build_name="cuda-rstudio-c9s-python-3.11-amd64"
205205
expected_img_size=7184
@@ -211,7 +211,7 @@ function check_image_variable_matches_name_and_commitref_and_size() {
211211
expected_img_size=7184
212212
;;
213213
odh-rocm-minimal-notebook-image-n)
214-
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.11"
214+
expected_name="odh-notebook-jupyter-rocm-minimal-ubi9-python-3.11"
215215
expected_commitref="main"
216216
expected_build_name="rocm-jupyter-minimal-ubi9-python-3.11-amd64"
217217
expected_img_size=4830

0 commit comments

Comments
 (0)