Skip to content

Commit 29d19c7

Browse files
RHOAIENG-17368: chore(release): update the package versions script with 2.16.1 support changes (opendatahub-io#503)
Also remove outdated todos which are already done. Co-authored-by: Jiri Daněk <[email protected]>
1 parent d79b8e8 commit 29d19c7

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

ci/package_versions.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,6 @@
1717
"""Generates the workbench software listings for https://access.redhat.com/articles/rhoai-supported-configs
1818
using the Markdown variant described at https://access.redhat.com/articles/7056942"""
1919

20-
"""
21-
TODO:
22-
* separate reading data and printing output
23-
so that output can be properly sorted (by opendatahub.io/notebook-image-order probably)
24-
* don't repeat image name when printing multiple tags for it
25-
* run this in red-hat-data-services repo so we also have (or not have) Habana image
26-
* diff it with what's in the knowledge base now, to check if outputs match
27-
"""
28-
2920
ROOT_DIR = pathlib.Path(__file__).parent.parent
3021

3122

@@ -130,7 +121,8 @@ def main():
130121
sw_version = sw_version.lstrip("v")
131122
software.append(f"{sw_name}: {sw_version}")
132123

133-
maybe_techpreview = "" if name not in ('code-server',) else " (Technology Preview)"
124+
# in 2.16.1 we only have RStudio as tech preview, and that is not a prebuilt image we ship
125+
maybe_techpreview = "" if name not in () else " (Technology Preview)"
134126
maybe_recommended = "" if not recommended or len(imagestream.tags) == 1 else ' (Recommended)'
135127

136128
tabular_data.append((
@@ -159,6 +151,7 @@ def main():
159151
print(f'{row[0]} | {row[1]} | {row[2]}')
160152
print('```')
161153

154+
162155
class TestManifest(unittest.TestCase):
163156
_data = yaml.safe_load(io.StringIO(package_versions_selftestdata.imagestream))
164157
manifest = Manifest(_data)

0 commit comments

Comments
 (0)