Skip to content

Commit 8ac7467

Browse files
authored
Merge pull request opendatahub-io#529 from atheo89/fix-imagestreams
Update imagesteams on downstream for the new release
2 parents 4908cdd + 0aca2ce commit 8ac7467

19 files changed

+473
-261
lines changed

ci/check-params-env.sh

Lines changed: 86 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ PARAMS_ENV_PATH="manifests/base/params.env"
2525

2626
# This value needs to be updated everytime we deliberately change number of the
2727
# images we want to have in the `params.env` file.
28-
EXPECTED_NUM_RECORDS=35
28+
EXPECTED_NUM_RECORDS=45
2929

3030
# Size change tresholds:
3131
# Max percentual change
@@ -101,209 +101,269 @@ function check_image_variable_matches_name_and_commitref_and_size() {
101101
case "${image_variable}" in
102102
odh-minimal-notebook-image-n)
103103
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.11"
104-
expected_commitref="release-2024b"
104+
expected_commitref="main"
105105
expected_build_name="jupyter-minimal-ubi9-python-3.11-amd64"
106106
expected_img_size=528
107107
;;
108108
odh-minimal-notebook-image-n-1)
109+
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.11"
110+
expected_commitref="release-2024b"
111+
expected_build_name="jupyter-minimal-ubi9-python-3.11-amd64"
112+
expected_img_size=528
113+
;;
114+
odh-minimal-notebook-image-n-2)
109115
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.9"
110116
expected_commitref="release-2024a"
111117
expected_build_name="jupyter-minimal-ubi9-python-3.9-amd64"
112118
expected_img_size=489
113119
;;
114-
odh-minimal-notebook-image-n-2)
120+
odh-minimal-notebook-image-n-3)
115121
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.9"
116122
expected_commitref="release-2023b"
117123
expected_build_name="jupyter-minimal-ubi9-python-3.9-amd64"
118124
expected_img_size=486
119125
;;
120-
odh-minimal-notebook-image-n-3)
126+
odh-minimal-notebook-image-n-4)
121127
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.9"
122128
expected_commitref="release-2023a"
123129
expected_build_name="jupyter-minimal-ubi9-python-3.9-amd64"
124130
expected_img_size=475
125131
;;
126-
odh-minimal-notebook-image-n-4)
132+
odh-minimal-notebook-image-n-5)
127133
expected_name="odh-notebook-jupyter-minimal-ubi8-python-3.8"
128134
expected_commitref="release-1.2"
129135
expected_build_name="jupyter-minimal-ubi8-python-3.8-amd64"
130136
expected_img_size=479
131137
;;
132138
odh-minimal-gpu-notebook-image-n)
133139
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.11"
134-
expected_commitref="release-2024b"
140+
expected_commitref="main"
135141
expected_build_name="cuda-jupyter-minimal-ubi9-python-3.11-amd64"
136142
expected_img_size=5157
137143
;;
138144
odh-minimal-gpu-notebook-image-n-1)
145+
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.11"
146+
expected_commitref="release-2024b"
147+
expected_build_name="cuda-jupyter-minimal-ubi9-python-3.11-amd64"
148+
expected_img_size=5157
149+
;;
150+
odh-minimal-gpu-notebook-image-n-2)
139151
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.9"
140152
expected_commitref="release-2024a"
141153
expected_build_name="cuda-jupyter-minimal-ubi9-python-3.9-amd64"
142154
expected_img_size=6026
143155
;;
144-
odh-minimal-gpu-notebook-image-n-2)
156+
odh-minimal-gpu-notebook-image-n-3)
145157
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.9"
146158
expected_commitref="release-2023b"
147159
expected_build_name="cuda-jupyter-minimal-ubi9-python-3.9-amd64"
148160
expected_img_size=5326
149161
;;
150-
odh-minimal-gpu-notebook-image-n-3)
162+
odh-minimal-gpu-notebook-image-n-4)
151163
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.9"
152164
expected_commitref="release-2023a"
153165
expected_build_name="cuda-jupyter-minimal-ubi9-python-3.9-amd64"
154166
expected_img_size=5038
155167
;;
156-
odh-minimal-gpu-notebook-image-n-4)
168+
odh-minimal-gpu-notebook-image-n-5)
157169
expected_name="odh-notebook-jupyter-minimal-ubi8-python-3.8"
158170
expected_commitref="release-1.2"
159171
expected_build_name="cuda-jupyter-minimal-ubi8-python-3.8-amd64"
160172
expected_img_size=5333
161173
;;
162174
odh-pytorch-gpu-notebook-image-n)
163175
expected_name="odh-notebook-jupyter-pytorch-ubi9-python-3.11"
164-
expected_commitref="release-2024b"
176+
expected_commitref="main"
165177
expected_build_name="jupyter-pytorch-ubi9-python-3.11-amd64"
166178
expected_img_size=8571
167179
;;
168180
odh-pytorch-gpu-notebook-image-n-1)
181+
expected_name="odh-notebook-jupyter-pytorch-ubi9-python-3.11"
182+
expected_commitref="release-2024b"
183+
expected_build_name="jupyter-pytorch-ubi9-python-3.11-amd64"
184+
expected_img_size=8571
185+
;;
186+
odh-pytorch-gpu-notebook-image-n-2)
169187
expected_name="odh-notebook-jupyter-pytorch-ubi9-python-3.9"
170188
expected_commitref="release-2024a"
171189
expected_build_name="jupyter-pytorch-ubi9-python-3.9-amd64"
172190
expected_img_size=9354
173191
;;
174-
odh-pytorch-gpu-notebook-image-n-2)
192+
odh-pytorch-gpu-notebook-image-n-3)
175193
expected_name="odh-notebook-jupyter-pytorch-ubi9-python-3.9"
176194
expected_commitref="release-2023b"
177195
expected_build_name="jupyter-pytorch-ubi9-python-3.9-amd64"
178196
expected_img_size=8711
179197
;;
180-
odh-pytorch-gpu-notebook-image-n-3)
198+
odh-pytorch-gpu-notebook-image-n-4)
181199
expected_name="odh-notebook-jupyter-pytorch-ubi9-python-3.9"
182200
expected_commitref="release-2023a"
183201
expected_build_name="jupyter-pytorch-ubi9-python-3.9-amd64"
184202
expected_img_size=7130
185203
;;
186-
odh-pytorch-gpu-notebook-image-n-4)
204+
odh-pytorch-gpu-notebook-image-n-5)
187205
expected_name="odh-notebook-cuda-jupyter-pytorch-ubi8-python-3.8"
188206
expected_commitref="release-1.2"
189207
expected_build_name="jupyter-pytorch-ubi8-python-3.8-amd64"
190208
expected_img_size=6592
191209
;;
192210
odh-generic-data-science-notebook-image-n)
193211
expected_name="odh-notebook-jupyter-datascience-ubi9-python-3.11"
194-
expected_commitref="release-2024b"
212+
expected_commitref="main"
195213
expected_build_name="jupyter-datascience-ubi9-python-3.11-amd64"
196214
expected_img_size=961
197215
;;
198216
odh-generic-data-science-notebook-image-n-1)
217+
expected_name="odh-notebook-jupyter-datascience-ubi9-python-3.11"
218+
expected_commitref="release-2024b"
219+
expected_build_name="jupyter-datascience-ubi9-python-3.11-amd64"
220+
expected_img_size=961
221+
;;
222+
odh-generic-data-science-notebook-image-n-2)
199223
expected_name="odh-notebook-jupyter-datascience-ubi9-python-3.9"
200224
expected_commitref="release-2024a"
201225
expected_build_name="jupyter-datascience-ubi9-python-3.9-amd64"
202226
expected_img_size=890
203227
;;
204-
odh-generic-data-science-notebook-image-n-2)
228+
odh-generic-data-science-notebook-image-n-3)
205229
expected_name="odh-notebook-jupyter-datascience-ubi9-python-3.9"
206230
expected_commitref="release-2023b"
207231
expected_build_name="jupyter-datascience-ubi9-python-3.9-amd64"
208232
expected_img_size=883
209233
;;
210-
odh-generic-data-science-notebook-image-n-3)
234+
odh-generic-data-science-notebook-image-n-4)
211235
expected_name="odh-notebook-jupyter-datascience-ubi9-python-3.9"
212236
expected_commitref="release-2023a"
213237
expected_build_name="jupyter-datascience-ubi9-python-3.9-amd64"
214238
expected_img_size=685
215239
;;
216-
odh-generic-data-science-notebook-image-n-4)
240+
odh-generic-data-science-notebook-image-n-5)
217241
expected_name="odh-notebook-jupyter-datascience-ubi8-python-3.8"
218242
expected_commitref="release-1.2"
219243
expected_build_name="jupyter-datascience-ubi8-python-3.8-amd64"
220244
expected_img_size=865
221245
;;
222246
odh-tensorflow-gpu-notebook-image-n)
223247
expected_name="odh-notebook-cuda-jupyter-tensorflow-ubi9-python-3.11"
224-
expected_commitref="release-2024b"
248+
expected_commitref="main"
225249
expected_build_name="cuda-jupyter-tensorflow-ubi9-python-3.11-amd64"
226250
expected_img_size=8211
227251
;;
228252
odh-tensorflow-gpu-notebook-image-n-1)
253+
expected_name="odh-notebook-cuda-jupyter-tensorflow-ubi9-python-3.11"
254+
expected_commitref="release-2024b"
255+
expected_build_name="cuda-jupyter-tensorflow-ubi9-python-3.11-amd64"
256+
expected_img_size=8211
257+
;;
258+
odh-tensorflow-gpu-notebook-image-n-2)
229259
expected_name="odh-notebook-cuda-jupyter-tensorflow-ubi9-python-3.9"
230260
expected_commitref="release-2024a"
231261
expected_build_name="cuda-jupyter-tensorflow-ubi9-python-3.9-amd64"
232262
expected_img_size=6984
233263
;;
234-
odh-tensorflow-gpu-notebook-image-n-2)
264+
odh-tensorflow-gpu-notebook-image-n-3)
235265
expected_name="odh-notebook-cuda-jupyter-tensorflow-ubi9-python-3.9"
236266
expected_commitref="release-2023b"
237267
expected_build_name="cuda-jupyter-tensorflow-ubi9-python-3.9-amd64"
238268
expected_img_size=6301
239269
;;
240-
odh-tensorflow-gpu-notebook-image-n-3)
270+
odh-tensorflow-gpu-notebook-image-n-4)
241271
expected_name="odh-notebook-cuda-jupyter-tensorflow-ubi9-python-3.9"
242272
expected_commitref="release-2023a"
243273
expected_build_name="cuda-jupyter-tensorflow-ubi9-python-3.9-amd64"
244274
expected_img_size=5927
245275
;;
246-
odh-tensorflow-gpu-notebook-image-n-4)
276+
odh-tensorflow-gpu-notebook-image-n-5)
247277
expected_name="odh-notebook-cuda-jupyter-tensorflow-ubi8-python-3.8"
248278
expected_commitref="release-1.2"
249279
expected_build_name="cuda-jupyter-tensorflow-ubi8-python-3.8-amd64"
250280
expected_img_size=6309
251281
;;
252282
odh-trustyai-notebook-image-n)
253283
expected_name="odh-notebook-jupyter-trustyai-ubi9-python-3.11"
254-
expected_commitref="release-2024b"
284+
expected_commitref="main"
255285
expected_build_name="jupyter-trustyai-ubi9-python-3.11-amd64"
256286
expected_img_size=4197
257287
;;
258288
odh-trustyai-notebook-image-n-1)
289+
expected_name="odh-notebook-jupyter-trustyai-ubi9-python-3.11"
290+
expected_commitref="release-2024b"
291+
expected_build_name="jupyter-trustyai-ubi9-python-3.11-amd64"
292+
expected_img_size=4197
293+
;;
294+
odh-trustyai-notebook-image-n-2)
259295
expected_name="odh-notebook-jupyter-trustyai-ubi9-python-3.9"
260296
expected_commitref="release-2024a"
261297
expected_build_name="jupyter-trustyai-ubi9-python-3.9-amd64"
262298
expected_img_size=1123
263299
;;
264-
odh-trustyai-notebook-image-n-2)
300+
odh-trustyai-notebook-image-n-3)
265301
expected_name="odh-notebook-jupyter-trustyai-ubi9-python-3.9"
266302
expected_commitref="release-2023b"
267303
expected_build_name="jupyter-trustyai-ubi9-python-3.9-amd64"
268304
expected_img_size=1057
269305
;;
270-
odh-trustyai-notebook-image-n-3)
306+
odh-trustyai-notebook-image-n-4)
271307
expected_name="odh-notebook-jupyter-trustyai-ubi9-python-3.9"
272308
expected_commitref="release-2023a"
273309
expected_build_name="jupyter-trustyai-ubi9-python-3.9-amd64"
274310
expected_img_size=883
275311
;;
276312
odh-codeserver-notebook-image-n)
277313
expected_name="odh-notebook-code-server-ubi9-python-3.11"
278-
expected_commitref="release-2024b"
314+
expected_commitref="main"
279315
expected_build_name="codeserver-ubi9-python-3.11-amd64"
280316
expected_img_size=893
281317
;;
282318
odh-codeserver-notebook-image-n-1)
319+
expected_name="odh-notebook-code-server-ubi9-python-3.11"
320+
expected_commitref="release-2024b"
321+
expected_build_name="codeserver-ubi9-python-3.11-amd64"
322+
expected_img_size=893
323+
;;
324+
odh-codeserver-notebook-image-n-2)
283325
expected_name="odh-notebook-code-server-ubi9-python-3.9"
284326
expected_commitref="release-2024a"
285327
expected_build_name="codeserver-ubi9-python-3.9-amd64"
286328
expected_img_size=837
287329
;;
288-
odh-codeserver-notebook-image-n-2)
330+
odh-codeserver-notebook-image-n-3)
289331
expected_name="odh-notebook-code-server-ubi9-python-3.9"
290332
expected_commitref="release-2023b"
291333
expected_build_name="codeserver-ubi9-python-3.9-amd64"
292334
expected_img_size=778
293335
;;
294336
odh-rocm-minimal-notebook-image-n)
337+
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.11"
338+
expected_commitref="main"
339+
expected_build_name="rocm-jupyter-minimal-ubi9-python-3.11-amd64"
340+
expected_img_size=4830
341+
;;
342+
odh-rocm-minimal-notebook-image-n-1)
295343
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.11"
296344
expected_commitref="release-2024b"
297345
expected_build_name="rocm-jupyter-minimal-ubi9-python-3.11-amd64"
298346
expected_img_size=4830
299347
;;
300348
odh-rocm-pytorch-notebook-image-n)
349+
expected_name="odh-notebook-jupyter-rocm-pytorch-ubi9-python-3.11"
350+
expected_commitref="main"
351+
expected_build_name="rocm-jupyter-pytorch-ubi9-python-3.11-amd64"
352+
expected_img_size=6571
353+
;;
354+
odh-rocm-pytorch-notebook-image-n-1)
301355
expected_name="odh-notebook-jupyter-rocm-pytorch-ubi9-python-3.11"
302356
expected_commitref="release-2024b"
303357
expected_build_name="rocm-jupyter-pytorch-ubi9-python-3.11-amd64"
304358
expected_img_size=6571
305359
;;
306360
odh-rocm-tensorflow-notebook-image-n)
361+
expected_name="odh-notebook-jupyter-rocm-tensorflow-ubi9-python-3.11"
362+
expected_commitref="main"
363+
expected_build_name="rocm-jupyter-tensorflow-ubi9-python-3.11-amd64"
364+
expected_img_size=5782
365+
;;
366+
odh-rocm-tensorflow-notebook-image-n-1)
307367
expected_name="odh-notebook-jupyter-rocm-tensorflow-ubi9-python-3.11"
308368
expected_commitref="release-2024b"
309369
expected_build_name="rocm-jupyter-tensorflow-ubi9-python-3.11-amd64"

manifests/base/code-server-notebook-imagestream.yaml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ spec:
3636
{"name": "ipykernel", "version": "6.29"},
3737
{"name": "Kubeflow-Training", "version": "1.9"}
3838
]
39-
openshift.io/imported-from: quay.io/opendatahub/workbench-images
39+
openshift.io/imported-from: quay.io/modh/codeserver
4040
opendatahub.io/workbench-image-recommended: 'true'
4141
opendatahub.io/notebook-build-commit: $(odh-codeserver-notebook-image-commit-n)
4242
from:
@@ -45,7 +45,7 @@ spec:
4545
name: "2025.1"
4646
referencePolicy:
4747
type: Source
48-
# N-1 Version of the image
48+
# N - 1 Version of the image
4949
- annotations:
5050
# language=json
5151
opendatahub.io/notebook-software: |
@@ -68,15 +68,15 @@ spec:
6868
{"name": "Kubeflow-Training", "version": "1.8"}
6969
]
7070
openshift.io/imported-from: quay.io/modh/codeserver
71-
opendatahub.io/workbench-image-recommended: 'true'
72-
opendatahub.io/notebook-build-commit: $(odh-codeserver-notebook-image-commit-n)
71+
opendatahub.io/workbench-image-recommended: 'false'
72+
opendatahub.io/notebook-build-commit: $(odh-codeserver-notebook-image-commit-n-1)
7373
from:
7474
kind: DockerImage
75-
name: $(odh-codeserver-notebook-image-n)
75+
name: $(odh-codeserver-notebook-image-n-1)
7676
name: "2024.2"
7777
referencePolicy:
7878
type: Source
79-
# N - 1 Version of the image
79+
# N - 2 Version of the image
8080
- annotations:
8181
# language=json
8282
opendatahub.io/notebook-software: |
@@ -99,24 +99,24 @@ spec:
9999
{"name": "ipykernel", "version": "6.29"}
100100
]
101101
openshift.io/imported-from: quay.io/modh/codeserver
102-
opendatahub.io/workbench-image-recommended: 'false'
103-
opendatahub.io/notebook-build-commit: $(odh-codeserver-notebook-image-commit-n-1)
102+
opendatahub.io/image-tag-outdated: "true"
103+
opendatahub.io/notebook-build-commit: $(odh-codeserver-notebook-image-commit-n-2)
104104
from:
105105
kind: DockerImage
106-
name: $(odh-codeserver-notebook-image-n-1)
107-
name: "2024.2"
106+
name: $(odh-codeserver-notebook-image-n-2)
107+
name: "2024.1"
108108
referencePolicy:
109109
type: Source
110-
# N - 2 Version of the image
110+
# N - 3 Version of the image
111111
- annotations:
112112
opendatahub.io/notebook-software: '[{"name":"Python","version":"v3.9"}]'
113113
opendatahub.io/notebook-python-dependencies: '[{"name":"code-server","version":"4.16"}]'
114114
openshift.io/imported-from: quay.io/modh/codeserver
115115
opendatahub.io/image-tag-outdated: 'true'
116-
opendatahub.io/notebook-build-commit: $(odh-codeserver-notebook-image-commit-n-2)
116+
opendatahub.io/notebook-build-commit: $(odh-codeserver-notebook-image-commit-n-3)
117117
from:
118118
kind: DockerImage
119-
name: $(odh-codeserver-notebook-image-n-2)
119+
name: $(odh-codeserver-notebook-image-n-3)
120120
name: "2023.2"
121121
referencePolicy:
122122
type: Source

0 commit comments

Comments
 (0)