Skip to content

Commit ceced17

Browse files
Merge pull request opendatahub-io#1011 from jstourac/updates
NO-JIRA: chore - update the default image version in Makefile; add links to our contrib guide
2 parents 9d8f1b4 + 5216588 commit ceced17

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ Pull requests are the best way to propose changes to the notebooks repository:
4444
### Some basic instructions how to apply the new tests into [openshift-ci](https://github.com/openshift/release)
4545
4646
- Fork the [openshift-ci](https://github.com/openshift/release) repo and create your branch from master.
47+
- Definition and configuration of jobs used by this repository is on these places:
48+
- [jobs](https://github.com/openshift/release/tree/master/ci-operator/jobs/opendatahub-io/notebooks)
49+
- [config](https://github.com/openshift/release/tree/master/ci-operator/config/opendatahub-io/notebooks)
4750
- Issue a pull request there by adding the following.
4851
- Get navigated into [opendatahub-io-notebooks-main.yaml](https://github.com/openshift/release/blob/master/ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml) file.
4952
- Under `images` option, add build instructions (directory path, from(parent image) and to(new notebook name))

Makefile

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ endif
1919
.RECIPEPREFIX =
2020

2121
IMAGE_REGISTRY ?= quay.io/opendatahub/workbench-images
22-
RELEASE ?= 2024b
22+
RELEASE ?= 2025a
2323
RELEASE_PYTHON_VERSION ?= 3.11
2424
# additional user-specified caching parameters for $(CONTAINER_ENGINE) build
2525
CONTAINER_BUILD_CACHE_ARGS ?= --no-cache
@@ -36,12 +36,6 @@ endif
3636
DATE ?= $(shell date +'%Y%m%d')
3737
WHERE_WHICH ?= which
3838

39-
ifeq ($(RELEASE), 2025a)
40-
RELEASE_PYTHON_VERSION = 3.12
41-
else ifeq ($(RELEASE), 2024a)
42-
RELEASE_PYTHON_VERSION = 3.9
43-
endif
44-
4539

4640
# linux/amd64 or darwin/arm64
4741
OS_ARCH=$(shell go env GOOS)/$(shell go env GOARCH)

0 commit comments

Comments
 (0)