Skip to content

Commit 7792140

Browse files
committed
fix: Permit compile with SDK >= 9
1 parent 5c99025 commit 7792140

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ The `Unreleased` section name is replaced by the expected version of next releas
88

99
## [Unreleased]
1010

11+
### Changed
12+
13+
- Targeted`FSharp.Core` v `8.0.403` (To handle SDK >= 9 being strict on `RequireQualifiedAccess` with `Struct`) [#270](https://github.com/jet/propulsion/pull/270)
14+
1115
<a name="3.0.0"></a>
1216
## [3.0.0] - 2025-09-23
1317

src/Propulsion/Propulsion.fsproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
<PropertyGroup>
66
<TargetFramework>net6.0</TargetFramework>
7-
<!-- NOTE FSharp.Core dep is implies by what `FSharp.Control.TaskSeq` dictates; see below -->
7+
<!-- We want to depend on as old a version as possible. That would be 6.0.1, but we need v8 to be able to do RequireQualifiedAccess on a Struct with a V9+ compiler -->
88
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
99
<PackageValidationBaselineVersion>3.0.0</PackageValidationBaselineVersion>
1010
</PropertyGroup>
@@ -31,9 +31,9 @@
3131

3232
<ItemGroup>
3333
<PackageReference Include="MinVer" Version="5.0.0" PrivateAssets="All" />
34-
34+
<!-- Min FSharp.Core version that allows RequireQualifiedAccess on structs -->
35+
<PackageReference Include="FSharp.Core" Version="8.0.403" />
3536
<PackageReference Include="FsCodec" Version="3.1.0" />
36-
<!-- NOTE this transitively implies a min FSharp.Core 6.0.1 dependency (was 6.0.0 before) -->
3737
<PackageReference Include="FSharp.Control.TaskSeq" Version="0.4.0" />
3838
<PackageReference Include="MathNet.Numerics" Version="4.15.0" />
3939
<PackageReference Include="Serilog" Version="2.7.1" />

tests/Propulsion.Tests/Propulsion.Tests.fsproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@
2727
<ItemGroup>
2828
<PackageReference Include="FsCheck.Xunit" Version="3.0.0-rc3" />
2929
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
30-
<!-- Pin requirement for at least 6.0.6 in one of the tests by requesting same as Propulsion.DynamoStore will require-->
31-
<PackageReference Include="FSharp.Core" Version="6.0.7" ExcludeAssets="contentfiles" />
3230
<PackageReference Include="unquote" Version="6.1.0" />
3331
<PackageReference Include="xunit" Version="2.7.0" />
3432
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.3">

0 commit comments

Comments
 (0)