Skip to content

Commit f6aa552

Browse files
committed
Fix force_rebuild boolean conversion in workflows
- Change force_rebuild from || false to == 'true' - Properly convert string input to boolean for reusable workflow - Fixes 'Unexpected value true' error on line 62 - Apply fix to both esp-idf and platformio workflows
1 parent 13f39ce commit f6aa552

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/workflows/esp-idf.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# ESP-IDF Docker Build Workflow
2+
# Builds ESP-IDF development image with pytest, QEMU, and testing tools
23
name: 🐳 ESP-IDF Docker Image
34

45
env:
@@ -59,7 +60,7 @@ jobs:
5960
image_name: jethome-dev-esp-idf
6061
context_path: images/esp-idf
6162
version_tag: idf-${{ needs.prepare.outputs.esp_idf_version }}
62-
force_rebuild: ${{ github.event.inputs.force_rebuild || false }}
63+
force_rebuild: ${{ github.event.inputs.force_rebuild == 'true' }}
6364
custom_tags: ${{ github.event.inputs.custom_tags || '' }}
6465
build_args: |
6566
ESP_IDF_VERSION=${{ needs.prepare.outputs.esp_idf_version }}

.github/workflows/platformio.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959
image_name: jethome-dev-platformio
6060
context_path: images/platformio
6161
version_tag: pio-${{ needs.prepare.outputs.pio_version }}
62-
force_rebuild: ${{ github.event.inputs.force_rebuild || false }}
62+
force_rebuild: ${{ github.event.inputs.force_rebuild == 'true' }}
6363
custom_tags: ${{ github.event.inputs.custom_tags || '' }}
6464
build_args: |
6565
PIO_VERSION=${{ needs.prepare.outputs.pio_version }}

0 commit comments

Comments
 (0)