[cleanup] Remove init rec feature (#1890)

## Summary

This feature is not really maintained and out of date. I think value is
fairly limited.


fixes #1788

## How was it tested?
CICD

Author: mikeland73

go.mod

@@ -16,7 +16,6 @@ require (
 	github.com/briandowns/spinner v1.23.0
 	github.com/cavaliergopher/grab/v3 v3.0.1
 	github.com/cloudflare/ahocorasick v0.0.0-20210425175752-730270c3e184
-	github.com/creekorful/mvnparser v1.5.0
 	github.com/denisbrodbeck/machineid v1.0.1
 	github.com/f1bonacc1/process-compose v0.88.0
 	github.com/fatih/color v1.16.0

go.sum

@@ -125,8 +125,6 @@ github.com/cpuguy83/go-md2man/v2 v2.0.3/go.mod h1:tgQtvFlXSQOSOSIRvRPT7W67SCa46t
 github.com/creack/pty v1.1.17/go.mod h1:MOBLtS5ELjhRRrroQr9kyvTxUAFNvYEK993ew/Vr4O4=
 github.com/creack/pty v1.1.21 h1:1/QdRyBaHHJP61QkWMXlOIBfsgdDeeKfK8SYVUWJKf0=
 github.com/creack/pty v1.1.21/go.mod h1:MOBLtS5ELjhRRrroQr9kyvTxUAFNvYEK993ew/Vr4O4=
-github.com/creekorful/mvnparser v1.5.0 h1:tcaof1yFnyzz2t4tWAM7mwYcRLgiHB1Ch5hJHtnBoDk=
-github.com/creekorful/mvnparser v1.5.0/go.mod h1:FeYOFPluW+0s5hTa8JSCjHjpo4lWGq190OHbMuvqbBE=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=

internal/boxcli/global.go

@@ -72,7 +72,7 @@ func globalListCmd() *cobra.Command {
 }
 
 func listGlobalCmdFunc(cmd *cobra.Command, args []string) error {
-	path, err := ensureGlobalConfig(cmd)
+	path, err := ensureGlobalConfig()
 	if err != nil {
 		return errors.WithStack(err)
 	}
@@ -92,7 +92,7 @@ func listGlobalCmdFunc(cmd *cobra.Command, args []string) error {
 
 var globalConfigPath string
 
-func ensureGlobalConfig(cmd *cobra.Command) (string, error) {
+func ensureGlobalConfig() (string, error) {
 	if globalConfigPath != "" {
 		return globalConfigPath, nil
 	}
@@ -101,7 +101,7 @@ func ensureGlobalConfig(cmd *cobra.Command) (string, error) {
 	if err != nil {
 		return "", err
 	}
-	_, err = devbox.InitConfig(globalConfigPath, cmd.ErrOrStderr())
+	_, err = devbox.InitConfig(globalConfigPath)
 	if err != nil {
 		return "", err
 	}
@@ -112,7 +112,7 @@ func setGlobalConfigForDelegatedCommands(
 	globalCmd *cobra.Command,
 ) func(cmd *cobra.Command, args []string) error {
 	return func(cmd *cobra.Command, args []string) error {
-		globalPath, err := ensureGlobalConfig(cmd)
+		globalPath, err := ensureGlobalConfig()
 		if err != nil {
 			return err
 		}
@@ -132,7 +132,7 @@ func ensureGlobalEnvEnabled(cmd *cobra.Command, args []string) error {
 	if cmd.Name() == "shellenv" {
 		return nil
 	}
-	path, err := ensureGlobalConfig(cmd)
+	path, err := ensureGlobalConfig()
 	if err != nil {
 		return errors.WithStack(err)
 	}

internal/boxcli/init.go

@@ -19,16 +19,16 @@ func initCmd() *cobra.Command {
 			"You can then add packages using `devbox add`",
 		Args: cobra.MaximumNArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
-			return runInitCmd(cmd, args)
+			return runInitCmd(args)
 		},
 	}
 
 	return command
 }
 
-func runInitCmd(cmd *cobra.Command, args []string) error {
+func runInitCmd(args []string) error {
 	path := pathArg(args)
 
-	_, err := devbox.InitConfig(path, cmd.ErrOrStderr())
+	_, err := devbox.InitConfig(path)
 	return errors.WithStack(err)
 }

internal/devbox/devbox.go

@@ -76,8 +76,8 @@ type Devbox struct {
 
 var legacyPackagesWarningHasBeenShown = false
 
-func InitConfig(dir string, writer io.Writer) (bool, error) {
-	return devconfig.Init(dir, writer)
+func InitConfig(dir string) (bool, error) {
+	return devconfig.Init(dir)
 }
 
 func Open(opts *devopt.Opts) (*Devbox, error) {

internal/devbox/devbox_test.go

@@ -123,7 +123,7 @@ func TestComputeDevboxPathWhenRemoving(t *testing.T) {
 
 func devboxForTesting(t *testing.T) *Devbox {
 	path := t.TempDir()
-	_, err := devconfig.Init(path, os.Stdout)
+	_, err := devconfig.Init(path)
 	require.NoError(t, err, "InitConfig should not fail")
 	d, err := Open(&devopt.Opts{
 		Dir:    path,

internal/devconfig/init.go

@@ -5,42 +5,18 @@ package devconfig
 
 import (
 	"errors"
-	"fmt"
-	"io"
 	"os"
 	"path/filepath"
-	"strings"
-
-	"github.com/fatih/color"
 
 	"go.jetpack.io/devbox/internal/devconfig/configfile"
-	"go.jetpack.io/devbox/internal/initrec"
 )
 
-func Init(dir string, writer io.Writer) (created bool, err error) {
-	created, err = initConfigFile(filepath.Join(dir, configfile.DefaultName))
-	if err != nil || !created {
-		return created, err
-	}
-
-	// package suggestion
-	pkgsToSuggest, err := initrec.Get(dir)
-	if err != nil {
-		return created, err
-	}
-	if len(pkgsToSuggest) > 0 {
-		s := fmt.Sprintf("devbox add %s", strings.Join(pkgsToSuggest, " "))
-		fmt.Fprintf(
-			writer,
-			"We detected extra packages you may need. To install them, run `%s`\n",
-			color.HiYellowString(s),
-		)
-	}
-	return created, err
-}
-
-func initConfigFile(path string) (created bool, err error) {
-	file, err := os.OpenFile(path, os.O_RDWR|os.O_CREATE|os.O_EXCL, 0o644)
+func Init(dir string) (created bool, err error) {
+	file, err := os.OpenFile(
+		filepath.Join(dir, configfile.DefaultName),
+		os.O_RDWR|os.O_CREATE|os.O_EXCL,
+		0o644,
+	)
 	if errors.Is(err, os.ErrExist) {
 		return false, nil
 	}