[lagobot] properly extend timeout for macos tests (#831)

Author: savil

.github/workflows/cli-tests.yaml

@@ -21,6 +21,8 @@ on:
     inputs:
       run-example-tests:
         type: boolean
+      run-mac-tests:
+        type: boolean
 
 permissions:
   contents: read
@@ -49,7 +51,7 @@ jobs:
       matrix:
         os: [ubuntu-latest, macos-latest]
     runs-on: ${{ matrix.os }}
-    timeout-minutes: 15
+    timeout-minutes: 10
     steps:
       - uses: actions/checkout@v3
       - uses: actions/[email protected]
@@ -86,11 +88,11 @@ jobs:
         run-example-tests: [true, false]
         exclude:
           - is-main: false
-            os: macos-latest
+            os: "${{ inputs.run-mac-tests && 'dummy' || 'macos-latest' }}"
           - is-main: true
             run-example-tests: false
     runs-on: ${{ matrix.os }}
-    timeout-minutes: ${{ (github.ref == 'refs/heads/main' || inputs.run-mac-tests) && 20 || 10 }}
+    timeout-minutes: ${{ (github.ref == 'refs/heads/main' || inputs.run-mac-tests) && 25 || 10 }}
     steps:
       - uses: actions/checkout@v3
       - uses: actions/[email protected]
@@ -116,8 +118,10 @@ jobs:
       - name: Run tests
         env:
           DEVBOX_EXAMPLE_TESTS: ${{ matrix.run-example-tests }}
+          # Used in `go test -timeout` flag. Needs a value that time.ParseDuration can parse.
+          DEVBOX_GOLANG_TEST_TIMEOUT: "${{ (github.ref == 'refs/heads/main' || inputs.run-mac-tests) && '25m' || '10m' }}"
         run: |
-          go test ./...
+          go test -timeout $DEVBOX_GOLANG_TEST_TIMEOUT ./...
 
   auto-nix-install: # ensure Devbox installs nix and works properly after installation.
     strategy:

devbox.json

@@ -1,7 +1,8 @@
 {
   "packages": [
     "go_1_19",
-    "golangci-lint"
+    "golangci-lint",
+    "actionlint"
   ],
   "env": {
     "PATH": "$PATH:$PWD/dist"

testscripts/testrunner/examplesrunner.go

@@ -6,6 +6,8 @@ import (
 	"os"
 	"os/exec"
 	"path/filepath"
+	"runtime"
+	"strconv"
 	"strings"
 	"testing"
 
@@ -41,22 +43,25 @@ func RunExamplesTestscripts(t *testing.T, examplesDir string) {
 			return nil
 		}
 
-		// TODO savil. Resolve these.
-		skipList := []string{
+		if strings.Contains(path, "pipenv") {
+			// pipenv takes 1100 seconds on CICD
 
-			// pipenv: is enabled since it passes but it is slow, and we should examine why.
-
-			// drupal:
-			// https://gist.github.com/savil/9c67ffa50a2c51d118f3a4ce29ab920d
-			"drupal",
-		}
-		for _, toSkip := range skipList {
-			if strings.Contains(path, toSkip) {
-				t.Logf("skipping due to skipList (%s), config at: %s\n", toSkip, path)
+			// CI env var is always true in Github Actions
+			// https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables
+			ciEnv, err := strconv.ParseBool(os.Getenv("CI"))
+			isInCI := ciEnv && err == nil
+			if isInCI && runtime.GOOS == "darwin" {
+				t.Logf("skipping pipenv on darwin in CI. config at: %s\n", path)
 				return nil
 			}
 		}
 
+		if strings.Contains(path, "drupal") {
+			// drupal has errors like: https://gist.github.com/savil/9c67ffa50a2c51d118f3a4ce29ab920d
+			t.Logf("skipping drupal, config at: %s\n", path)
+			return nil
+		}
+
 		t.Logf("running testscript for example: %s\n", path)
 		runSingleExampleTestscript(t, examplesDir, path)
 		return nil