all: upgrade to Go 1.23.0 (#2229)

Author: gcurtis

devbox.lock

@@ -2,60 +2,60 @@
   "lockfile_version": "1",
   "packages": {
     "go@latest": {
-      "last_modified": "2024-05-29T10:04:41Z",
-      "resolved": "github:NixOS/nixpkgs/ac82a513e55582291805d6f09d35b6d8b60637a1#go",
+      "last_modified": "2024-08-14T11:41:26Z",
+      "resolved": "github:NixOS/nixpkgs/0cb2fd7c59fed0cd82ef858cbcbdb552b9a33465#go_1_23",
       "source": "devbox-search",
-      "version": "1.22.3",
+      "version": "1.23.0",
       "systems": {
         "aarch64-darwin": {
           "outputs": [
             {
               "name": "out",
-              "path": "/nix/store/i04a1a6qgxhjw6c0ld2b3x1v815sbxjc-go-1.22.3",
+              "path": "/nix/store/x097y3rdlvw6ax1id52xx2didgzxjg34-go-1.23.0",
               "default": true
             }
           ],
-          "store_path": "/nix/store/i04a1a6qgxhjw6c0ld2b3x1v815sbxjc-go-1.22.3"
+          "store_path": "/nix/store/x097y3rdlvw6ax1id52xx2didgzxjg34-go-1.23.0"
         },
         "aarch64-linux": {
           "outputs": [
             {
               "name": "out",
-              "path": "/nix/store/d68f2iblysnl0r4qcfdacmdpmvvy86kf-go-1.22.3",
+              "path": "/nix/store/znns5qk7fbhjb89bqhabxjxpgiq2ag1a-go-1.23.0",
               "default": true
             }
           ],
-          "store_path": "/nix/store/d68f2iblysnl0r4qcfdacmdpmvvy86kf-go-1.22.3"
+          "store_path": "/nix/store/znns5qk7fbhjb89bqhabxjxpgiq2ag1a-go-1.23.0"
         },
         "x86_64-darwin": {
           "outputs": [
             {
               "name": "out",
-              "path": "/nix/store/1p6vr83cgyfwm8517jhfmf6lypzhy3q2-go-1.22.3",
+              "path": "/nix/store/psym5ggdincwihwd81kssc4gbw1k3p3h-go-1.23.0",
               "default": true
             }
           ],
-          "store_path": "/nix/store/1p6vr83cgyfwm8517jhfmf6lypzhy3q2-go-1.22.3"
+          "store_path": "/nix/store/psym5ggdincwihwd81kssc4gbw1k3p3h-go-1.23.0"
         },
         "x86_64-linux": {
           "outputs": [
             {
               "name": "out",
-              "path": "/nix/store/00mg4vlhzmm7gi9bd5v5ydjlgrywpc3n-go-1.22.3",
+              "path": "/nix/store/0k144pnsvy0wa3dcl1y3df7d4zskylc4-go-1.23.0",
               "default": true
             }
           ],
-          "store_path": "/nix/store/00mg4vlhzmm7gi9bd5v5ydjlgrywpc3n-go-1.22.3"
+          "store_path": "/nix/store/0k144pnsvy0wa3dcl1y3df7d4zskylc4-go-1.23.0"
         }
       }
     },
     "runx:golangci/golangci-lint@latest": {
-      "resolved": "golangci/golangci-lint@v1.59.0",
-      "version": "v1.59.0"
+      "resolved": "golangci/golangci-lint@v1.60.2",
+      "version": "v1.60.2"
     },
     "runx:mvdan/gofumpt@latest": {
-      "resolved": "mvdan/gofumpt@v0.6.0",
-      "version": "v0.6.0"
+      "resolved": "mvdan/gofumpt@v0.7.0",
+      "version": "v0.7.0"
     }
   }
 }

go.mod

@@ -1,6 +1,6 @@
 module go.jetpack.io/devbox
 
-go 1.22.4
+go 1.23.0
 
 require (
 	github.com/AlecAivazis/survey/v2 v2.3.7

internal/boxcli/auth.go

@@ -133,7 +133,7 @@ func authNewTokenCommand() *cobra.Command {
 				// This is a hack because errors are not returning with correct code.
 				// Once that is fixed, we can switch to use *connect.Error Code() instead.
 				if strings.Contains(err.Error(), "permission_denied") {
-					ux.Ferror(
+					ux.Ferrorf(
 						cmd.ErrOrStderr(),
 						"You do not have permission to create a token. Please contact your"+
 							" administrator.",
@@ -142,7 +142,7 @@ func authNewTokenCommand() *cobra.Command {
 				}
 				return err
 			}
-			ux.Fsuccess(cmd.OutOrStdout(), "Token created.\n\n")
+			ux.Fsuccessf(cmd.OutOrStdout(), "Token created.\n\n")
 			table := tablewriter.NewWriter(cmd.OutOrStdout())
 			table.SetRowLine(true)
 			table.AppendBulk([][]string{

internal/boxcli/create.go

@@ -85,7 +85,7 @@ func runCreateCmd(cmd *cobra.Command, args []string, flags *createCmdFlags) erro
 		return err
 	}
 
-	ux.Fsuccess(
+	ux.Fsuccessf(
 		cmd.ErrOrStderr(),
 		"Initialized devbox project using template %s\n",
 		flags.template,

internal/boxcli/global.go

@@ -108,7 +108,7 @@ func ensureGlobalEnvEnabled(cmd *cobra.Command, args []string) error {
 	}
 	if !box.IsEnvEnabled() {
 		fmt.Fprintln(cmd.ErrOrStderr())
-		ux.Fwarning(
+		ux.Fwarningf(
 			cmd.ErrOrStderr(),
 			`devbox global is not activated.
 

internal/boxcli/midcobra/midcobra.go

@@ -78,7 +78,7 @@ func (ex *midcobraExecutable) Execute(ctx context.Context, args []string) int {
 		}
 		if errors.As(err, &exitErr) {
 			if !debug.IsEnabled() {
-				ux.Ferror(ex.cmd.ErrOrStderr(), "There was an internal error. "+
+				ux.Ferrorf(ex.cmd.ErrOrStderr(), "There was an internal error. "+
 					"Run with DEVBOX_DEBUG=1 for a detailed error message, and consider reporting it at "+
 					"https://github.com/jetify-com/devbox/issues\n")
 			}

internal/boxcli/search.go

@@ -111,7 +111,7 @@ func printSearchResults(
 
 	if resultsAreTrimmed {
 		fmt.Println()
-		ux.Fwarning(
+		ux.Fwarningf(
 			w,
 			"Showing top 10 results and truncated versions. Use --show-all to "+
 				"show all.\n\n",

internal/boxcli/secrets.go

@@ -244,7 +244,7 @@ func secretsInitFunc(
 		!box.Config().IsEnvsecEnabled() {
 		// Handle edge case where directory is already set up, but devbox.json is
 		// not configured to use jetpack-cloud.
-		ux.Finfo(
+		ux.Finfof(
 			cmd.ErrOrStderr(),
 			"Secrets already initialized. Adding to devbox config.\n",
 		)

internal/boxcli/setup.go

@@ -36,7 +36,7 @@ func setupCmd() *cobra.Command {
 
 func runInstallNixCmd(cmd *cobra.Command) error {
 	if nix.BinaryInstalled() {
-		ux.Finfo(
+		ux.Finfof(
 			cmd.ErrOrStderr(),
 			"Nix is already installed. If this is incorrect "+
 				"please remove the nix-shell binary from your path.\n",
@@ -61,7 +61,7 @@ func nixDaemonFlagVal(cmd *cobra.Command) func() *bool {
 	return func() *bool {
 		if !cmd.Flags().Changed(nixDaemonFlag) {
 			if os.Geteuid() == 0 {
-				ux.Fwarning(
+				ux.Fwarningf(
 					cmd.ErrOrStderr(),
 					"Running as root. Installing Nix in multi-user mode.\n",
 				)

internal/boxcli/usererr/usererr.go

@@ -5,6 +5,7 @@ package usererr
 
 import (
 	"fmt"
+	"io"
 
 	"github.com/pkg/errors"
 )
@@ -123,7 +124,7 @@ func (c *combined) Cause() error { return errors.Cause(c.source) }
 // Format allows us to use %+v as implemented by github.com/pkg/errors.
 func (c *combined) Format(s fmt.State, verb rune) {
 	if c.source == nil {
-		fmt.Fprintf(s, c.userMessage)
+		_, _ = io.WriteString(s, c.userMessage)
 		return
 	}
 	errors.Wrap(c.source, c.userMessage).(interface { //nolint:errorlint