Skip to content

Commit 33c39a6

Browse files
authored
impl: remove mod time check from template tests (#759)
When the tests run too fast, the mod time doesn't change between writes and the tests become flaky. Remove that check since we verify the file contents anyway.
1 parent 530be91 commit 33c39a6

File tree

1 file changed

+0
-26
lines changed

1 file changed

+0
-26
lines changed

internal/impl/generate_test.go

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -16,25 +16,13 @@ func TestWriteFromTemplate(t *testing.T) {
1616
if err != nil {
1717
t.Fatal("got error writing flake template:", err)
1818
}
19-
fi, err := os.Stat(outPath)
20-
if err != nil {
21-
t.Fatal("got stat error for new flake file:", err)
22-
}
23-
originalModTime := fi.ModTime()
2419
cmpGoldenFile(t, outPath, "testdata/flake.nix.golden")
2520

2621
t.Run("WriteUnmodified", func(t *testing.T) {
2722
err = writeFromTemplate(dir, testFlakeTmplPlan, "flake.nix")
2823
if err != nil {
2924
t.Fatal("got error writing flake template:", err)
3025
}
31-
fi, err := os.Stat(outPath)
32-
if err != nil {
33-
t.Fatal("got stat error for flake file:", err)
34-
}
35-
if !originalModTime.Equal(fi.ModTime()) {
36-
t.Errorf("flake mod time changed from %s to %s", originalModTime, fi.ModTime())
37-
}
3826
cmpGoldenFile(t, outPath, "testdata/flake.nix.golden")
3927
})
4028
t.Run("WriteModifiedSmaller", func(t *testing.T) {
@@ -49,27 +37,13 @@ func TestWriteFromTemplate(t *testing.T) {
4937
if err != nil {
5038
t.Fatal("got error writing flake template:", err)
5139
}
52-
fi, err := os.Stat(filepath.Join(dir, "flake.nix"))
53-
if err != nil {
54-
t.Fatal("got stat error for flake file:", err)
55-
}
56-
if originalModTime.Equal(fi.ModTime()) {
57-
t.Errorf("flake mod time didn't change from %s", originalModTime)
58-
}
5940
cmpGoldenFile(t, outPath, "testdata/flake-empty.nix.golden")
6041
})
6142
t.Run("WriteModifiedBigger", func(t *testing.T) {
6243
err = writeFromTemplate(dir, testFlakeTmplPlan, "flake.nix")
6344
if err != nil {
6445
t.Fatal("got error writing flake template:", err)
6546
}
66-
fi, err := os.Stat(filepath.Join(dir, "flake.nix"))
67-
if err != nil {
68-
t.Fatal("got stat error for flake file:", err)
69-
}
70-
if originalModTime.Equal(fi.ModTime()) {
71-
t.Errorf("flake mod time didn't change from %s", originalModTime)
72-
}
7347
cmpGoldenFile(t, outPath, "testdata/flake.nix.golden")
7448
})
7549
}

0 commit comments

Comments
 (0)