Skip to content

Commit 3c6af98

Browse files
authored
bump installed nix version to latest, and update test-nix-versions (#2301)
## Summary Bumping to 2.24.7 which seems latest tag on https://github.com/NixOS/nix/tags Our current hardcoded one is fairly old (we should more periodically update this), and is leading to issues with MacOS Sequoia (see NixOS/nix#11543) Also add this to the test-nix-versions. I am keeping the older nix versions around because some of them exercise older nix profile (and other similar issues that i am failing to recall atm) formats that some users may still be reliant on. At some point, we should consider bumping up our minimum nix version as well so we can deprecate legacy nix support (and keep the code base neater). ## How was it tested? @Lagoja is testing this manually will ensure cicd pass as a sanity test
1 parent ac07204 commit 3c6af98

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/cli-tests.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,13 +208,13 @@ jobs:
208208
run: devbox rm go
209209

210210
# Run a sanity test to make sure Devbox can install and remove packages with
211-
# the last 3 Nix releases.
211+
# the last few Nix releases.
212212
test-nix-versions:
213213
needs: build-devbox
214214
strategy:
215215
matrix:
216216
os: [ubuntu-latest, macos-13]
217-
nix-version: [2.15.1, 2.16.1, 2.17.0, 2.18.0, 2.19.2]
217+
nix-version: [2.15.1, 2.16.1, 2.17.0, 2.18.0, 2.19.2, 2.24.7]
218218
runs-on: ${{ matrix.os }}
219219
steps:
220220
- uses: actions/checkout@v4

internal/nix/install.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func Install(writer io.Writer, daemon *bool) error {
3838
}
3939
defer r.Close()
4040

41-
installScript := "curl -L https://releases.nixos.org/nix/nix-2.18.1/install | sh -s"
41+
installScript := "curl -L https://releases.nixos.org/nix/nix-2.24.7/install | sh -s"
4242
if daemon != nil {
4343
if *daemon {
4444
installScript += " -- --daemon"

0 commit comments

Comments
 (0)