Skip to content

Commit 44f079f

Browse files
authored
plugins/redis: log to stdout by default (#1793)
The redis plugin configures redis to log to a file in `.devbox/virtenv/redis/redis.log`. This causes logs to not show up in process-compose (with `devbox services up redis`), which relies on capturing logs from stdout/stderr. Logging to a file probably predates the process-compose integration back when there was no other way to view the logs. Today it makes more sense to default to having logs go to stdout and show up in process-compose. The trade-off is that logs will go to /dev/null if redis is launched as a regular daemon (and therefore doesn't have a stdout). In this case, the user can always uncomment the config line to send logs to a file again. Fixes #1727.
1 parent 928e8cb commit 44f079f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

plugins/redis/redis.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ loglevel notice
168168
# Specify the log file name. Also the empty string can be used to force
169169
# Redis to log on the standard output. Note that if you use standard
170170
# output for logging but daemonize, logs will be sent to /dev/null
171-
logfile redis.log
171+
# logfile redis.log
172172

173173
# To enable logging to the system logger, just set 'syslog-enabled' to yes,
174174
# and optionally update the other syslog parameters to suit your needs.

0 commit comments

Comments
 (0)