[services] Start/stop multiple services DEV-1270 (#381)

## Summary

This allows starting/stoping multiple services:

`devbox services start` starts all services
`devbox services start s1 s2` starts s1 and s2

If a service fails to start/stop we print and error and continue. If
only a single service is meant to be started/stoped we return an error.

## How was it tested?

```sh
devbox services start
devbox services stop
devbox services start apacheHttpd php-fpm
devbox services stop apacheHttpd php-fpm
```

Author: mikeland73

devbox.go

@@ -41,8 +41,8 @@ type Devbox interface {
 	// ShellPlan creates a plan of the actions that devbox will take to generate its
 	// shell environment.
 	ShellPlan() (*plansdk.ShellPlan, error)
-	StartService(serviceName string) error
-	StopService(serviceName string) error
+	StartServices(services ...string) error
+	StopServices(services ...string) error
 }
 
 // Open opens a devbox by reading the config file in dir.

internal/boxcli/services.go

@@ -34,20 +34,18 @@ func ServicesCmd() *cobra.Command {
 	}
 
 	startCommand := &cobra.Command{
-		Use:   "start [service]",
-		Short: "Starts service",
-		Args:  cobra.ExactArgs(1),
+		Use:   "start [service]...",
+		Short: "Starts service. If no service is specified, starts all services",
 		RunE: func(cmd *cobra.Command, args []string) error {
-			return startService(args[0], flags)
+			return startServices(cmd, args, flags)
 		},
 	}
 
 	stopCommand := &cobra.Command{
-		Use:   "stop [service]",
-		Short: "Stops service",
-		Args:  cobra.ExactArgs(1),
+		Use:   "stop [service]...",
+		Short: "Stops service. If no service is specified, stops all services",
 		RunE: func(cmd *cobra.Command, args []string) error {
-			return stopService(args[0], flags)
+			return stopServices(cmd, args, flags)
 		},
 	}
 
@@ -73,18 +71,50 @@ func listServices(cmd *cobra.Command, flags servicesCmdFlags) error {
 	return nil
 }
 
-func startService(service string, flags servicesCmdFlags) error {
+func startServices(cmd *cobra.Command, services []string, flags servicesCmdFlags) error {
 	box, err := devbox.Open(flags.config.path, os.Stdout)
 	if err != nil {
 		return errors.WithStack(err)
 	}
-	return box.StartService(service)
+	if len(services) == 0 {
+		services, err = serviceNames(box)
+		if err != nil {
+			return err
+		}
+		if len(services) == 0 {
+			cmd.Println("No services to start")
+			return nil
+		}
+	}
+	return box.StartServices(services...)
 }
 
-func stopService(service string, flags servicesCmdFlags) error {
+func stopServices(cmd *cobra.Command, services []string, flags servicesCmdFlags) error {
 	box, err := devbox.Open(flags.config.path, os.Stdout)
 	if err != nil {
 		return errors.WithStack(err)
 	}
-	return box.StopService(service)
+	if len(services) == 0 {
+		services, err = serviceNames(box)
+		if err != nil {
+			return err
+		}
+		if len(services) == 0 {
+			cmd.Println("No services to stop")
+			return nil
+		}
+	}
+	return box.StopServices(services...)
+}
+
+func serviceNames(box devbox.Devbox) ([]string, error) {
+	services, err := box.Services()
+	if err != nil {
+		return nil, err
+	}
+	names := []string{}
+	for _, service := range services {
+		names = append(names, service.Name)
+	}
+	return names, nil
 }

internal/impl/devbox.go

@@ -457,18 +457,18 @@ func (d *Devbox) Services() (plugin.Services, error) {
 	return plugin.GetServices(d.cfg.Packages, d.configDir)
 }
 
-func (d *Devbox) StartService(serviceName string) error {
+func (d *Devbox) StartServices(services ...string) error {
 	if !IsDevboxShellEnabled() {
-		return d.Exec("devbox", "services", "start", serviceName)
+		return d.Exec(append([]string{"devbox", "services", "start"}, services...)...)
 	}
-	return plugin.StartService(d.cfg.Packages, serviceName, d.configDir, d.writer)
+	return plugin.StartServices(d.cfg.Packages, services, d.configDir, d.writer)
 }
 
-func (d *Devbox) StopService(serviceName string) error {
+func (d *Devbox) StopServices(services ...string) error {
 	if !IsDevboxShellEnabled() {
-		return d.Exec("devbox", "services", "stop", serviceName)
+		return d.Exec(append([]string{"devbox", "services", "stop"}, services...)...)
 	}
-	return plugin.StopService(d.cfg.Packages, serviceName, d.configDir, d.writer)
+	return plugin.StopServices(d.cfg.Packages, services, d.configDir, d.writer)
 }
 
 func (d *Devbox) generateShellFiles() error {

internal/plugin/services.go

@@ -48,40 +48,52 @@ func (s *Services) UnmarshalJSON(b []byte) error {
 	return nil
 }
 
-func StartService(pkgs []string, name, rootDir string, out io.Writer) error {
-	services, err := GetServices(pkgs, rootDir)
+func StartServices(pkgs, serviceNames []string, root string, w io.Writer) error {
+	services, err := GetServices(pkgs, root)
 	if err != nil {
 		return err
 	}
-	service, found := services[name]
-	if !found {
-		return usererr.New("Service not found")
-	}
-	cmd := exec.Command("sh", "-c", service.Start)
-	cmd.Stdout = out
-	cmd.Stderr = out
-	err = cmd.Run()
-	if err == nil {
-		fmt.Fprintf(out, "Service %q started", name)
+	for _, name := range serviceNames {
+		service, found := services[name]
+		if !found {
+			return usererr.New("Service not found")
+		}
+		cmd := exec.Command("sh", "-c", service.Start)
+		cmd.Stdout = w
+		cmd.Stderr = w
+		if err = cmd.Run(); err != nil {
+			if len(serviceNames) == 1 {
+				return usererr.WithUserMessage(err, "Service %q failed to start", name)
+			}
+			fmt.Fprintf(w, "Service %q failed to start. Error = %s\n", name, err)
+		} else {
+			fmt.Fprintf(w, "Service %q started\n", name)
+		}
 	}
-	return usererr.WithUserMessage(err, "Service %q failed to start", name)
+	return nil
 }
 
-func StopService(pkgs []string, name, rootDir string, out io.Writer) error {
-	services, err := GetServices(pkgs, rootDir)
+func StopServices(pkgs, serviceNames []string, root string, w io.Writer) error {
+	services, err := GetServices(pkgs, root)
 	if err != nil {
 		return err
 	}
-	service, found := services[name]
-	if !found {
-		return usererr.New("Service not found")
-	}
-	cmd := exec.Command("sh", "-c", service.Stop)
-	cmd.Stdout = out
-	cmd.Stderr = out
-	err = cmd.Run()
-	if err == nil {
-		fmt.Fprintf(out, "Service %q stopped", name)
+	for _, name := range serviceNames {
+		service, found := services[name]
+		if !found {
+			return usererr.New("Service not found")
+		}
+		cmd := exec.Command("sh", "-c", service.Stop)
+		cmd.Stdout = w
+		cmd.Stderr = w
+		if err = cmd.Run(); err != nil {
+			if len(serviceNames) == 1 {
+				return usererr.WithUserMessage(err, "Service %q failed to stop", name)
+			}
+			fmt.Fprintf(w, "Service %q failed to stop. Error = %s\n", name, err)
+		} else {
+			fmt.Fprintf(w, "Service %q stopped\n", name)
+		}
 	}
-	return usererr.WithUserMessage(err, "Service %q failed to stop", name)
+	return nil
 }