Remove more dead code (#735)

## Summary
TSIA

## How was it tested?
CICD

Author: ipince

internal/impl/shell.go

@@ -18,7 +18,6 @@ import (
 	"github.com/alessio/shellescape"
 	"github.com/pkg/errors"
 	"go.jetpack.io/devbox/internal/boxcli/featureflag"
-	"go.jetpack.io/devbox/internal/boxcli/usererr"
 	"go.jetpack.io/devbox/internal/debug"
 	"go.jetpack.io/devbox/internal/nix"
 	"go.jetpack.io/devbox/internal/planner/plansdk"
@@ -64,9 +63,6 @@ type DevboxShell struct {
 	// UserInitHook contains commands that will run at shell startup.
 	UserInitHook string
 
-	ScriptName    string
-	ScriptCommand string
-
 	// profileDir is the absolute path to the directory storing the nix-profile
 	profileDir  string
 	historyFile string
@@ -289,17 +285,10 @@ func (s *DevboxShell) Run() error {
 	// This could be from one of the generated shellrc commands, but more likely is from
 	// a user's command or script. So, we want to return nil for this.
 	if exitErr := (&exec.ExitError{}); errors.As(err, &exitErr) {
-
-		// The exception to the previous comment is if we are executing a shell script
-		// via `devbox run` or the deprecated `devbox shell -- <command>`. In this case,
-		// we do want to return the exit code of the script that was run.
-		if s.ScriptCommand != "" {
-			return usererr.NewExecError(err)
-		}
 		return nil
 	}
 
-	// This means that there was a error from devbox's code or nix's code. Not a user
+	// This means that there was an error from devbox's code or nix's code. Not a user
 	// error and so we do return it.
 	return errors.WithStack(err)
 }
@@ -354,11 +343,6 @@ func (s *DevboxShell) writeDevboxShellrc() (path string, err error) {
 		}
 	}()
 
-	pathPrepend := s.profileDir + "/bin"
-	if s.pkgConfigDir != "" {
-		pathPrepend = s.pkgConfigDir + ":" + pathPrepend
-	}
-
 	tmpl := shellrcTmpl
 	if s.name == shFish {
 		tmpl = fishrcTmpl
@@ -370,8 +354,6 @@ func (s *DevboxShell) writeDevboxShellrc() (path string, err error) {
 		OriginalInitPath string
 		UserHook         string
 		PluginInitHook   string
-		PathPrepend      string
-		ScriptCommand    string
 		ShellStartTime   string
 		HistoryFile      string
 		ExportEnv        string
@@ -381,8 +363,6 @@ func (s *DevboxShell) writeDevboxShellrc() (path string, err error) {
 		OriginalInitPath: s.userShellrcPath,
 		UserHook:         strings.TrimSpace(s.UserInitHook),
 		PluginInitHook:   strings.TrimSpace(s.pluginInitHook),
-		PathPrepend:      pathPrepend,
-		ScriptCommand:    strings.TrimSpace(s.ScriptCommand),
 		ShellStartTime:   s.shellStartTime,
 		HistoryFile:      strings.TrimSpace(s.historyFile),
 		ExportEnv:        exportify(s.env),

internal/impl/shellrc.tmpl

@@ -27,8 +27,6 @@ content readable.
 
 {{ with .ExportEnv -}}
 {{ . }}
-{{- else -}}
-PATH="{{ .PathPrepend }}:$PATH"
 {{- end }}
 
 {{- /*
@@ -79,20 +77,3 @@ cd "$working_dir" || exit
 # log that the shell is interactive now!
 devbox log shell-interactive {{ .ShellStartTime }}
 {{ end }}
-
-{{- if .ScriptCommand }}
-
-# Begin Script Command
-
-run_script() {
-	working_dir="$(pwd)"
-	cd "{{ .ProjectDir }}" || exit
-
-	{{ .ScriptCommand }}
-
-	cd "$working_dir" || exit
-}
-
-# End Script Command
-
-{{- end }}

internal/impl/shellrc_fish.tmpl

@@ -27,8 +27,6 @@ makes fish do exactly what we want and behave in the same way as other shells.
 */ -}}
 {{ with .ExportEnv }}
 {{ . }}
-{{- else }}
-export PATH="{{ .PathPrepend }}:$PATH"
 {{- end }}
 
 {{- /*
@@ -83,20 +81,3 @@ cd "$workingDir" || exit
 # log that the shell is interactive now!
 devbox log shell-interactive {{ .ShellStartTime }}
 {{ end }}
-
-# Begin Script command
-
-{{- if .ScriptCommand }}
-
-function run_script
-    set workingDir "$(pwd)"
-    cd "{{ .ProjectDir }}" || exit
-
-    {{  .ScriptCommand }}
-
-    cd "$workingDir" || exit
-end
-
-# End Script command
-
-{{- end }}