Skip to content

Commit 5ae8c20

Browse files
authored
[cicd] bump timeouts for cli-tests (#905)
## Summary The test-step `cli-test` timeout needs to be bigger than the `go test --timeout` value since we run other steps prior to it. Also bumped the go test timeout, just to be safe. Obviously, this is not a long term solution. We need a way of caching the nix packages, but in the meantime prefer to have the Github Actions be Green. ## How was it tested? buildkite run should be green
1 parent 95ab46e commit 5ae8c20

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/cli-tests.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ jobs:
9292
- is-main: true
9393
run-example-tests: false
9494
runs-on: ${{ matrix.os }}
95-
timeout-minutes: ${{ (github.ref == 'refs/heads/main' || inputs.run-mac-tests) && 30 || 15 }}
95+
timeout-minutes: ${{ (github.ref == 'refs/heads/main' || inputs.run-mac-tests) && 37 || 20 }}
9696
steps:
9797
- uses: actions/checkout@v3
9898
- uses: actions/setup-go@v4
@@ -119,7 +119,7 @@ jobs:
119119
env:
120120
DEVBOX_EXAMPLE_TESTS: ${{ matrix.run-example-tests }}
121121
# Used in `go test -timeout` flag. Needs a value that time.ParseDuration can parse.
122-
DEVBOX_GOLANG_TEST_TIMEOUT: "${{ (github.ref == 'refs/heads/main' || inputs.run-mac-tests) && '30m' || '15m' }}"
122+
DEVBOX_GOLANG_TEST_TIMEOUT: "${{ (github.ref == 'refs/heads/main' || inputs.run-mac-tests) && '35m' || '15m' }}"
123123
run: |
124124
go test -timeout $DEVBOX_GOLANG_TEST_TIMEOUT ./...
125125

0 commit comments

Comments
 (0)