[docker] fix docker release image (#2136)

## Summary
This PR addresses the issue of our previous approach to only publish the
latest version of devbox with `:latest` tag in dockerhub. It achieves 2
things:
1. fixes the previously broken github action to release a docker image
after every tag creation.
2. updates the dockerfile so that devbox binary doesn't automatically
upgrade to latest version upon first use. This allows docker pulls have
fixed versions.


## How was it tested?
Already tested on releasing 0.10.7 version to dockerhub as test.
- `docker pull jetpackio/devbox:0.10.7`
- `docker run jetpackio/devbox:0.10.7`
- confirm output shows devbox version 0.10.7 and doesn't upgrade to
latest version.
- same for devbox-root-user

Author: mohsenari

.github/workflows/docker-image-release.yml

@@ -9,7 +9,7 @@ on:
       tag:
         description: 'tag name'
         required: true
-        default: 'undefined'
+        default: ''
         type: string
 
 jobs:
@@ -18,8 +18,6 @@ jobs:
     steps:
       - name: Check out the repo
         uses: actions/checkout@v4
-        with:
-          ref: ${{ inputs.tag || github.ref }}
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v2
       - name: Docker meta
@@ -29,19 +27,19 @@ jobs:
           images: |
             jetpackio/devbox
           tags: |
-            type=semver,pattern={{version}}
+            type=raw,value=${{ inputs.tag || github.ref_name }}
           flavor: |
-            latest=${{ inputs.tag && true || false }}
+            latest=false
       - name: Docker meta root
         id: metaroot
         uses: docker/metadata-action@v5
         with:
           images: |
             jetpackio/devbox-root-user
           tags: |
-            type=semver,pattern={{version}}
+            type=raw,value=${{ inputs.tag || github.ref_name }}
           flavor: |
-            latest=${{ inputs.tag && true || false }}
+            latest=false
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v2
       - name: Login to Docker Hub
@@ -55,7 +53,7 @@ jobs:
           context: ./internal/devbox/generate/tmpl/
           file: ./internal/devbox/generate/tmpl/DevboxImageDockerfile
           build-args: |
-            DEVBOX_USE_VERSION=${{ inputs.tag }}
+            DEVBOX_USE_VERSION=${{ inputs.tag || github.ref_name }}
           push: true
           platforms: linux/amd64,linux/arm64
           tags: ${{ steps.meta.outputs.tags }}
@@ -65,7 +63,7 @@ jobs:
           context: ./internal/devbox/generate/tmpl/
           file: ./internal/devbox/generate/tmpl/DevboxImageDockerfileRootUser
           build-args: |
-            DEVBOX_USE_VERSION=${{ inputs.tag }}
+            DEVBOX_USE_VERSION=${{ inputs.tag || github.ref_name }}
           push: true
           platforms: linux/amd64,linux/arm64
           tags: ${{ steps.metaroot.outputs.tags }}

internal/devbox/generate/tmpl/DevboxImageDockerfile

@@ -25,4 +25,7 @@ ENV DEVBOX_USE_VERSION=$DEVBOX_USE_VERSION
 RUN wget --quiet --output-document=/dev/stdout https://get.jetify.com/devbox   | bash -s -- -f
 RUN chown -R "${DEVBOX_USER}:${DEVBOX_USER}" /usr/local/bin/devbox
 
-CMD ["devbox", "version"]
+# run a devbox command to make launcher download devbox binary
+RUN devbox version
+
+CMD ["devbox", "version", "-v"]

internal/devbox/generate/tmpl/DevboxImageDockerfileRootUser

@@ -17,5 +17,7 @@ ENV PATH="/root/.nix-profile/bin:$PATH"
 # Step 3: Installing devbox
 ENV DEVBOX_USE_VERSION=$DEVBOX_USE_VERSION
 RUN wget --quiet --output-document=/dev/stdout https://get.jetify.com/devbox   | bash -s -- -f
+# run a devbox command to make launcher download devbox binary
+RUN devbox version
 
-CMD ["devbox", "version"]
+CMD ["devbox", "version", "-v"]