error out if env_from is absolute path

mohsenari · mohsenari · commit 6dbef3382943 · 2024-10-15T18:21:45.000-04:00
diff --git a/internal/devconfig/configfile/env.go b/internal/devconfig/configfile/env.go
@@ -27,8 +27,9 @@ func (c *ConfigFile) ParseEnvsFromDotEnv() (map[string]string, error) {
 		return nil, fmt.Errorf("env file does not have a .env extension")
 	}
 	envFileAbsPath := filepath.Dir(c.AbsRootPath)
+	// We don't allow absolute path for env_from as it breaks reproducibility
 	if filepath.IsAbs(c.EnvFrom) {
-		envFileAbsPath = path.Join(envFileAbsPath, path.Base(c.EnvFrom))
+		return nil, fmt.Errorf("`env_from` field can't take an absolute path")
 	} else {
 		envFileAbsPath = path.Join(envFileAbsPath, c.EnvFrom)
 	}

Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,9 @@ func (c *ConfigFile) ParseEnvsFromDotEnv() (map[string]string, error) {`
`27`	`27`	`return nil, fmt.Errorf("env file does not have a .env extension")`
`28`	`28`	`}`
`29`	`29`	`envFileAbsPath := filepath.Dir(c.AbsRootPath)`
	`30`	`+ // We don't allow absolute path for env_from as it breaks reproducibility`
`30`	`31`	`if filepath.IsAbs(c.EnvFrom) {`
`31`		`- envFileAbsPath = path.Join(envFileAbsPath, path.Base(c.EnvFrom))`
	`32`	+ return nil, fmt.Errorf("`env_from` field can't take an absolute path")
`32`	`33`	`} else {`
`33`	`34`	`envFileAbsPath = path.Join(envFileAbsPath, c.EnvFrom)`
`34`	`35`	`}`