Skip to content

Commit 96a193e

Browse files
authored
[rm-nixpkgs] drop warning about missing store path when updating lockfile (#1459)
## Summary We'd show this warning about missing store path to users. ``` ❯ time devbox add nodePackages_latest.yalc@latest Warning: Failed to resolve store path for x86_64-darwin with storeHash h1fpdwwq2x528xwq3si97z6vny0vkjhf. Installing will be a bit slower. Warning: Failed to resolve store path for x86_64-linux with storeHash is1ds4h8qa95s31crvgf19mlmx1990s3. Installing will be a bit slower. Warning: Warning: Failed to resolve store path for aarch64-linux with storeHash cqjb45zk4cs4i4qzkknh5116zk7z471g. Installing will be a bit slower. Failed to resolve store path for aarch64-darwin with storeHash 5wfxcx235xpwr5lcv29ijlpw85kb0vj0. Installing will be a bit slower. Installing package: nodePackages_latest.yalc@latest. [1/1] nodePackages_latest.yalc@latest [1/1] nodePackages_latest.yalc@latest: Success devbox add nodePackages_latest.yalc@latest 2.00s user 0.66s system 47% cpu 5.551 total ``` However, this isn't very helpful: 1. The users cannot do anything with this info. 2. The install experience will be the "slow path" but that is what users are already used to. 3. If a user complains about slow install, then we can inspect their `devbox.lock` and we'll know if the store-path is missing or not. ## How was it tested? ``` > time devbox add nodePackages_latest.yalc@latest Installing package: nodePackages_latest.yalc@latest. [1/1] nodePackages_latest.yalc@latest [1/1] nodePackages_latest.yalc@latest: Success ________________________________________________________ Executed in 12.67 secs fish external usr time 4.75 secs 0.99 millis 4.75 secs sys time 1.72 secs 1.83 millis 1.72 secs ```
1 parent 68a9b9b commit 96a193e

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

internal/lock/resolve.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ package lock
66
import (
77
"context"
88
"fmt"
9-
"os"
109
"sync"
1110
"time"
1211

@@ -17,7 +16,6 @@ import (
1716
"go.jetpack.io/devbox/internal/debug"
1817
"go.jetpack.io/devbox/internal/nix"
1918
"go.jetpack.io/devbox/internal/searcher"
20-
"go.jetpack.io/devbox/internal/ux"
2119
"golang.org/x/exp/maps"
2220
"golang.org/x/sync/errgroup"
2321
)
@@ -103,12 +101,6 @@ func buildLockSystemInfos(pkg *searcher.PackageVersion) (map[string]*SystemInfo,
103101
path, err := nix.StorePathFromHashPart(ctx, sysInfo.StoreHash, "https://cache.nixos.org")
104102
if err != nil {
105103
// Should we report this to sentry to collect data?
106-
ux.Fwarning(
107-
os.Stderr,
108-
"Failed to resolve store path for %s with storeHash %s. Installing will be a bit slower.\n",
109-
sysName,
110-
sysInfo.StoreHash,
111-
)
112104
debug.Log(
113105
"Failed to resolve store path for %s with storeHash %s. Error is %s.\n",
114106
sysName,

0 commit comments

Comments
 (0)