Skip to content

Commit a9c797d

Browse files
authored
[lagobot] enable pipenv (#820)
## Summary The pipenv stuff is slow, because it seems to not respect the nix packages cache? Not fully sure. We should debug it. But we can land it for now, since we are no longer running examples tests on PRs. They will be run on `main` soon. ## How was it tested?
1 parent c388a0e commit a9c797d

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

testscripts/testrunner/examplesrunner.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,11 @@ func RunExamplesTestscripts(t *testing.T, examplesDir string) {
4444
// TODO savil. Resolve these.
4545
skipList := []string{
4646

47+
// pipenv: is enabled since it passes but it is slow, and we should examine why.
48+
4749
// drupal:
4850
// https://gist.github.com/savil/9c67ffa50a2c51d118f3a4ce29ab920d
4951
"drupal",
50-
51-
// pipenv takes too long: 350 seconds
52-
"pipenv",
5352
}
5453
for _, toSkip := range skipList {
5554
if strings.Contains(path, toSkip) {
@@ -58,7 +57,6 @@ func RunExamplesTestscripts(t *testing.T, examplesDir string) {
5857
}
5958
}
6059

61-
// TODO run in parallel
6260
t.Logf("running testscript for example: %s\n", path)
6361
runSingleExampleTestscript(t, examplesDir, path)
6462
return nil

0 commit comments

Comments
 (0)