[refactor] Remove devbox interface (#1690)

## Summary

Removes the devbox interface (`devbox.go` in root). I feel like it was
making code harder to follow and not providing any value.

Chatted with @loreto a few weeks ago about doing this. I was about to
add a new function to interface and decided to remove instead.

A possible follow up could be to remove `devopt.Opts` to avoid some
ducplication.

## How was it tested?

builds, CICD.

Author: mikeland73

.github/workflows/docker-image-release.yml

@@ -20,16 +20,16 @@ jobs:
       - name: Build and push default
         uses: docker/build-push-action@v4
         with:
-          context: ./internal/impl/generate/tmpl/
-          file: ./internal/impl/generate/tmpl/DevboxImageDockerfile
+          context: ./internal/devbox/generate/tmpl/
+          file: ./internal/devbox/generate/tmpl/DevboxImageDockerfile
           push: true
           platforms: linux/amd64,linux/arm64
           tags: jetpackio/devbox:latest
       - name: Build and push root user
         uses: docker/build-push-action@v4
         with:
-          context: ./internal/impl/generate/tmpl/
-          file: ./internal/impl/generate/tmpl/DevboxImageDockerfileRootUser
+          context: ./internal/devbox/generate/tmpl/
+          file: ./internal/devbox/generate/tmpl/DevboxImageDockerfileRootUser
           push: true
           platforms: linux/amd64,linux/arm64
           tags: jetpackio/devbox-root-user:latest

devbox.go

@@ -9,9 +9,9 @@ import (
 	"github.com/pkg/errors"
 	"github.com/spf13/cobra"
 
-	"go.jetpack.io/devbox"
 	"go.jetpack.io/devbox/internal/boxcli/usererr"
-	"go.jetpack.io/devbox/internal/impl/devopt"
+	"go.jetpack.io/devbox/internal/devbox"
+	"go.jetpack.io/devbox/internal/devbox/devopt"
 	"go.jetpack.io/devbox/internal/nix"
 )
 

internal/boxcli/add.go

@@ -10,11 +10,11 @@ import (
 	"github.com/pkg/errors"
 	"github.com/spf13/cobra"
 
-	"go.jetpack.io/devbox"
 	"go.jetpack.io/devbox/internal/boxcli/usererr"
 	"go.jetpack.io/devbox/internal/cloud"
+	"go.jetpack.io/devbox/internal/devbox"
+	"go.jetpack.io/devbox/internal/devbox/devopt"
 	"go.jetpack.io/devbox/internal/envir"
-	"go.jetpack.io/devbox/internal/impl/devopt"
 )
 
 type cloudShellCmdFlags struct {

internal/boxcli/cloud.go

@@ -9,7 +9,7 @@ import (
 	"github.com/joho/godotenv"
 	"github.com/pkg/errors"
 	"github.com/spf13/cobra"
-	"go.jetpack.io/devbox/internal/impl/devopt"
+	"go.jetpack.io/devbox/internal/devbox/devopt"
 )
 
 // to be composed into xyzCmdFlags structs

internal/boxcli/env.go

@@ -6,9 +6,9 @@ package boxcli
 import (
 	"github.com/pkg/errors"
 	"github.com/spf13/cobra"
-	"go.jetpack.io/devbox"
 	"go.jetpack.io/devbox/internal/build"
-	"go.jetpack.io/devbox/internal/impl/devopt"
+	"go.jetpack.io/devbox/internal/devbox"
+	"go.jetpack.io/devbox/internal/devbox/devopt"
 	"go.jetpack.io/envsec/pkg/envsec"
 	"go.jetpack.io/pkg/envvar"
 )

internal/boxcli/envsec.go

@@ -7,9 +7,9 @@ import (
 	"github.com/pkg/errors"
 	"github.com/spf13/cobra"
 
-	"go.jetpack.io/devbox"
 	"go.jetpack.io/devbox/internal/cloud"
-	"go.jetpack.io/devbox/internal/impl/devopt"
+	"go.jetpack.io/devbox/internal/devbox"
+	"go.jetpack.io/devbox/internal/devbox/devopt"
 )
 
 type generateCmdFlags struct {

internal/boxcli/generate.go

@@ -9,8 +9,8 @@ import (
 	"github.com/pkg/errors"
 	"github.com/spf13/cobra"
 
-	"go.jetpack.io/devbox"
-	"go.jetpack.io/devbox/internal/impl/devopt"
+	"go.jetpack.io/devbox/internal/devbox"
+	"go.jetpack.io/devbox/internal/devbox/devopt"
 	"go.jetpack.io/devbox/internal/ux"
 )
 

internal/boxcli/global.go

@@ -9,8 +9,8 @@ import (
 	"github.com/pkg/errors"
 	"github.com/spf13/cobra"
 
-	"go.jetpack.io/devbox"
-	"go.jetpack.io/devbox/internal/impl/devopt"
+	"go.jetpack.io/devbox/internal/devbox"
+	"go.jetpack.io/devbox/internal/devbox/devopt"
 )
 
 type infoCmdFlags struct {

internal/boxcli/info.go

@@ -7,7 +7,7 @@ import (
 	"github.com/pkg/errors"
 	"github.com/spf13/cobra"
 
-	"go.jetpack.io/devbox"
+	"go.jetpack.io/devbox/internal/devbox"
 )
 
 func initCmd() *cobra.Command {