[process-compose] Remove old process compose using store path (#1903)

## Summary

Fixes #1901

Alternative: #1902

nix 2.20 removed index support. Use store paths instead.

## How was it tested?

Author: mikeland73

internal/devbox/devbox.go

@@ -782,7 +782,7 @@ func (d *Devbox) StartProcessManager(
 		oldProcessComposePkg := "github:F1bonacc1/process-compose/" + pcVersion + "#defaultPackage." + nix.System()
 		newProcessComposePkg := "github:F1bonacc1/process-compose/" + processComposeTargetVersion
 		// Find the old process Compose package
-		if err := d.removeDevboxUtilityPackage(oldProcessComposePkg); err != nil {
+		if err := d.removeDevboxUtilityPackage(ctx, oldProcessComposePkg); err != nil {
 			return err
 		}
 

internal/devbox/util.go

@@ -5,15 +5,13 @@ package devbox
 
 import (
 	"context"
-	"fmt"
 	"io/fs"
 	"os"
 	"path/filepath"
 
 	"github.com/pkg/errors"
 	"go.jetpack.io/devbox/internal/devpkg"
 	"go.jetpack.io/devbox/internal/nix"
-	"go.jetpack.io/devbox/internal/nix/nixprofile"
 
 	"go.jetpack.io/devbox/internal/xdg"
 )
@@ -47,7 +45,9 @@ func (d *Devbox) addDevboxUtilityPackage(ctx context.Context, pkgName string) er
 	return nil
 }
 
-func (d *Devbox) removeDevboxUtilityPackage(pkgName string) error {
+func (d *Devbox) removeDevboxUtilityPackage(
+	ctx context.Context, pkgName string,
+) error {
 	pkg := devpkg.PackageFromStringWithDefaults(pkgName, d.lockfile)
 	installables, err := pkg.Installables()
 	if err != nil {
@@ -59,20 +59,15 @@ func (d *Devbox) removeDevboxUtilityPackage(pkgName string) error {
 		return err
 	}
 
-	profile, err := nixprofile.ProfileListItems(d.stderr, utilityProfilePath)
-	if err != nil {
-		return err
-	}
-
 	for _, installable := range installables {
-		for i, profileItem := range profile {
-			if profileItem.MatchesUnlockedReference(installable) {
-				err = nix.ProfileRemove(utilityProfilePath, fmt.Sprint(i))
-				if err != nil {
-					return err
-				}
-				// We are done with this installable. Now, remove the next installable:
-				break
+		storePaths, err := nix.StorePathsFromInstallable(ctx, installable, false)
+		if err != nil {
+			return err
+		}
+
+		for _, storePath := range storePaths {
+			if err = nix.ProfileRemove(utilityProfilePath, storePath); err != nil {
+				return err
 			}
 		}
 	}

internal/nix/profiles.go

@@ -75,13 +75,15 @@ func ProfileInstall(ctx context.Context, args *ProfileInstallArgs) error {
 	return cmd.Run()
 }
 
-func ProfileRemove(profilePath string, indexes ...string) error {
+// ProfileRemove removes packages from a profile.
+// WARNING, don't use indexes, they are not supported by nix 2.20+
+func ProfileRemove(profilePath string, packageNames ...string) error {
 	cmd := command(
 		append([]string{
 			"profile", "remove",
 			"--profile", profilePath,
 			"--impure", // for NIXPKGS_ALLOW_UNFREE
-		}, indexes...)...,
+		}, packageNames...)...,
 	)
 	cmd.Env = allowUnfreeEnv(allowInsecureEnv(os.Environ()))