chore: update env constants and functions (#954)

## Summary

1. Unexport some constants in `env`
2. Rename some functions in `env`

## How was it tested?

Author: hezhizhen

internal/cloud/openssh/sshshim/invoke.go

@@ -10,6 +10,7 @@ import (
 	"syscall"
 
 	"github.com/pkg/errors"
+
 	"go.jetpack.io/devbox/internal/debug"
 )
 

internal/env/env.go

@@ -5,7 +5,7 @@ package env
 
 const (
 	DevboxCache              = "DEVBOX_CACHE"
-	DevboxCLICloudShell      = "DEVBOX_CLI_CLOUD_SHELL"
+	devboxCLICloudShell      = "DEVBOX_CLI_CLOUD_SHELL"
 	DevboxDebug              = "DEVBOX_DEBUG"
 	DevboxFeaturePrefix      = "DEVBOX_FEATURE_"
 	DevboxGateway            = "DEVBOX_GATEWAY"
@@ -16,14 +16,10 @@ const (
 	DevboxShellStartTime     = "DEVBOX_SHELL_START_TIME"
 	DevboxVM                 = "DEVBOX_VM"
 
-	DoNotTrack = "DO_NOT_TRACK"
-
 	LauncherVersion = "LAUNCHER_VERSION"
 
 	SSHTTY = "SSH_TTY"
 
-	StartWebTerminal = "START_WEB_TERMINAL"
-
 	XDGDataHome   = "XDG_DATA_HOME"
 	XDGConfigHome = "XDG_CONFIG_HOME"
 	XDGCacheHome  = "XDG_CACHE_HOME"

internal/env/util.go

@@ -9,7 +9,7 @@ import (
 )
 
 func IsCLICloudShell() bool {
-	cliCloudShell, _ := strconv.ParseBool(os.Getenv(DevboxCLICloudShell))
+	cliCloudShell, _ := strconv.ParseBool(os.Getenv(devboxCLICloudShell))
 	return cliCloudShell
 }
 
@@ -22,9 +22,9 @@ func IsDevboxShellEnabled() bool {
 	return inDevboxShell
 }
 
-func NotTrack() bool {
+func DoNotTrack() bool {
 	// https://consoledonottrack.com/
-	doNotTrack, _ := strconv.ParseBool(os.Getenv(DoNotTrack))
+	doNotTrack, _ := strconv.ParseBool(os.Getenv("DO_NOT_TRACK"))
 	return doNotTrack
 }
 
@@ -33,13 +33,13 @@ func IsDevboxDebugEnabled() bool {
 	return enabled
 }
 
-func NotUpgradeConfig() bool {
+func DoNotUpgradeConfig() bool {
 	notUpgrade, _ := strconv.ParseBool(os.Getenv(DevboxDoNotUpgradeConfig))
 	return notUpgrade
 }
 
 func IsInBrowser() bool { // TODO: a better name
-	inBrowser, _ := strconv.ParseBool(os.Getenv(StartWebTerminal))
+	inBrowser, _ := strconv.ParseBool(os.Getenv("START_WEB_TERMINAL"))
 	return inBrowser
 }
 

internal/impl/config.go

@@ -88,7 +88,7 @@ func readConfigFromURL(url *url.URL) (*Config, error) {
 }
 
 func upgradeConfig(cfg *Config, absFilePath string) error {
-	if env.NotUpgradeConfig() {
+	if env.DoNotUpgradeConfig() {
 		return nil
 	}
 	if cfg.Nixpkgs.Commit == "" {

internal/impl/shellcmd/command.go

@@ -15,7 +15,7 @@ import (
 // Formats for marshalling and unmarshalling a series of shell commands in a
 // devbox config.
 const (
-	// CmdArray formats shell commands as an array of of strings.
+	// CmdArray formats shell commands as an array of strings.
 	CmdArray CmdFormat = iota
 
 	// CmdString formats shell commands as a single string.
@@ -46,7 +46,6 @@ type Commands struct {
 	// UnmarshalJSON will set MarshalAs automatically so that commands
 	// marshal back to their original format. The default zero-value
 	// formats them as an array.
-	//
 	MarshalAs CmdFormat
 	Cmds      []string
 }

internal/telemetry/sentry.go

@@ -50,7 +50,7 @@ var started bool
 
 // Start enables telemetry for the current program.
 func Start(appName string) {
-	if started || env.NotTrack() {
+	if started || env.DoNotTrack() {
 		return
 	}
 	started = initSentry(appName)

internal/telemetry/telemetry.go

@@ -20,7 +20,7 @@ const (
 func init() {
 	// TODO(gcurtis): clean this up so that Sentry and Segment use the same
 	// start/stop functions.
-	if env.NotTrack() || build.TelemetryKey == "" {
+	if env.DoNotTrack() || build.TelemetryKey == "" {
 		return
 	}
 	enabled = true