[perf] memoize cache setup status (#2100)

## Summary

TSIA

This still means an extra ~50-100ms because we check the status but this
is probably fine.

## How was it tested?

The `defer debug.FunctionTimer().End()` call in Status only prints once.

Author: mikeland73

internal/devbox/providers/nixcache/nixcache.go

@@ -23,7 +23,7 @@ import (
 	"go.jetpack.io/pkg/filecache"
 )
 
-var cachedCredentials = goutil.OnceWithContext(
+var cachedCredentials = goutil.OnceValuesWithContext(
 	func(ctx context.Context) (AWSCredentials, error) {
 		// Adding version to caches to avoid conflicts if we want to update the schema
 		// or while working on dev.
@@ -85,7 +85,7 @@ func Caches(
 	return resp.GetCaches(), nil
 }
 
-var cachedReadCaches = goutil.OnceWithContext(
+var cachedReadCaches = goutil.OnceValuesWithContext(
 	func(ctx context.Context) ([]*nixv1alpha1.NixBinCache, error) {
 		caches, err := Caches(ctx)
 		if err != nil {
@@ -102,7 +102,7 @@ func CachedReadCaches(ctx context.Context) ([]*nixv1alpha1.NixBinCache, error) {
 }
 
 func DisableReadCaches() {
-	cachedReadCaches = goutil.OnceWithContext(
+	cachedReadCaches = goutil.OnceValuesWithContext(
 		func(ctx context.Context) ([]*nixv1alpha1.NixBinCache, error) {
 			return nil, nil
 		},

internal/devpkg/narinfo_cache.go

@@ -16,6 +16,7 @@ import (
 	"go.jetpack.io/devbox/internal/boxcli/featureflag"
 	"go.jetpack.io/devbox/internal/debug"
 	"go.jetpack.io/devbox/internal/devbox/providers/nixcache"
+	"go.jetpack.io/devbox/internal/goutil"
 	"go.jetpack.io/devbox/internal/lock"
 	"go.jetpack.io/devbox/internal/nix"
 	"golang.org/x/sync/errgroup"
@@ -339,9 +340,11 @@ func fetchNarInfoStatusFromS3(
 	return fetch.(func() (bool, error))()
 }
 
+var nixCacheIsConfigured = goutil.OnceValueWithContext(nixcache.IsConfigured)
+
 func readCaches(ctx context.Context) ([]string, error) {
 	cacheURIs := []string{binaryCache}
-	if !nixcache.IsConfigured(ctx) {
+	if !nixCacheIsConfigured.Do(ctx) {
 		return cacheURIs, nil
 	}
 

internal/goutil/sync.go

@@ -5,18 +5,35 @@ import (
 	"sync"
 )
 
-type once[T any] struct {
+type onceValue[T any] struct {
+	once   sync.Once
+	fn     func(context.Context) T
+	result T
+}
+
+func OnceValueWithContext[T any](fn func(context.Context) T) *onceValue[T] {
+	return &onceValue[T]{fn: fn}
+}
+
+func (o *onceValue[T]) Do(ctx context.Context) T {
+	o.once.Do(func() {
+		o.result = o.fn(ctx)
+	})
+	return o.result
+}
+
+type onceValues[T any] struct {
 	once   sync.Once
 	fn     func(context.Context) (T, error)
 	result T
 	err    error
 }
 
-func OnceWithContext[T any](fn func(context.Context) (T, error)) *once[T] {
-	return &once[T]{fn: fn}
+func OnceValuesWithContext[T any](fn func(context.Context) (T, error)) *onceValues[T] {
+	return &onceValues[T]{fn: fn}
 }
 
-func (o *once[T]) Do(ctx context.Context) (T, error) {
+func (o *onceValues[T]) Do(ctx context.Context) (T, error) {
 	o.once.Do(func() {
 		o.result, o.err = o.fn(ctx)
 	})

internal/setup/setup.go

@@ -94,6 +94,7 @@ const (
 
 // Status returns the status of a setup task.
 func Status(ctx context.Context, key string, task Task) TaskStatus {
+	defer debug.FunctionTimer().End()
 	state := loadState(key)
 	switch {
 	case isSudo(key):