[Services] Keep Process Compose alive in background, add attach command
#2269
Conversation
There was a problem hiding this comment.
LGTM, though as discussed offline this doesn't completely address
If process-compose is not terminated gracefully (e.g., it's parent shell crashes, or is closed on accident), then process-compose may terminate without also terminating it's services.
specifically if pc is started in the foreground.
Should we apply the backgrounding to devbox services up as well?
I don't think so. Usually when people terminate a foreground process they don't expect it to continue.
|
@mikeland73 I think I have foreground handled without needing to start up a background process/daemon in the latest commit. I'm not sure exactly what signal is being sent by the terminal, but this seemed to work in my testing. Note that we cannot handle a SIGKILL signal gracefully, so this won't work in those scenarios |
Lagoja
force-pushed
the
jl/attach-pc
branch
from
c36a91d to
55f358b
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Summary
This fixes two previously reported issues:
attachcommand to re-attach the TUI to the backgrounded process composeA few current limitations:
devbox services up -b, but could be extended todevbox services upas well by starting process-compose in the background, and then attaching the TUIdevbox services stopto stop process-compose for your projectTodos:
devbox services upas well?How was it tested?
Tested on the Apache example:
Attach:
devbox services up -bin the apache folderdevbox services attachin the apache folder, verify that it launches the TUIBackgrounding:
4. Run
devbox services list, verify that process-compose is still running5. Terminate your shell or editor
6. Launch a new shell or editor, navigate to the apache example
7. Run
devbox services listto verify that process-compose is still running.