nix: make DetSys installer the default #2447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the feature flag and make the DetSys installer the default.
- Download the installer directly in case the system doesn't have curl.
- Expose the auto-install functionality in the public nix package so we
can reuse it elsewhere.
- Remove some checks that were only relevant to the old installer (WSL2
limitations and warnings about root).
The install logic is also now part of an `Installer` struct to provide
some flexibility around what install program is run and when it's
downloaded.
type Installer struct{ ... }
func (i *Installer) Download(ctx context.Context) error
func (i *Installer) Run(ctx context.Context) error
gcurtis
force-pushed
the
gcurtis/detsys-installer
branch
from
bb23894 to
1c8f791
Compare
savil
approved these changes
Dec 12, 2024
| return err | ||
| } | ||
| spinny := spinner.New(spinner.CharSets[11], 100*time.Millisecond, spinner.WithWriter(writer)) | ||
| spinny.Suffix = " Downloading the Nix installer..." |
There was a problem hiding this comment.
nit: drop the prefix space?
There was a problem hiding this comment.
I think this puts a space between the spinner and the message. I copied what we have for Computing the Devbox environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the feature flag and make the DetSys installer the default.
The install logic is also now part of an
Installerstruct to provide some flexibility around what install program is run and when it's downloaded.