From 166dc27f04986875d15761ded7eaee763ebb1f66 Mon Sep 17 00:00:00 2001 From: Savil Srivastava <676452+savil@users.noreply.github.com> Date: Tue, 3 Jun 2025 09:32:31 -0700 Subject: [PATCH 1/2] add GITHUB_TOKEN to some GHA workflows --- .github/workflows/cache-upload.yml | 1 + .github/workflows/cli-tests.yaml | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cache-upload.yml b/.github/workflows/cache-upload.yml index 4bf2b431360..a81562f2a52 100644 --- a/.github/workflows/cache-upload.yml +++ b/.github/workflows/cache-upload.yml @@ -21,6 +21,7 @@ env: DEVBOX_API_TOKEN: ${{ secrets.DEVBOX_API_TOKEN }} DEVBOX_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} DEVBOX_DEBUG: 1 + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} jobs: upload-cache: diff --git a/.github/workflows/cli-tests.yaml b/.github/workflows/cli-tests.yaml index ecc0f569105..2348393be63 100644 --- a/.github/workflows/cli-tests.yaml +++ b/.github/workflows/cli-tests.yaml @@ -39,14 +39,15 @@ defaults: shell: bash env: - HOMEBREW_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} + DEVBOX_DEBUG: 1 DEVBOX_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + HOMEBREW_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} HOMEBREW_NO_ANALYTICS: 1 HOMEBREW_NO_AUTO_UPDATE: 1 HOMEBREW_NO_EMOJI: 1 HOMEBREW_NO_ENV_HINTS: 1 HOMEBREW_NO_INSTALL_CLEANUP: 1 - DEVBOX_DEBUG: 1 jobs: build-devbox: From 517b41397acbed439577f1b593d48046270d7ed4 Mon Sep 17 00:00:00 2001 From: Savil Srivastava <676452+savil@users.noreply.github.com> Date: Tue, 3 Jun 2025 10:22:41 -0700 Subject: [PATCH 2/2] clear GITHUB_TOKEN in one TestGithubPluginAuth case --- internal/plugin/github_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/internal/plugin/github_test.go b/internal/plugin/github_test.go index 7aaebcd8415..d51e698b0ef 100644 --- a/internal/plugin/github_test.go +++ b/internal/plugin/github_test.go @@ -117,6 +117,7 @@ func TestGithubPluginAuth(t *testing.T) { expectedURL := "https://raw.githubusercontent.com/jetpack-io/devbox-plugins/master/test" t.Run("generate request for public Github repository", func(t *testing.T) { + t.Setenv("GITHUB_TOKEN", "") url, err := githubPlugin.url("test") assert.NoError(t, err) actual, err := githubPlugin.request(url)