Skip to content

Commit 8fbad01

Browse files
authored
fix(ui): Don't render a button in a button (#782)
Gets rid of warning at initial page load.
1 parent 8a90555 commit 8fbad01

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

ui/src/components/Header.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ export default function DashboardNavbar({
103103
<hr className="h-[20px] w-px self-center border-none bg-slate-800/20 dark:bg-slate-300/20" />
104104
<div className="relative inline-block text-left">
105105
<Menu>
106-
<MenuButton className="h-full">
106+
<MenuButton as="div" className="h-full">
107107
<Button className="flex h-full items-center gap-x-3 rounded-md border border-slate-800/20 bg-white px-2 py-1.5 dark:border-slate-600 dark:bg-slate-800 dark:text-white">
108108
{picture ? (
109109
<img

ui/src/components/KvmCard.tsx

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -100,15 +100,12 @@ export default function KvmCard({
100100
)}
101101
</div>
102102
<Menu as="div" className="relative inline-block text-left">
103-
<div>
104-
<MenuButton
105-
as={Button}
106-
theme="light"
107-
TrailingIcon={LuEllipsisVertical}
108-
size="MD"
109-
></MenuButton>
110-
</div>
111-
103+
<MenuButton
104+
as={Button}
105+
theme="light"
106+
TrailingIcon={LuEllipsisVertical}
107+
size="MD"
108+
></MenuButton>
112109
<MenuItems
113110
transition
114111
className="data-closed:scale-95 data-closed:transform data-closed:opacity-0 data-enter:duration-100 data-leave:duration-75 data-enter:ease-out data-leave:ease-in"

ui/src/main.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ if (isOnDevice) {
116116
path: "/",
117117
errorElement: <ErrorBoundary />,
118118
element: <DeviceRoute />,
119+
HydrateFallback: () => <div className="p-4">Loading...</div>,
119120
loader: DeviceRoute.loader,
120121
children: [
121122
{

0 commit comments

Comments
 (0)