Skip to content

Commit 916ed3e

Browse files
committed
chore(ui): Clean new keyboard option
Fixed the Tailwind CSS syntax for `in` (nested) selector Added missing React dependency for `useEffect`
1 parent b91a995 commit 916ed3e

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

ui/src/routes/devices.$id.settings.keyboard.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export default function SettingsKeyboardRoute() {
2525
if ("error" in resp) return;
2626
setKeyboardLayout(resp.result as string);
2727
});
28-
}, []);
28+
}, [send, setKeyboardLayout]);
2929

3030
const onKeyboardLayoutChange = useCallback(
3131
(e: React.ChangeEvent<HTMLSelectElement>) => {
@@ -51,7 +51,6 @@ export default function SettingsKeyboardRoute() {
5151
/>
5252

5353
<div className="space-y-4">
54-
{ /* this menu item could be renamed to plain "Keyboard layout" in the future, when also the virtual keyboard layout mappings are being implemented */ }
5554
<SettingsItem
5655
title="Paste text"
5756
description="Keyboard layout of target operating system"

ui/src/routes/devices.$id.settings.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ export default function SettingsRoute() {
151151
className={({ isActive }) => (isActive ? "active" : "")}
152152
>
153153
<div className="flex items-center gap-x-2 rounded-md px-2.5 py-2.5 text-sm transition-colors hover:bg-slate-100 dark:hover:bg-slate-700 in-[.active]:bg-blue-50 in-[.active]:text-blue-700! md:in-[.active]:bg-transparent dark:in-[.active]:bg-blue-900 dark:in-[.active]:text-blue-200! dark:md:in-[.active]:bg-transparent">
154-
155154
<LuMouse className="h-4 w-4 shrink-0" />
156155
<h1>Mouse</h1>
157156
</div>
@@ -163,7 +162,7 @@ export default function SettingsRoute() {
163162
to="keyboard"
164163
className={({ isActive }) => (isActive ? "active" : "")}
165164
>
166-
<div className="flex items-center gap-x-2 rounded-md px-2.5 py-2.5 text-sm transition-colors hover:bg-slate-100 dark:hover:bg-slate-700 [.active_&]:bg-blue-50 [.active_&]:!text-blue-700 md:[.active_&]:bg-transparent dark:[.active_&]:bg-blue-900 dark:[.active_&]:!text-blue-200 dark:md:[.active_&]:bg-transparent">
165+
<div className="flex items-center gap-x-2 rounded-md px-2.5 py-2.5 text-sm transition-colors hover:bg-slate-100 dark:hover:bg-slate-700 in-[.active]:bg-blue-50 in-[.active]:text-blue-700! md:in-[.active]:bg-transparent dark:in-[.active]:bg-blue-900 dark:in-[.active]:text-blue-200! dark:md:in-[.active]:bg-transparent">
167166
<LuKeyboard className="h-4 w-4 shrink-0" />
168167
<h1>Keyboard</h1>
169168
</div>

0 commit comments

Comments
 (0)