Skip to content

Commit 8e380f8

Browse files
committed
Docs: detail how to update an existing minor version
Signed-off-by: Maël Valais <[email protected]>
1 parent 2b3b3f4 commit 8e380f8

File tree

1 file changed

+27
-27
lines changed

1 file changed

+27
-27
lines changed

docs/TESTING-DEPLOYER.md

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -116,49 +116,49 @@ Here is the command I did to retag all `google-review` images to
116116
[#10](https://github.com/jetstack/jetstack-secure-gcm/issues/10)):
117117

118118
```sh
119-
while read img; do
120-
docker pull $img:google-review
121-
docker tag $img:{google-review,1.1.0-gcm.1}
122-
docker push $img:1.1.0-gcm.1
123-
done <<EOF
124-
gcr.io/jetstack-public/jetstack-secure-for-cert-manager
125-
gcr.io/jetstack-public/jetstack-secure-for-cert-manager/cert-manager-acmesolver
126-
gcr.io/jetstack-public/jetstack-secure-for-cert-manager/cert-manager-cainjector
127-
gcr.io/jetstack-public/jetstack-secure-for-cert-manager/cert-manager-webhook
128-
gcr.io/jetstack-public/jetstack-secure-for-cert-manager/cert-manager-google-cas-issuer
129-
gcr.io/jetstack-public/jetstack-secure-for-cert-manager/preflight
119+
retag() {
120+
docker pull $1 && docker tag $1 $2 && docker push $2
121+
}
122+
retag gcr.io/jetstack-public/jetstack-secure-for-cert-manager{google-review,1.1.0-gcm.1}
123+
retag gcr.io/jetstack-public/jetstack-secure-for-cert-manager/cert-manager-acmesolver{google-review,1.1.0-gcm.1}
124+
retag gcr.io/jetstack-public/jetstack-secure-for-cert-manager/cert-manager-cainjector{google-review,1.1.0-gcm.1}
125+
retag gcr.io/jetstack-public/jetstack-secure-for-cert-manager/cert-manager-webhook{google-review,1.1.0-gcm.1}
126+
retag gcr.io/jetstack-public/jetstack-secure-for-cert-manager/cert-manager-google-cas-issuer{google-review,1.1.0-gcm.1}
127+
retag gcr.io/jetstack-public/jetstack-secure-for-cert-manager/preflight{google-review,1.1.0-gcm.1}
128+
retag gcr.io/cloud-marketplace-tools/metering/ubbagent:latest gcr.io/jetstack-public/jetstack-secure-for-cert-manager/ubbagent:1.1.0-gcm.1
130129
EOF
131130
```
132131

133132
## Cutting a new release
134133

135134
First, run Cloud Build. That will push the deployer and smoke-test images
136-
using a tag of the form `build-3dc9ba45-d23c-441c-8809-ac693054716e`.
135+
using the version set in `_APP_VERSION`, e.g., `1.1.0-gcm.1`.
137136

138137
```sh
139138
gcloud builds submit --project jetstack-public --timeout 1800s --config cloudbuild.yaml \
140139
--substitutions _CLUSTER_NAME=smoke-test,_CLUSTER_LOCATION=europe-west2-b
141140
```
142141

143-
Imagining that you want to release the application version `1.1.0-gcm.2`,
144-
you will have to run the following in order to "promote" the tester and
145-
deployer:
142+
Three images are pushed to the "staging" registry
146143

147144
```sh
148-
retag() {
149-
docker pull $1:$2
150-
docker tag $1:{$2,$3}
151-
docker push $1:$3
152-
}
153-
154-
retag gcr.io/jetstack-public/jetstack-secure-for-cert-manager/deployer build-3dc9ba45-d23c-441c-8809-ac693054716e 1.1
155-
retag gcr.io/jetstack-public/jetstack-secure-for-cert-manager/deployer build-3dc9ba45-d23c-441c-8809-ac693054716e 1.1.0-gcm.2
156-
retag gcr.io/jetstack-public/jetstack-secure-for-cert-manager/smoke-test build-3dc9ba45-d23c-441c-8809-ac693054716e 1.1.0-gcm.2
145+
gcr.io/jetstack-public/jetstack-secure-for-cert-manager/deployer:1.1
146+
gcr.io/jetstack-public/jetstack-secure-for-cert-manager/deployer:1.1.0-gcm.1
147+
gcr.io/jetstack-public/jetstack-secure-for-cert-manager/smoke-test:1.1.0-gcm.1
157148
```
158149

159-
> Note: pushing the `deployer:1.1.0-gcm.2` image is not mandatory; only the
160-
> `1.1` tag is required by the Marketplace UI. But we still push
161-
> `1.1.0-gcm.2` for debugging purposes.
150+
In order to get these images published to the official
151+
`marketplace.gcr.io`, you need to register the version.
152+
153+
If the minor version, e.g. `1.1`, already exists, then you will need to
154+
update the existing minor version:
155+
156+
<img src="https://user-images.githubusercontent.com/2195781/110706910-daf08380-81f8-11eb-92ef-d62ef7ff4de1.png" width="300" alt="To update the already released minor version, first open the existing minor version by clicking on the version itself (it is a link). This screenshot is stored in this issue: https://github.com/jetstack/jetstack-secure-gcm/issues/21">
157+
158+
<img src="https://user-images.githubusercontent.com/2195781/110706906-d9bf5680-81f8-11eb-909f-faa1818b8f56.png" width="300" alt="Then, click on Update images and Save. This screenshot is stored in this issue: https://github.com/jetstack/jetstack-secure-gcm/issues/21">
159+
160+
Finally, you will need to click "Submit for review" and wait a couple of
161+
days until the Google team approves the new (or updated) minor version.
162162

163163
## Testing the application without having access to the Billing API
164164

0 commit comments

Comments
 (0)