Skip to content

Commit 1bf4bca

Browse files
authored
Merge pull request #651 from jetstack/upgrade_klone
Run 'make upgrade-klone' and 'make generate'
2 parents 5fcaddb + 8dce4e4 commit 1bf4bca

File tree

4 files changed

+21
-18
lines changed

4 files changed

+21
-18
lines changed

klone.yaml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,55 +10,55 @@ targets:
1010
- folder_name: generate-verify
1111
repo_url: https://github.com/cert-manager/makefile-modules.git
1212
repo_ref: main
13-
repo_hash: 01f8036da297256be41f6cc520cb248cb0f609fc
13+
repo_hash: 64ae59dc5eefce752ff785f648ac8a8ed0222cbd
1414
repo_path: modules/generate-verify
1515
- folder_name: go
1616
repo_url: https://github.com/cert-manager/makefile-modules.git
1717
repo_ref: main
18-
repo_hash: 01f8036da297256be41f6cc520cb248cb0f609fc
18+
repo_hash: 64ae59dc5eefce752ff785f648ac8a8ed0222cbd
1919
repo_path: modules/go
2020
- folder_name: helm
2121
repo_url: https://github.com/cert-manager/makefile-modules.git
2222
repo_ref: main
23-
repo_hash: 01f8036da297256be41f6cc520cb248cb0f609fc
23+
repo_hash: 64ae59dc5eefce752ff785f648ac8a8ed0222cbd
2424
repo_path: modules/helm
2525
- folder_name: help
2626
repo_url: https://github.com/cert-manager/makefile-modules.git
2727
repo_ref: main
28-
repo_hash: 01f8036da297256be41f6cc520cb248cb0f609fc
28+
repo_hash: 64ae59dc5eefce752ff785f648ac8a8ed0222cbd
2929
repo_path: modules/help
3030
- folder_name: kind
3131
repo_url: https://github.com/cert-manager/makefile-modules.git
3232
repo_ref: main
33-
repo_hash: 01f8036da297256be41f6cc520cb248cb0f609fc
33+
repo_hash: 64ae59dc5eefce752ff785f648ac8a8ed0222cbd
3434
repo_path: modules/kind
3535
- folder_name: klone
3636
repo_url: https://github.com/cert-manager/makefile-modules.git
3737
repo_ref: main
38-
repo_hash: 01f8036da297256be41f6cc520cb248cb0f609fc
38+
repo_hash: 64ae59dc5eefce752ff785f648ac8a8ed0222cbd
3939
repo_path: modules/klone
4040
- folder_name: licenses
4141
repo_url: https://github.com/cert-manager/makefile-modules.git
4242
repo_ref: main
43-
repo_hash: 01f8036da297256be41f6cc520cb248cb0f609fc
43+
repo_hash: 64ae59dc5eefce752ff785f648ac8a8ed0222cbd
4444
repo_path: modules/licenses
4545
- folder_name: oci-build
4646
repo_url: https://github.com/cert-manager/makefile-modules.git
4747
repo_ref: main
48-
repo_hash: 01f8036da297256be41f6cc520cb248cb0f609fc
48+
repo_hash: 64ae59dc5eefce752ff785f648ac8a8ed0222cbd
4949
repo_path: modules/oci-build
5050
- folder_name: oci-publish
5151
repo_url: https://github.com/cert-manager/makefile-modules.git
5252
repo_ref: main
53-
repo_hash: 01f8036da297256be41f6cc520cb248cb0f609fc
53+
repo_hash: 64ae59dc5eefce752ff785f648ac8a8ed0222cbd
5454
repo_path: modules/oci-publish
5555
- folder_name: repository-base
5656
repo_url: https://github.com/cert-manager/makefile-modules.git
5757
repo_ref: main
58-
repo_hash: 01f8036da297256be41f6cc520cb248cb0f609fc
58+
repo_hash: 64ae59dc5eefce752ff785f648ac8a8ed0222cbd
5959
repo_path: modules/repository-base
6060
- folder_name: tools
6161
repo_url: https://github.com/cert-manager/makefile-modules.git
6262
repo_ref: main
63-
repo_hash: 01f8036da297256be41f6cc520cb248cb0f609fc
63+
repo_hash: 64ae59dc5eefce752ff785f648ac8a8ed0222cbd
6464
repo_path: modules/tools

make/_shared/kind/kind.mk

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ kind-cluster-clean: $(NEEDS_KIND)
8080
.PHONY: kind-logs
8181
## Get the Kind cluster
8282
## @category [shared] Kind cluster
83-
kind-logs: | kind-cluster $(NEEDS_KIND) $(bin_dir)/artifacts
84-
rm -rf $(bin_dir)/artifacts/e2e-logs
85-
mkdir -p $(bin_dir)/artifacts/e2e-logs
86-
$(KIND) export logs $(bin_dir)/artifacts/e2e-logs --name=$(kind_cluster_name)
83+
kind-logs: | kind-cluster $(NEEDS_KIND) $(ARTIFACTS)
84+
rm -rf $(ARTIFACTS)/e2e-logs
85+
mkdir -p $(ARTIFACTS)/e2e-logs
86+
$(KIND) export logs $(ARTIFACTS)/e2e-logs --name=$(kind_cluster_name)

make/_shared/tools/00_mod.mk

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ tools += controller-gen=v0.17.3
9393
# https://pkg.go.dev/golang.org/x/tools/cmd/goimports?tab=versions
9494
tools += goimports=v0.31.0
9595
# https://pkg.go.dev/github.com/google/go-licenses/v2?tab=versions
96-
tools += go-licenses=v2.0.0-alpha.1
96+
tools += go-licenses=9c778fc0cb52740485f53cc439b1f3c9578a1830
9797
# https://pkg.go.dev/gotest.tools/gotestsum?tab=versions
9898
tools += gotestsum=v1.12.1
9999
# https://pkg.go.dev/sigs.k8s.io/kustomize/kustomize/v4?tab=versions
@@ -325,7 +325,9 @@ go_dependencies :=
325325
go_dependencies += ginkgo=github.com/onsi/ginkgo/v2/ginkgo
326326
go_dependencies += controller-gen=sigs.k8s.io/controller-tools/cmd/controller-gen
327327
go_dependencies += goimports=golang.org/x/tools/cmd/goimports
328-
go_dependencies += go-licenses=github.com/google/go-licenses/v2
328+
# switch back to github.com/google/go-licenses once
329+
# https://github.com/google/go-licenses/pull/327 is merged.
330+
go_dependencies += go-licenses=github.com/inteon/go-licenses/v2
329331
go_dependencies += gotestsum=gotest.tools/gotestsum
330332
go_dependencies += kustomize=sigs.k8s.io/kustomize/kustomize/v4
331333
go_dependencies += gojq=github.com/itchyny/gojq/cmd/gojq

pkg/internal/cyberark/servicediscovery/discovery_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package servicediscovery
33
import (
44
"context"
55
"crypto/rand"
6-
_ "embed"
76
"encoding/hex"
87
"encoding/json"
98
"fmt"
@@ -13,6 +12,8 @@ import (
1312
"testing"
1413

1514
"github.com/jetstack/preflight/pkg/version"
15+
16+
_ "embed"
1617
)
1718

1819
//go:embed testdata/discovery_success.json

0 commit comments

Comments
 (0)