wip

Author: inteon

.golangci.yaml

@@ -7,14 +7,12 @@ linters:
     rules:
       - linters:
           - bodyclose
-          - dupword
           - errcheck
           - errchkjson
           - forbidigo
           - gocritic
           - gosec
           - govet
-          - misspell
           - musttag
           - nilerr
           - noctx

api/datareading.go

@@ -15,7 +15,7 @@ type DataReadingsPost struct {
 
 // DataReading is the output of a DataGatherer.
 type DataReading struct {
-	// ClusterID is optional as it can be infered from the agent
+	// ClusterID is optional as it can be inferred from the agent
 	// token when using basic authentication.
 	ClusterID     string      `json:"cluster_id,omitempty"`
 	DataGatherer  string      `json:"data-gatherer"`

cmd/root.go

@@ -43,7 +43,7 @@ func init() {
 // Execute adds all child commands to the root command and sets flags appropriately.
 // This is called by main.main(). It only needs to happen once to the rootCmd.
 // If the root command or sub-command returns an error, the error message will
-// will be logged and the process will exit with status 1.
+// be logged and the process will exit with status 1.
 func Execute() {
 	logs.AddFlags(rootCmd.PersistentFlags())
 	ctx := klog.NewContext(context.Background(), klog.Background())

pkg/agent/config.go

@@ -738,11 +738,11 @@ func validateCredsAndCreateClient(log logr.Logger, flagCredentialsPath, flagClie
 		var creds client.Credentials
 
 		if flagClientID != "" && flagCredentialsPath != "" {
-			errs = multierror.Append(errs, fmt.Errorf("--client-id and --credentials-file cannot be used simultanously"))
+			errs = multierror.Append(errs, fmt.Errorf("--client-id and --credentials-file cannot be used simultaneously"))
 			break
 		}
 		if flagPrivateKeyPath != "" && flagCredentialsPath != "" {
-			errs = multierror.Append(errs, fmt.Errorf("--private-key-path and --credentials-file cannot be used simultanously"))
+			errs = multierror.Append(errs, fmt.Errorf("--private-key-path and --credentials-file cannot be used simultaneously"))
 			break
 		}
 		if flagClientID == "" && flagPrivateKeyPath == "" && flagCredentialsPath == "" {

pkg/agent/run.go

@@ -111,7 +111,7 @@ func Run(cmd *cobra.Command, args []string) (returnErr error) {
 		}
 
 		// Health check endpoint. Since we haven't figured a good way of knowning
-		// what "ready" means for the agent, we just return 200 OK inconditionally.
+		// what "ready" means for the agent, we just return 200 OK unconditionally.
 		// The goal is to satisfy some Kubernetes distributions, like OpenShift,
 		// that require a liveness and health probe to be present for each pod.
 		log.Info("Healthz endpoints enabled", "path", "/healthz")

pkg/client/client_venconn_test.go

@@ -300,6 +300,8 @@ func run_TestVenConnClient_PostDataReadingsWithOptions(ctx context.Context, rest
 //	sub-test-has-special-chars-and-is-also-super-super-super-super-
 //
 // Only the last part of the test name is used.
+//
+// nolint:dupword
 func testNameToNamespace(t testing.TB) string {
 	regex := regexp.MustCompile("[^a-zA-Z0-9-]")
 

pkg/datagatherer/k8s/dynamic.go

@@ -473,7 +473,7 @@ func RemoveUnstructuredKeys(excludeKeys []*regexp.Regexp, obj *unstructured.Unst
 		return
 	}
 
-	// The field may be nil since yaml.Unmarshal's omitempty might not be set on
+	// The field may be nil since yaml.Unmarshal's omitempty might not be set
 	// on this struct field.
 	if annotsRaw == nil {
 		return