Skip to content

Commit 545b0ab

Browse files
authored
Merge pull request #585 from jetstack/update-readme
README: Release process: push git tag before editing the release
2 parents 350beaa + 27ff70e commit 545b0ab

File tree

1 file changed

+42
-27
lines changed

1 file changed

+42
-27
lines changed

README.md

Lines changed: 42 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
[![release-master](https://github.com/jetstack/jetstack-secure/actions/workflows/release-master.yml/badge.svg)](https://github.com/jetstack/jetstack-secure/actions/workflows/release-master.yml)
1+
[![tests](https://github.com/jetstack/jetstack-secure/actions/workflows/tests.yaml/badge.svg)](https://github.com/jetstack/jetstack-secure/actions/workflows/tests.yaml)
22
[![Go Reference](https://pkg.go.dev/badge/github.com/jetstack/jetstack-secure.svg)](https://pkg.go.dev/github.com/jetstack/jetstack-secure)
33
[![Go Report Card](https://goreportcard.com/badge/github.com/jetstack/jetstack-secure)](https://goreportcard.com/report/github.com/jetstack/jetstack-secure)
44

@@ -92,15 +92,27 @@ The Helm charts are:
9292
9393
The release process is semi-automated.
9494

95-
### Step 1: Incrementing Versions And Git Tag
96-
97-
1. Go to the GitHub Releases page and click "Draft a New Release".
98-
- Click "Create a new tag" with the version number prefixed with `v` (e.g., `v1.1.0`).
99-
- Use the title "v1.1.0",
100-
- Click "Generate Release Notes"
101-
- Edit the release notes to make them readable to the end-user.
102-
- Click "Publish" (don't select "Draft")
103-
2. Inform Michael McLoughlin of the new release so he can update the
95+
### Step 1: Git Tag and GitHub Release
96+
97+
1. Create a tag for the new release:
98+
```sh
99+
export VERSION=v1.1.0
100+
git tag --annotate --message="Release ${VERSION}" "${VERSION}"
101+
git push origin "${VERSION}"
102+
```
103+
2. A GitHub action will see the new tag and do the following:
104+
- Build and publish the container image at `quay.io/jetstack/venafi-agent`,
105+
- Build and publish the Helm chart at `oci://quay.io/jetstack/charts/venafi-kubernetes-agent`,
106+
- Create a draft GitHub release,
107+
- Upload the Helm chart tarball to the GitHub release.
108+
3. Navigate to the GitHub Releases page and select the draft release to edit.
109+
1. Click on “Generate release notes” to automatically compile the changelog.
110+
2. Review and refine the generated notes to ensure they’re clear and useful
111+
for end users.
112+
3. Remove any irrelevant entries, such as “update deps,” “update CI,” “update
113+
docs,” or similar internal changes that do not impact user functionality.
114+
4. Publish the release.
115+
5. Inform Michael McLoughlin of the new release so he can update the
104116
documentation at <https://docs.venafi.cloud/>.
105117

106118
> [!NOTE]
@@ -145,8 +157,8 @@ The release process is semi-automated.
145157
> ```text
146158
> v1.1.0 (Git tag in the jetstack-secure repo)
147159
> └── quay.io/jetstack/venafi-agent:v1.1.0 (GitHub Actions in the jetstack-secure repo)
148-
> ├── us.gcr.io/jetstack-secure-enterprise/venafi-agent (Enterprise Builds's GitHub Actions)
149-
> └── eu.gcr.io/jetstack-secure-enterprise/venafi-agent (Enterprise Builds's GitHub Actions)
160+
> ├── us.gcr.io/jetstack-secure-enterprise/venafi-agent:v1.1.0 (Enterprise Builds's GitHub Actions)
161+
> └── eu.gcr.io/jetstack-secure-enterprise/venafi-agent:v1.1.0 (Enterprise Builds's GitHub Actions)
150162
> ├── registry.venafi.cloud/venafi-agent/venafi-agent:v1.1.0 (Harbor Replication)
151163
> ├── private-registry.venafi.cloud/venafi-agent/venafi-agent:v1.1.0 (Harbor Replication)
152164
> └── private-registry.venafi.eu/venafi-agent/venafi-agent:v1.1.0 (Harbor Replication)
@@ -166,16 +178,24 @@ NOTE(mael): TBD
166178
This step is performed by Peter Fiddes and Adrian Lai separately from the main
167179
release process.
168180
169-
Run the Helm Chart workflow
170-
[release_js-agent_chart.yaml](https://github.com/jetstack/enterprise-builds/actions/workflows/release_js-agent_chart.yaml).
181+
The `jetstack-secure` chart is for [Jetstack
182+
Secure](https://platform.jetstack.io/documentation/installation/agent#jetstack-agent-helm-chart-installation).
183+
It is composed of two OCI Helm charts:
184+
185+
- `oci://eu.gcr.io/jetstack-secure-enterprise/charts/jetstack-agent`
186+
- `oci://us.gcr.io/jetstack-secure-enterprise/charts/jetstack-agent`
171187
172-
The [jetstack-agent](deploy/charts/jetstack-agent/README.md) chart has a different version number to the agent.
173-
This is because the first version of _this_ chart was given version `0.1.0`,
174-
while the app version at the time was `0.1.38`.
175-
And this allows the chart to be updated and released more frequently than the Docker image if necessary.
176-
This chart is for [Jetstack Secure](https://platform.jetstack.io/documentation/installation/agent#jetstack-agent-helm-chart-installation).
188+
> [!NOTE]
189+
>
190+
> The [jetstack-agent](deploy/charts/jetstack-agent/README.md) chart has a
191+
> different version number to the agent. This is because the first version of
192+
> _this_ chart was given version `0.1.0`, while the app version at the time was
193+
> `0.1.38`. And this allows the chart to be updated and released more frequently
194+
> than the Docker image if necessary.
177195
178-
1. Create a branch
196+
The process is as follows:
197+
198+
1. Create a branch.
179199
2. Increment version numbers.
180200
1. Increment the `version` value in [Chart.yaml](deploy/charts/jetstack-agent/Chart.yaml).
181201
DO NOT use a `v` prefix.
@@ -190,10 +210,5 @@ This chart is for [Jetstack Secure](https://platform.jetstack.io/documentation/i
190210
```
191211
3. Create a pull request and wait for it to be approved.
192212
4. Merge the branch
193-
5. Push a tag, using the format: `chart-vX.Y.Z`.
194-
This unique tag format is recognized by the private CI pipeline that builds and publishes the chart.
195-
196-
The chart will be published to
197-
the [Jetstack Enterprise Registry](https://platform.jetstack.io/documentation/installation/agent#1-obtain-oci-registry-credentials)
198-
by a private CI pipeline managed by Venafi.
199-
213+
5. Manually trigger the Helm Chart workflow:
214+
[release_js-agent_chart.yaml](https://github.com/jetstack/enterprise-builds/actions/workflows/release_js-agent_chart.yaml).

0 commit comments

Comments
 (0)