chore(lint): update import grouping for preflight repo in golangci config

- Change gci import prefix to github.com/jetstack/preflight in .golangci.yaml
- Add makefile hack to set repo_name for golangci-lint config generation
- Document workaround until go module can be renamed

Signed-off-by: Richard Wall <[email protected]>

Author: wallrj-cyberark

.golangci.yaml

@@ -81,7 +81,7 @@ formatters:
       sections:
         - standard # Standard section: captures all standard packages.
         - default # Default section: contains all imports that could not be matched to another section type.
-        - prefix(github.com/jetstack/jetstack-secure) # Custom section: groups all imports with the specified Prefix.
+        - prefix(github.com/jetstack/preflight) # Custom section: groups all imports with the specified Prefix.
         - blank # Blank section: contains all blank imports. This section is not present unless explicitly enabled.
         - dot # Dot section: contains all dot imports. This section is not present unless explicitly enabled.
   exclusions:

make/00_mod.mk

@@ -1,4 +1,10 @@
 repo_name := github.com/jetstack/jetstack-secure
+# TODO(wallrj): This is a hack to allow use the old preflight repo name in the
+# gci section of the golangci-lint config until we can rename the go module.
+# Without this hack, golangci-lint will complain that the
+# github.com/jetstack/preflight imports should be grouped with all the other
+# third-party modules.
+generate-golangci-lint-config: repo_name := github.com/jetstack/preflight
 
 license_ignore := gitlab.com/venafi,github.com/jetstack