address review feedback: error unchecked in client_venconn_test.go

maelvls · wallrj · maelvls · commit 804d81d7899e · 2024-08-22T10:55:58.000+02:00
Co-authored-by: Richard Wall &lt;978965+wallrj@users.noreply.github.com&gt;
diff --git a/pkg/client/client_venconn_test.go b/pkg/client/client_venconn_test.go
@@ -195,7 +195,8 @@ func run(test testcase) func(t *testing.T) {
 		}
 
 		got := v1alpha1.VenafiConnection{}
-		kclient.Get(context.Background(), types.NamespacedName{Name: "venafi-components", Namespace: "venafi"}, &got)
+		err = kclient.Get(context.Background(), types.NamespacedName{Name: "venafi-components", Namespace: "venafi"}, &got)
+		require.NoError(t, err)
 		require.Len(t, got.Status.Conditions, 1)
 		assert.Equal(t, test.expectReadyCondMsg, got.Status.Conditions[0].Message)
 	}

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,8 @@ func run(test testcase) func(t *testing.T) {`
`195`	`195`	`}`
`196`	`196`
`197`	`197`	`got := v1alpha1.VenafiConnection{}`
`198`		`- kclient.Get(context.Background(), types.NamespacedName{Name: "venafi-components", Namespace: "venafi"}, &got)`
	`198`	`+ err = kclient.Get(context.Background(), types.NamespacedName{Name: "venafi-components", Namespace: "venafi"}, &got)`
	`199`	`+ require.NoError(t, err)`
`199`	`200`	`require.Len(t, got.Status.Conditions, 1)`
`200`	`201`	`assert.Equal(t, test.expectReadyCondMsg, got.Status.Conditions[0].Message)`
`201`	`202`	`}`