Log the bubbled up error instead of printing it

wallrj · wallrj · commit 810b0332f3c5 · 2024-10-31T09:54:27.000Z
Signed-off-by: Richard Wall &lt;richard.wall@venafi.com&gt;
diff --git a/cmd/root.go b/cmd/root.go
@@ -5,9 +5,10 @@ import (
 	"os"
 	"strings"
 
-	"github.com/jetstack/preflight/pkg/logs"
 	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
+
+	"github.com/jetstack/preflight/pkg/logs"
 )
 
 // rootCmd represents the base command when called without any subcommands
@@ -35,8 +36,7 @@ func Execute() {
 	logs.AddFlags(rootCmd.PersistentFlags())
 
 	if err := rootCmd.Execute(); err != nil {
-		fmt.Println(err)
-		os.Exit(1)
+		logs.Log.Fatal(err)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -5,9 +5,10 @@ import (`
`5`	`5`	`"os"`
`6`	`6`	`"strings"`
`7`	`7`
`8`		`- "github.com/jetstack/preflight/pkg/logs"`
`9`	`8`	`"github.com/spf13/cobra"`
`10`	`9`	`"github.com/spf13/pflag"`
	`10`	`+`
	`11`	`+ "github.com/jetstack/preflight/pkg/logs"`
`11`	`12`	`)`
`12`	`13`
`13`	`14`	`// rootCmd represents the base command when called without any subcommands`
`@@ -35,8 +36,7 @@ func Execute() {`
`35`	`36`	`logs.AddFlags(rootCmd.PersistentFlags())`
`36`	`37`
`37`	`38`	`if err := rootCmd.Execute(); err != nil {`
`38`		`- fmt.Println(err)`
`39`		`- os.Exit(1)`
	`39`	`+ logs.Log.Fatal(err)`
`40`	`40`	`}`
`41`	`41`	`}`
`42`	`42`