Skip to content

Commit 8683d26

Browse files
authored
Merge pull request #526 from jetstack/add-namespace-helm
Helm: the namespace was missing in the configmap, deployment, and serviceaccount templates
2 parents f81b625 + 2071b44 commit 8683d26

File tree

8 files changed

+8
-0
lines changed

8 files changed

+8
-0
lines changed

deploy/charts/jetstack-agent/templates/configmap.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ apiVersion: v1
44
kind: ConfigMap
55
metadata:
66
name: agent-config
7+
namespace: {{ .Release.Namespace }}
78
labels:
89
{{- include "jetstack-agent.labels" . | nindent 4 }}
910
data:

deploy/charts/jetstack-agent/templates/deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ apiVersion: apps/v1
33
kind: Deployment
44
metadata:
55
name: {{ include "jetstack-agent.fullname" . }}
6+
namespace: {{ .Release.Namespace }}
67
labels:
78
{{- include "jetstack-agent.labels" . | nindent 4 }}
89
spec:

deploy/charts/jetstack-agent/templates/secret.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ apiVersion: v1
33
kind: Secret
44
metadata:
55
name: {{ .Values.authentication.secretName}}
6+
namespace: {{ .Release.Namespace }}
67
labels:
78
{{- include "jetstack-agent.labels" . | nindent 4 }}
89
type: Opaque

deploy/charts/jetstack-agent/templates/serviceaccount.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ apiVersion: v1
33
kind: ServiceAccount
44
metadata:
55
name: {{ include "jetstack-agent.serviceAccountName" . }}
6+
namespace: {{ .Release.Namespace }}
67
labels:
78
{{- include "jetstack-agent.labels" . | nindent 4 }}
89
{{- with .Values.serviceAccount.annotations }}

deploy/charts/jetstack-agent/tests/__snapshot__/configuration_test.yaml.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,3 +194,4 @@ render correctly when only required config is given:
194194
app.kubernetes.io/version: v0.1.43
195195
helm.sh/chart: jetstack-agent-0.3.1
196196
name: agent-config
197+
namespace: NAMESPACE

deploy/charts/venafi-kubernetes-agent/templates/configmap.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ apiVersion: v1
44
kind: ConfigMap
55
metadata:
66
name: agent-config
7+
namespace: {{ .Release.Namespace }}
78
labels:
89
{{- include "venafi-kubernetes-agent.labels" . | nindent 4 }}
910
data:

deploy/charts/venafi-kubernetes-agent/templates/deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ apiVersion: apps/v1
22
kind: Deployment
33
metadata:
44
name: {{ include "venafi-kubernetes-agent.fullname" . }}
5+
namespace: {{ .Release.Namespace }}
56
labels:
67
{{- include "venafi-kubernetes-agent.labels" . | nindent 4 }}
78
spec:

deploy/charts/venafi-kubernetes-agent/templates/serviceaccount.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ apiVersion: v1
33
kind: ServiceAccount
44
metadata:
55
name: {{ include "venafi-kubernetes-agent.serviceAccountName" . }}
6+
namespace: {{ .Release.Namespace }}
67
labels:
78
{{- include "venafi-kubernetes-agent.labels" . | nindent 4 }}
89
{{- with .Values.serviceAccount.annotations }}

0 commit comments

Comments
 (0)