tests: fix left over kube-apiserver and etcd processes

Sometimes (for example when the CRD file isn't found), the test would
stop immediately after envtest.Start, meaning that the t.Cleanup block
wouldn't run and the two new processes would be left over after the test
process would end.

The credit for identifying this bug and fixing goes to Richard Wall in
[1].

[1]: #560 (comment)

Co-authored-by: Richard Wall <[email protected]>

Author: maelvls

pkg/client/client_venconn_test.go

@@ -346,14 +346,14 @@ func startEnvtest(t testing.TB) (_ *envtest.Environment, _ *rest.Config, kclient
 		ErrorIfCRDPathMissing: true,
 		CRDDirectoryPaths:     []string{"../../deploy/charts/venafi-kubernetes-agent/crd_bases/jetstack.io_venaficonnections.yaml"},
 	}
-	restconf, err := envtest.Start()
-	require.NoError(t, err)
 
+	restconf, err := envtest.Start()
 	t.Cleanup(func() {
 		t.Log("Waiting for envtest to exit")
-		err = envtest.Stop()
-		require.NoError(t, err)
+		e := envtest.Stop()
+		require.NoError(t, e)
 	})
+	require.NoError(t, err)
 
 	sch := runtime.NewScheme()
 	_ = v1alpha1.AddToScheme(sch)